* [PATCH] mtd: bcm47xxnflash: Add error handling for bcm47xxnflash_ops_bcm4706_ctl_cmd().
@ 2025-04-03 13:47 Wentao Liang
2025-04-04 13:55 ` Markus Elfring
0 siblings, 1 reply; 2+ messages in thread
From: Wentao Liang @ 2025-04-03 13:47 UTC (permalink / raw)
To: miquel.raynal, richard, vigneshr; +Cc: linux-mtd, linux-kernel, Wentao Liang
The bcm47xxnflash_ops_bcm4706_cmd_ctrl() calls
bcm47xxnflash_ops_bcm4706_ctl_cmd() without printing error message. A
proper implementation can be found in bcm47xxnflash_ops_bcm4706_write().
Add error log to the bcm47xxnflash_ops_bcm4706_ctl_cmd() to prevent
selent failure.
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
---
drivers/mtd/nand/raw/bcm47xxnflash/ops_bcm4706.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/raw/bcm47xxnflash/ops_bcm4706.c b/drivers/mtd/nand/raw/bcm47xxnflash/ops_bcm4706.c
index 6487dfc64258..c89129588bb6 100644
--- a/drivers/mtd/nand/raw/bcm47xxnflash/ops_bcm4706.c
+++ b/drivers/mtd/nand/raw/bcm47xxnflash/ops_bcm4706.c
@@ -182,7 +182,8 @@ static void bcm47xxnflash_ops_bcm4706_cmd_ctrl(struct nand_chip *nand_chip,
if (cmd != NAND_CMD_RESET)
code |= NCTL_CSA;
- bcm47xxnflash_ops_bcm4706_ctl_cmd(b47n->cc, code);
+ if (bcm47xxnflash_ops_bcm4706_ctl_cmd(b47n->cc, code))
+ pr_err("%s ctl_cmd didn't work!\n", __func__);
}
/* Default nand_select_chip calls cmd_ctrl, which is not used in BCM4706 */
--
2.42.0.windows.2
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mtd: bcm47xxnflash: Add error handling for bcm47xxnflash_ops_bcm4706_ctl_cmd().
2025-04-03 13:47 [PATCH] mtd: bcm47xxnflash: Add error handling for bcm47xxnflash_ops_bcm4706_ctl_cmd() Wentao Liang
@ 2025-04-04 13:55 ` Markus Elfring
0 siblings, 0 replies; 2+ messages in thread
From: Markus Elfring @ 2025-04-04 13:55 UTC (permalink / raw)
To: vulab, linux-mtd
Cc: LKML, Miquel Raynal, Richard Weinberger, Vignesh Raghavendra
…
> Add error log to the bcm47xxnflash_ops_bcm4706_ctl_cmd() to prevent
> selent failure.
silent?
You may omit a dot at the end of summary phrases.
https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.14#n665
Regards,
Markus
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-04-04 14:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-03 13:47 [PATCH] mtd: bcm47xxnflash: Add error handling for bcm47xxnflash_ops_bcm4706_ctl_cmd() Wentao Liang
2025-04-04 13:55 ` Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox