[PATCH v2] mtd: maps: remove dead select of MTD_CFI_BE_BYTE_SWAP

[PATCH v2] mtd: maps: remove dead select of MTD_CFI_BE_BYTE_SWAP

[Julian Braha]

'select' does not work on config options in a 'choice', so currently it is
possible to enable MTD_PHYSMAP_IXP4XX without MTD_CFI_BE_BYTE_SWAP.

From a previous conversation, it was decided to remove the select entirely:
https://lore.kernel.org/all/c6268184-4904-49d9-b14f-0e11dce8bdad@app.fastmail.com/

This dead select was found by kconfirm, a static analysis tool for Kconfig.

Signed-off-by: Julian Braha <julianbraha@gmail.com>
---
Changes since v1: remove 'select' instead of using 'depends on'
Link:
https://lore.kernel.org/all/20260722001003.36598-1-julianbraha@gmail.com/
---
 drivers/mtd/maps/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/mtd/maps/Kconfig b/drivers/mtd/maps/Kconfig
index f447902d707e..1bb3dba2631d 100644
--- a/drivers/mtd/maps/Kconfig
+++ b/drivers/mtd/maps/Kconfig
@@ -101,7 +101,6 @@ config MTD_PHYSMAP_IXP4XX
 	depends on MTD_PHYSMAP_OF
 	depends on ARM
 	select MTD_COMPLEX_MAPPINGS
-	select MTD_CFI_BE_BYTE_SWAP if CPU_BIG_ENDIAN
 	default ARCH_IXP4XX
 	help
 	  This provides some extra DT physmap parsing for the Intel IXP4xx
-- 
2.54.0


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

Re: [PATCH v2] mtd: maps: remove dead select of MTD_CFI_BE_BYTE_SWAP

[Arnd Bergmann]

On Thu, Jul 23, 2026, at 00:06, Julian Braha wrote:
> 'select' does not work on config options in a 'choice', so currently it is
> possible to enable MTD_PHYSMAP_IXP4XX without MTD_CFI_BE_BYTE_SWAP.
>
> From a previous conversation, it was decided to remove the select 
> entirely:
> https://lore.kernel.org/all/c6268184-4904-49d9-b14f-0e11dce8bdad@app.fastmail.com/
>
> This dead select was found by kconfirm, a static analysis tool for Kconfig.
>
> Signed-off-by: Julian Braha <julianbraha@gmail.com>
> ---

Acked-by: Arnd Bergmann <arnd@arndb.de>

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

Re: [PATCH v2] mtd: maps: remove dead select of MTD_CFI_BE_BYTE_SWAP

[Andy Shevchenko]

On Wed, Jul 22, 2026 at 11:06:18PM +0100, Julian Braha wrote:
> 'select' does not work on config options in a 'choice', so currently it is
> possible to enable MTD_PHYSMAP_IXP4XX without MTD_CFI_BE_BYTE_SWAP.
> 
> From a previous conversation, it was decided to remove the select entirely:
> https://lore.kernel.org/all/c6268184-4904-49d9-b14f-0e11dce8bdad@app.fastmail.com/

You can make this a proper Link tag.

"From a previous conversation [1], it was decided to remove the select entirely.
 ...
 Link: $URL [1]"


> This dead select was found by kconfirm, a static analysis tool for Kconfig.

-- 
With Best Regards,
Andy Shevchenko



______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

Re: [PATCH v2] mtd: maps: remove dead select of MTD_CFI_BE_BYTE_SWAP

[Miquel Raynal]

On Wed, 22 Jul 2026 23:06:18 +0100, Julian Braha wrote:
> 'select' does not work on config options in a 'choice', so currently it is
> possible to enable MTD_PHYSMAP_IXP4XX without MTD_CFI_BE_BYTE_SWAP.
> 
> >From a previous conversation, it was decided to remove the select entirely:
> https://lore.kernel.org/all/c6268184-4904-49d9-b14f-0e11dce8bdad@app.fastmail.com/
> 
> This dead select was found by kconfirm, a static analysis tool for Kconfig.
> 
> [...]

Applied to mtd/next, thanks!

[1/1] mtd: maps: remove dead select of MTD_CFI_BE_BYTE_SWAP
      commit: 94d32f1ace8ee3ef3537ac6c8e71b76a418a4762

Patche(s) should be available on mtd/linux.git and will be
part of the next PR (provided that no robot complains by then).

Kind regards,
Miquèl


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/