Linux-mtd Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ubifs: Use the errors_* attribute names in the sysfs ABI document
@ 2026-09-05 10:22 Karl Mehltretter
  2026-09-05 20:05 ` AW: " Richard Weinberger
  0 siblings, 1 reply; 2+ messages in thread
From: Karl Mehltretter @ 2026-09-05 10:22 UTC (permalink / raw)
  To: Richard Weinberger
  Cc: Karl Mehltretter, Zhihao Cheng, linux-mtd, Stefan Schaeckeler

fs/ubifs/sysfs.c creates errors_magic, errors_node and errors_crc
(UBIFS_ATTR_FUNC(errors_magic, 0444) and friends). The ABI file documents
them as error_magic, error_node and error_crc, which do not exist.

Use the errors_* names.

Fixes: 58225631cf9a ("ubifs: Document sysfs nodes")
Assisted-by: LLM
Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
---
 Documentation/ABI/testing/sysfs-fs-ubifs | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/ABI/testing/sysfs-fs-ubifs b/Documentation/ABI/testing/sysfs-fs-ubifs
index af5afda30220..3c69ed5eb35c 100644
--- a/Documentation/ABI/testing/sysfs-fs-ubifs
+++ b/Documentation/ABI/testing/sysfs-fs-ubifs
@@ -1,4 +1,4 @@
-What:		/sys/fs/ubifsX_Y/error_magic
+What:		/sys/fs/ubifsX_Y/errors_magic
 Date:		October 2021
 KernelVersion:	5.16
 Contact:	linux-mtd@lists.infradead.org
@@ -10,7 +10,7 @@ Description:
 
 		The counter is reset to 0 with a remount.
 
-What:		/sys/fs/ubifsX_Y/error_node
+What:		/sys/fs/ubifsX_Y/errors_node
 Date:		October 2021
 KernelVersion:	5.16
 Contact:	linux-mtd@lists.infradead.org
@@ -22,7 +22,7 @@ Description:
 
 		The counter is reset to 0 with a remount.
 
-What:		/sys/fs/ubifsX_Y/error_crc
+What:		/sys/fs/ubifsX_Y/errors_crc
 Date:		October 2021
 KernelVersion:	5.16
 Contact:	linux-mtd@lists.infradead.org
-- 
2.53.0


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* AW: [PATCH] ubifs: Use the errors_* attribute names in the sysfs ABI document
  2026-09-05 10:22 [PATCH] ubifs: Use the errors_* attribute names in the sysfs ABI document Karl Mehltretter
@ 2026-09-05 20:05 ` Richard Weinberger
  0 siblings, 0 replies; 2+ messages in thread
From: Richard Weinberger @ 2026-09-05 20:05 UTC (permalink / raw)
  To: Karl Mehltretter
  Cc: Karl Mehltretter, Zhihao Cheng, linux-mtd, Stefan Schaeckeler

Am Sat, Sep 5, 2026, 12:22 schrieb Karl Mehltretter <kmehltretter@gmail.com>:
> fs/ubifs/sysfs.c creates errors_magic, errors_node and errors_crc
> (UBIFS_ATTR_FUNC(errors_magic, 0444) and friends). The ABI file documents
> them as error_magic, error_node and error_crc, which do not exist.
> 
> Use the errors_* names.
> 
> Fixes: 58225631cf9a ("ubifs: Document sysfs nodes")
> Assisted-by: LLM

The documented format for this tag is: "AGENT_NAME:MODEL_VERSION [TOOL1] [TOOL2]"

Why are you just stating "LLM" here?

> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>

Reviewed-by: Richard Weinberger <richard@nod.at>

Thanks,
//richard

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-09-05 20:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-05 10:22 [PATCH] ubifs: Use the errors_* attribute names in the sysfs ABI document Karl Mehltretter
2026-09-05 20:05 ` AW: " Richard Weinberger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox