* [PATCH] UBIFS: remove unnecessary assignment
@ 2017-04-17 2:22 Stefan Agner
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Agner @ 2017-04-17 2:22 UTC (permalink / raw)
To: richard, dedekind1, adrian.hunter; +Cc: linux-mtd, Stefan Agner
Assigning a value of a variable to itself is not useful.
Signed-off-by: Stefan Agner <stefan@agner.ch>
---
fs/ubifs/recovery.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/ubifs/recovery.c b/fs/ubifs/recovery.c
index 586d59347fff..3af4472061cc 100644
--- a/fs/ubifs/recovery.c
+++ b/fs/ubifs/recovery.c
@@ -442,7 +442,6 @@ static void clean_buf(const struct ubifs_info *c, void **buf, int lnum,
{
int empty_offs, pad_len;
- lnum = lnum;
dbg_rcvry("cleaning corruption at %d:%d", lnum, *offs);
ubifs_assert(!(*offs & 7));
--
2.12.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] UBIFS: remove unnecessary assignment
@ 2018-02-11 22:17 Stefan Agner
2018-03-01 16:34 ` Richard Weinberger
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Agner @ 2018-02-11 22:17 UTC (permalink / raw)
To: richard, dedekind1, adrian.hunter; +Cc: linux-mtd, Stefan Agner
Assigning a value of a variable to itself is not useful. This
fixes a warning shown when using clang:
warning: explicitly assigning value of variable of type 'int' to itself [-Wself-assign]
Signed-off-by: Stefan Agner <stefan@agner.ch>
---
fs/ubifs/scan.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/ubifs/scan.c b/fs/ubifs/scan.c
index aab87340d3de..16f03d9929e5 100644
--- a/fs/ubifs/scan.c
+++ b/fs/ubifs/scan.c
@@ -175,7 +175,6 @@ struct ubifs_scan_leb *ubifs_start_scan(const struct ubifs_info *c, int lnum,
void ubifs_end_scan(const struct ubifs_info *c, struct ubifs_scan_leb *sleb,
int lnum, int offs)
{
- lnum = lnum;
dbg_scan("stop scanning LEB %d at offset %d", lnum, offs);
ubifs_assert(offs % c->min_io_size == 0);
--
2.16.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] UBIFS: remove unnecessary assignment
2018-02-11 22:17 [PATCH] UBIFS: remove unnecessary assignment Stefan Agner
@ 2018-03-01 16:34 ` Richard Weinberger
0 siblings, 0 replies; 3+ messages in thread
From: Richard Weinberger @ 2018-03-01 16:34 UTC (permalink / raw)
To: Stefan Agner; +Cc: dedekind1, adrian.hunter, linux-mtd
Am Sonntag, 11. Februar 2018, 23:17:36 CET schrieb Stefan Agner:
> Assigning a value of a variable to itself is not useful. This
> fixes a warning shown when using clang:
> warning: explicitly assigning value of variable of type 'int' to itself
> [-Wself-assign]
Queued for next!
Thanks,
//richard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-01 16:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-11 22:17 [PATCH] UBIFS: remove unnecessary assignment Stefan Agner
2018-03-01 16:34 ` Richard Weinberger
-- strict thread matches above, loose matches on Subject: below --
2017-04-17 2:22 Stefan Agner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox