From: Michael Walle <mwalle@kernel.org>
To: Tudor Ambarus <tudor.ambarus@linaro.org>
Cc: Jaime Liao <jaimeliao.tw@gmail.com>,
linux-mtd@lists.infradead.org, pratyush@kernel.org,
miquel.raynal@bootlin.com, leoyu@mxic.com.tw,
jaimeliao@mxic.com.tw
Subject: Re: [PATCH v7 2/7] spi: spi-mem: Allow specifying the byte order in DTR mode
Date: Fri, 12 Jan 2024 09:31:26 +0100 [thread overview]
Message-ID: <2793744f3567a818ace9a686a735e426@kernel.org> (raw)
In-Reply-To: <abd91bff-2e28-46bc-9269-e5c294bbab68@linaro.org>
>>> * @data.ecc: whether error correction is required or not
>>> * @data.dir: direction of the transfer
>>> * @data.nbytes: number of data bytes to send/receive. Can be zero
>>> if
>>> the
>>> @@ -123,6 +125,7 @@ struct spi_mem_op {
>>> struct {
>>> u8 buswidth;
>>> u8 dtr : 1;
>>> + u8 dtr_swab16 : 1;
>>> u8 ecc : 1;
>>> u8 __pad : 6;
>>
>> __pad : 5;
>>
>> Does anyone know if this is really necessary?
>>
>
> it's to mitigate a gcc-{12, 13} bug, see
> 71c8f9cf2623d0db79665f876b95afcdd8214aec
>
> No idea if the bug was fixed in the meantime.
Ahh right, me of all, should've remembered that ;)
-michael
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2024-01-12 8:31 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 9:06 [PATCH v7 0/7] Add octal DTR support for Macronix flash Jaime Liao
2023-12-21 9:06 ` [PATCH v7 1/7] mtd: spi-nor: add Octal " Jaime Liao
2024-01-05 13:12 ` Michael Walle
2024-01-12 8:10 ` Tudor Ambarus
2023-12-21 9:06 ` [PATCH v7 2/7] spi: spi-mem: Allow specifying the byte order in DTR mode Jaime Liao
2024-01-05 12:48 ` Michael Walle
2024-01-12 8:29 ` Tudor Ambarus
2024-01-12 8:31 ` Michael Walle [this message]
2024-01-05 13:02 ` Michael Walle
2024-01-12 5:44 ` liao jaime
2024-01-12 8:15 ` Tudor Ambarus
2023-12-21 9:06 ` [PATCH v7 3/7] mtd: spi-nor: core: " Jaime Liao
2024-01-05 12:59 ` Michael Walle
2024-01-12 5:17 ` liao jaime
2024-01-12 8:31 ` Tudor Ambarus
2023-12-21 9:06 ` [PATCH v7 4/7] mtd: spi-nor: sfdp: Get the 8D-8D-8D byte order from BFPT Jaime Liao
2024-01-05 13:02 ` Michael Walle
2023-12-21 9:07 ` [PATCH v7 5/7] spi: mxic: Add support for swapping byte Jaime Liao
2024-01-05 12:37 ` Michael Walle
2024-01-12 5:14 ` liao jaime
2023-12-21 9:07 ` [PATCH v7 6/7] mtd: spi-nor: add support for Macronix Octal flash with RWW feature Jaime Liao
2024-01-05 13:07 ` Michael Walle
2024-01-12 8:42 ` Tudor Ambarus
2023-12-21 9:07 ` [PATCH v7 7/7] mtd: spi-nor: add support for Macronix Octal flash Jaime Liao
2024-01-05 13:11 ` Michael Walle
2024-01-12 5:47 ` liao jaime
2024-01-12 8:44 ` Tudor Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2793744f3567a818ace9a686a735e426@kernel.org \
--to=mwalle@kernel.org \
--cc=jaimeliao.tw@gmail.com \
--cc=jaimeliao@mxic.com.tw \
--cc=leoyu@mxic.com.tw \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=pratyush@kernel.org \
--cc=tudor.ambarus@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox