* [PATCH RESEND 0/2] mtd: spi-nor: spansion: fix die erase support
@ 2026-05-22 8:48 Takahiro Kuwano
2026-05-22 8:48 ` [PATCH RESEND 1/2] mtd: spi-nor: spansion: use die erase for multi-die devices only Takahiro Kuwano
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: Takahiro Kuwano @ 2026-05-22 8:48 UTC (permalink / raw)
To: Tudor Ambarus, Pratyush Yadav, Michael Walle, Miquel Raynal,
Richard Weinberger, Vignesh Raghavendra
Cc: linux-mtd, linux-kernel, Takahiro Kuwano, stable
Signed-off-by: Takahiro Kuwano <takahiro.kuwano@infineon.com>
---
Takahiro Kuwano (2):
mtd: spi-nor: spansion: use die erase for multi-die devices only
mtd: spi-nor: spansion: add die erase support in s28hx-t
drivers/mtd/spi-nor/spansion.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
---
base-commit: a33dad83043ebcf18d0556ccc105b1620010f93d
change-id: 20260417-die-erase-fix-49a237ba9df4
Best regards,
--
Takahiro Kuwano <takahiro.kuwano@infineon.com>
--
Takahiro Kuwano <takahiro.kuwano@infineon.com>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH RESEND 1/2] mtd: spi-nor: spansion: use die erase for multi-die devices only
2026-05-22 8:48 [PATCH RESEND 0/2] mtd: spi-nor: spansion: fix die erase support Takahiro Kuwano
@ 2026-05-22 8:48 ` Takahiro Kuwano
2026-05-22 9:08 ` Tudor Ambarus
2026-05-26 10:42 ` Pratyush Yadav
2026-05-22 8:48 ` [PATCH RESEND 2/2] mtd: spi-nor: spansion: add die erase support in s28hx-t Takahiro Kuwano
` (2 subsequent siblings)
3 siblings, 2 replies; 9+ messages in thread
From: Takahiro Kuwano @ 2026-05-22 8:48 UTC (permalink / raw)
To: Tudor Ambarus, Pratyush Yadav, Michael Walle, Miquel Raynal,
Richard Weinberger, Vignesh Raghavendra
Cc: linux-mtd, linux-kernel, Takahiro Kuwano, stable
Die erase opcode is supported in multi-die devices only. For single die
devices, default chip erase opcode must be used.
In s25hx_t_late_init(), die erase opcode is set only when the device is
multi-die.
Fixes: 461d0babb544 ("mtd: spi-nor: spansion: enable die erase for multi die flashes")
Cc: stable@kernel.org
Signed-off-by: Takahiro Kuwano <takahiro.kuwano@infineon.com>
---
drivers/mtd/spi-nor/spansion.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/mtd/spi-nor/spansion.c b/drivers/mtd/spi-nor/spansion.c
index 8498c7003d88..b6023076903a 100644
--- a/drivers/mtd/spi-nor/spansion.c
+++ b/drivers/mtd/spi-nor/spansion.c
@@ -674,7 +674,9 @@ static int s25hx_t_late_init(struct spi_nor *nor)
params->ready = cypress_nor_sr_ready_and_clear;
cypress_nor_ecc_init(nor);
- params->die_erase_opcode = SPINOR_OP_CYPRESS_DIE_ERASE;
+ if (params->n_dice > 1)
+ params->die_erase_opcode = SPINOR_OP_CYPRESS_DIE_ERASE;
+
return 0;
}
--
2.43.0
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH RESEND 2/2] mtd: spi-nor: spansion: add die erase support in s28hx-t
2026-05-22 8:48 [PATCH RESEND 0/2] mtd: spi-nor: spansion: fix die erase support Takahiro Kuwano
2026-05-22 8:48 ` [PATCH RESEND 1/2] mtd: spi-nor: spansion: use die erase for multi-die devices only Takahiro Kuwano
@ 2026-05-22 8:48 ` Takahiro Kuwano
2026-05-22 9:09 ` Tudor Ambarus
2026-05-26 10:44 ` Pratyush Yadav
2026-05-22 9:02 ` [PATCH RESEND 0/2] mtd: spi-nor: spansion: fix die erase support Miquel Raynal
2026-05-26 10:57 ` Pratyush Yadav
3 siblings, 2 replies; 9+ messages in thread
From: Takahiro Kuwano @ 2026-05-22 8:48 UTC (permalink / raw)
To: Tudor Ambarus, Pratyush Yadav, Michael Walle, Miquel Raynal,
Richard Weinberger, Vignesh Raghavendra
Cc: linux-mtd, linux-kernel, Takahiro Kuwano
S28Hx-T family has multi-die devices that support die erase opcode.
Update die erase opcode when the device is multi-die.
Signed-off-by: Takahiro Kuwano <takahiro.kuwano@infineon.com>
---
drivers/mtd/spi-nor/spansion.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/mtd/spi-nor/spansion.c b/drivers/mtd/spi-nor/spansion.c
index b6023076903a..65227d989de1 100644
--- a/drivers/mtd/spi-nor/spansion.c
+++ b/drivers/mtd/spi-nor/spansion.c
@@ -762,6 +762,9 @@ static int s28hx_t_late_init(struct spi_nor *nor)
params->ready = cypress_nor_sr_ready_and_clear;
cypress_nor_ecc_init(nor);
+ if (params->n_dice > 1)
+ params->die_erase_opcode = SPINOR_OP_CYPRESS_DIE_ERASE;
+
return 0;
}
--
2.43.0
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH RESEND 0/2] mtd: spi-nor: spansion: fix die erase support
2026-05-22 8:48 [PATCH RESEND 0/2] mtd: spi-nor: spansion: fix die erase support Takahiro Kuwano
2026-05-22 8:48 ` [PATCH RESEND 1/2] mtd: spi-nor: spansion: use die erase for multi-die devices only Takahiro Kuwano
2026-05-22 8:48 ` [PATCH RESEND 2/2] mtd: spi-nor: spansion: add die erase support in s28hx-t Takahiro Kuwano
@ 2026-05-22 9:02 ` Miquel Raynal
2026-05-26 10:57 ` Pratyush Yadav
3 siblings, 0 replies; 9+ messages in thread
From: Miquel Raynal @ 2026-05-22 9:02 UTC (permalink / raw)
To: Takahiro Kuwano
Cc: Tudor Ambarus, Pratyush Yadav, Michael Walle, Richard Weinberger,
Vignesh Raghavendra, linux-mtd, linux-kernel, Takahiro Kuwano,
stable
Hello,
On 22/05/2026 at 17:48:09 +09, Takahiro Kuwano <tkuw584924@gmail.com> wrote:
> Signed-off-by: Takahiro Kuwano <takahiro.kuwano@infineon.com>
> ---
> Takahiro Kuwano (2):
> mtd: spi-nor: spansion: use die erase for multi-die devices only
> mtd: spi-nor: spansion: add die erase support in s28hx-t
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH RESEND 1/2] mtd: spi-nor: spansion: use die erase for multi-die devices only
2026-05-22 8:48 ` [PATCH RESEND 1/2] mtd: spi-nor: spansion: use die erase for multi-die devices only Takahiro Kuwano
@ 2026-05-22 9:08 ` Tudor Ambarus
2026-05-26 10:42 ` Pratyush Yadav
1 sibling, 0 replies; 9+ messages in thread
From: Tudor Ambarus @ 2026-05-22 9:08 UTC (permalink / raw)
To: Takahiro Kuwano, Pratyush Yadav, Michael Walle, Miquel Raynal,
Richard Weinberger, Vignesh Raghavendra
Cc: linux-mtd, linux-kernel, Takahiro Kuwano, stable
Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH RESEND 2/2] mtd: spi-nor: spansion: add die erase support in s28hx-t
2026-05-22 8:48 ` [PATCH RESEND 2/2] mtd: spi-nor: spansion: add die erase support in s28hx-t Takahiro Kuwano
@ 2026-05-22 9:09 ` Tudor Ambarus
2026-05-26 10:44 ` Pratyush Yadav
1 sibling, 0 replies; 9+ messages in thread
From: Tudor Ambarus @ 2026-05-22 9:09 UTC (permalink / raw)
To: Takahiro Kuwano, Pratyush Yadav, Michael Walle, Miquel Raynal,
Richard Weinberger, Vignesh Raghavendra
Cc: linux-mtd, linux-kernel, Takahiro Kuwano
Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH RESEND 1/2] mtd: spi-nor: spansion: use die erase for multi-die devices only
2026-05-22 8:48 ` [PATCH RESEND 1/2] mtd: spi-nor: spansion: use die erase for multi-die devices only Takahiro Kuwano
2026-05-22 9:08 ` Tudor Ambarus
@ 2026-05-26 10:42 ` Pratyush Yadav
1 sibling, 0 replies; 9+ messages in thread
From: Pratyush Yadav @ 2026-05-26 10:42 UTC (permalink / raw)
To: Takahiro Kuwano
Cc: Tudor Ambarus, Pratyush Yadav, Michael Walle, Miquel Raynal,
Richard Weinberger, Vignesh Raghavendra, linux-mtd, linux-kernel,
Takahiro Kuwano, stable
On Fri, May 22 2026, Takahiro Kuwano wrote:
> Die erase opcode is supported in multi-die devices only. For single die
> devices, default chip erase opcode must be used.
>
> In s25hx_t_late_init(), die erase opcode is set only when the device is
> multi-die.
>
> Fixes: 461d0babb544 ("mtd: spi-nor: spansion: enable die erase for multi die flashes")
> Cc: stable@kernel.org
> Signed-off-by: Takahiro Kuwano <takahiro.kuwano@infineon.com>
Reviewed-by: Pratyush Yadav <pratyush@kernel.org>
--
Regards,
Pratyush Yadav
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH RESEND 2/2] mtd: spi-nor: spansion: add die erase support in s28hx-t
2026-05-22 8:48 ` [PATCH RESEND 2/2] mtd: spi-nor: spansion: add die erase support in s28hx-t Takahiro Kuwano
2026-05-22 9:09 ` Tudor Ambarus
@ 2026-05-26 10:44 ` Pratyush Yadav
1 sibling, 0 replies; 9+ messages in thread
From: Pratyush Yadav @ 2026-05-26 10:44 UTC (permalink / raw)
To: Takahiro Kuwano
Cc: Tudor Ambarus, Pratyush Yadav, Michael Walle, Miquel Raynal,
Richard Weinberger, Vignesh Raghavendra, linux-mtd, linux-kernel,
Takahiro Kuwano
On Fri, May 22 2026, Takahiro Kuwano wrote:
> S28Hx-T family has multi-die devices that support die erase opcode.
> Update die erase opcode when the device is multi-die.
>
> Signed-off-by: Takahiro Kuwano <takahiro.kuwano@infineon.com>
Reviewed-by: Pratyush Yadav <pratyush@kernel.org>
--
Regards,
Pratyush Yadav
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH RESEND 0/2] mtd: spi-nor: spansion: fix die erase support
2026-05-22 8:48 [PATCH RESEND 0/2] mtd: spi-nor: spansion: fix die erase support Takahiro Kuwano
` (2 preceding siblings ...)
2026-05-22 9:02 ` [PATCH RESEND 0/2] mtd: spi-nor: spansion: fix die erase support Miquel Raynal
@ 2026-05-26 10:57 ` Pratyush Yadav
3 siblings, 0 replies; 9+ messages in thread
From: Pratyush Yadav @ 2026-05-26 10:57 UTC (permalink / raw)
To: Takahiro Kuwano
Cc: Tudor Ambarus, Pratyush Yadav, Michael Walle, Miquel Raynal,
Richard Weinberger, Vignesh Raghavendra, linux-mtd, linux-kernel,
Takahiro Kuwano, stable
Hi Takahiro,
This series is good to go except I can't apply it because the From
header says "Takahiro Kuwano <tkuw584924@gmail.com>" and the signoff is
from "Takahiro Kuwano <takahiro.kuwano@infineon.com>". Please fixup the
commit author email or the signoff email and resend.
On Fri, May 22 2026, Takahiro Kuwano wrote:
> Signed-off-by: Takahiro Kuwano <takahiro.kuwano@infineon.com>
> ---
> Takahiro Kuwano (2):
> mtd: spi-nor: spansion: use die erase for multi-die devices only
> mtd: spi-nor: spansion: add die erase support in s28hx-t
>
> drivers/mtd/spi-nor/spansion.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
> ---
> base-commit: a33dad83043ebcf18d0556ccc105b1620010f93d
> change-id: 20260417-die-erase-fix-49a237ba9df4
>
> Best regards,
> --
> Takahiro Kuwano <takahiro.kuwano@infineon.com>
--
Regards,
Pratyush Yadav
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2026-05-26 10:58 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-22 8:48 [PATCH RESEND 0/2] mtd: spi-nor: spansion: fix die erase support Takahiro Kuwano
2026-05-22 8:48 ` [PATCH RESEND 1/2] mtd: spi-nor: spansion: use die erase for multi-die devices only Takahiro Kuwano
2026-05-22 9:08 ` Tudor Ambarus
2026-05-26 10:42 ` Pratyush Yadav
2026-05-22 8:48 ` [PATCH RESEND 2/2] mtd: spi-nor: spansion: add die erase support in s28hx-t Takahiro Kuwano
2026-05-22 9:09 ` Tudor Ambarus
2026-05-26 10:44 ` Pratyush Yadav
2026-05-22 9:02 ` [PATCH RESEND 0/2] mtd: spi-nor: spansion: fix die erase support Miquel Raynal
2026-05-26 10:57 ` Pratyush Yadav
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox