From: Vignesh Raghavendra <vigneshr@ti.com>
To: Sagar Shrikant Kadam <sagar.kadam@sifive.com>,
<marek.vasut@gmail.com>, <tudor.ambarus@microchip.com>,
<dwmw2@infradead.org>, <computersforpeace@gmail.com>,
<miquel.raynal@bootlin.com>, <richard@nod.at>,
<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
<linux-riscv@lists.infradead.org>
Cc: wesley@sifive.com, palmer@sifive.com, aou@eecs.berkeley.edu,
paul.walmsley@sifive.com
Subject: Re: [PATCH v5 1/3] mtd: spi-nor: add support for is25wp256
Date: Sun, 16 Jun 2019 18:14:16 +0530 [thread overview]
Message-ID: <325855d0-00f9-df8a-ea57-c140d39dd6ef@ti.com> (raw)
In-Reply-To: <1560336476-31763-2-git-send-email-sagar.kadam@sifive.com>
Hi,
On 12-Jun-19 4:17 PM, Sagar Shrikant Kadam wrote:
[...]
> @@ -4129,7 +4137,7 @@ int spi_nor_scan(struct spi_nor *nor, const char *name,
> if (ret)
> return ret;
>
> - if (nor->addr_width) {
> + if (nor->addr_width && JEDEC_MFR(info) != SNOR_MFR_ISSI) {
> /* already configured from SFDP */
Hmm, why would you want to ignore addr_width that's read from SFDP table?
Regards
Vignesh
> } else if (info->addr_width) {
> nor->addr_width = info->addr_width;
> diff --git a/include/linux/mtd/spi-nor.h b/include/linux/mtd/spi-nor.h
> index b3d360b..ff13297 100644
> --- a/include/linux/mtd/spi-nor.h
> +++ b/include/linux/mtd/spi-nor.h
> @@ -19,6 +19,7 @@
> #define SNOR_MFR_ATMEL CFI_MFR_ATMEL
> #define SNOR_MFR_GIGADEVICE 0xc8
> #define SNOR_MFR_INTEL CFI_MFR_INTEL
> +#define SNOR_MFR_ISSI 0x9d /* ISSI */
> #define SNOR_MFR_ST CFI_MFR_ST /* ST Micro */
> #define SNOR_MFR_MICRON CFI_MFR_MICRON /* Micron */
> #define SNOR_MFR_MACRONIX CFI_MFR_MACRONIX
>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-06-16 12:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 10:47 [PATCH v5 0/3] mtd: spi-nor: add support for is25wp256 spi-nor flash Sagar Shrikant Kadam
2019-06-12 10:47 ` [PATCH v5 1/3] mtd: spi-nor: add support for is25wp256 Sagar Shrikant Kadam
2019-06-16 12:44 ` Vignesh Raghavendra [this message]
2019-06-17 15:18 ` Sagar Kadam
2019-06-21 6:04 ` Vignesh Raghavendra
2019-06-21 10:28 ` Sagar Kadam
2019-06-24 9:34 ` Vignesh Raghavendra
2019-06-24 12:40 ` Sagar Kadam
2019-06-24 13:08 ` Vignesh Raghavendra
2019-06-24 15:22 ` Sagar Kadam
2019-06-12 10:47 ` [PATCH v5 2/3] mtd: spi-nor: add support to unlock flash device Sagar Shrikant Kadam
2019-06-16 13:05 ` Vignesh Raghavendra
2019-06-17 15:40 ` Sagar Kadam
2019-06-18 0:25 ` Joe Perches
2019-06-18 3:55 ` Sagar Kadam
2019-06-12 10:47 ` [PATCH v5 3/3] mtd: spi-nor: add locking support for is25xxxxx device Sagar Shrikant Kadam
2019-06-18 4:24 ` Vignesh Raghavendra
2019-06-18 11:44 ` Sagar Kadam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=325855d0-00f9-df8a-ea57-c140d39dd6ef@ti.com \
--to=vigneshr@ti.com \
--cc=aou@eecs.berkeley.edu \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-riscv@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
--cc=richard@nod.at \
--cc=sagar.kadam@sifive.com \
--cc=tudor.ambarus@microchip.com \
--cc=wesley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox