From: Joe Perches <joe@perches.com>
To: Sagar Kadam <sagar.kadam@sifive.com>,
Vignesh Raghavendra <vigneshr@ti.com>
Cc: aou@eecs.berkeley.edu, tudor.ambarus@microchip.com,
Wesley Terpstra <wesley@sifive.com>,
richard@nod.at, Palmer Dabbelt <palmer@sifive.com>,
linux-kernel@vger.kernel.org, marek.vasut@gmail.com,
linux-mtd@lists.infradead.org,
Paul Walmsley <paul.walmsley@sifive.com>,
miquel.raynal@bootlin.com, linux-riscv@lists.infradead.org,
computersforpeace@gmail.com, dwmw2@infradead.org
Subject: Re: [PATCH v5 2/3] mtd: spi-nor: add support to unlock flash device
Date: Mon, 17 Jun 2019 17:25:16 -0700 [thread overview]
Message-ID: <547e251d87e307fa4d1e31dfc61b496c152f0905.camel@perches.com> (raw)
In-Reply-To: <CAARK3HmFg=v+cMGAykPPpwxDGaSKk5k+Gz4fSHQPQmg-rCjPhQ@mail.gmail.com>
On Mon, 2019-06-17 at 21:10 +0530, Sagar Kadam wrote:
> On Sun, Jun 16, 2019 at 6:35 PM Vignesh Raghavendra <vigneshr@ti.com> wrote:
[]
> > > +static int issi_unlock(struct spi_nor *nor, loff_t ofs, uint64_t len)
> > > +{
[]
> > > + if (ret > 0 && !(ret & mask)) {
> > > + dev_info(nor->dev,
> > > + "ISSI Block Protection Bits cleared SR=0x%x", ret);
Please use '\n' terminations on formats
> > > + ret = 0;
> > > + } else {
> > > + dev_err(nor->dev, "ISSI Block Protection Bits not cleared\n");
like this one
> > > + ret = -EINVAL;
> > > + }
> > > + return ret;
> > > +}
> > > +
> > > +/**
> > > * spansion_quad_enable() - set QE bit in Configuraiton Register.
s/Configuraiton/Configuration/
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-06-18 0:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 10:47 [PATCH v5 0/3] mtd: spi-nor: add support for is25wp256 spi-nor flash Sagar Shrikant Kadam
2019-06-12 10:47 ` [PATCH v5 1/3] mtd: spi-nor: add support for is25wp256 Sagar Shrikant Kadam
2019-06-16 12:44 ` Vignesh Raghavendra
2019-06-17 15:18 ` Sagar Kadam
2019-06-21 6:04 ` Vignesh Raghavendra
2019-06-21 10:28 ` Sagar Kadam
2019-06-24 9:34 ` Vignesh Raghavendra
2019-06-24 12:40 ` Sagar Kadam
2019-06-24 13:08 ` Vignesh Raghavendra
2019-06-24 15:22 ` Sagar Kadam
2019-06-12 10:47 ` [PATCH v5 2/3] mtd: spi-nor: add support to unlock flash device Sagar Shrikant Kadam
2019-06-16 13:05 ` Vignesh Raghavendra
2019-06-17 15:40 ` Sagar Kadam
2019-06-18 0:25 ` Joe Perches [this message]
2019-06-18 3:55 ` Sagar Kadam
2019-06-12 10:47 ` [PATCH v5 3/3] mtd: spi-nor: add locking support for is25xxxxx device Sagar Shrikant Kadam
2019-06-18 4:24 ` Vignesh Raghavendra
2019-06-18 11:44 ` Sagar Kadam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547e251d87e307fa4d1e31dfc61b496c152f0905.camel@perches.com \
--to=joe@perches.com \
--cc=aou@eecs.berkeley.edu \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-riscv@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
--cc=richard@nod.at \
--cc=sagar.kadam@sifive.com \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
--cc=wesley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox