public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: akorolev <alexey.korolev@intel.com>
To: Linux-MTD Mailing List <linux-mtd@lists.infradead.org>,
	David Woodhouse <dwmw2@infradead.org>
Subject: Why the alignemt to 4 bytes is necessary in jffs2_commit_write function
Date: Wed, 11 Jul 2007 20:25:22 +0400	[thread overview]
Message-ID: <46950472.7000103@intel.com> (raw)

Hi All

I'm currently working on JFFS2 improving. I faced some issues with 
understanding why we need to align start offset to 4 bytes in 
jffs2_commit_write function?
Here is the part of this code:
=========================

    unsigned aligned_start = start & ~3;
    .........................................
    /* Adjust writtenlen for the padding we did, so we don't confuse our 
caller */
    if (writtenlen < (start&3))
        writtenlen = 0;
    else
        writtenlen -= (start&3);

===========================
What does the padding mean here?
If I properly understand the aligned_start is not related to offset of 
the fragment it is just offset within the file.  (Frag offset is aligned)
File offset is not necessary to keep aligned - so why not to kick off 
it. (I tried and didn't find anything wrong in tests).

Thanks,
Alexey

             reply	other threads:[~2007-07-11 16:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-11 16:25 akorolev [this message]
2007-07-11 16:35 ` Why the alignemt to 4 bytes is necessary in jffs2_commit_write function David Woodhouse
2007-07-11 16:43   ` akorolev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46950472.7000103@intel.com \
    --to=alexey.korolev@intel.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox