public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Ian Molton <ian@mnementh.co.uk>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: dbaryshkov@gmail.com, linux-mtd@lists.infradead.org
Subject: Re: abuse of nand_correct_data in tmio_nand driver
Date: Tue, 28 Jul 2009 15:35:19 +0100	[thread overview]
Message-ID: <4A6F0CA7.70006@mnementh.co.uk> (raw)
In-Reply-To: <20090728.231156.126763891.anemo@mba.ocn.ne.jp>

Atsushi Nemoto wrote:
> On Tue, 28 Jul 2009 14:57:05 +0100, Ian molton <spyro@f2s.com> wrote:
>>>> The current nand_correct_data() can be used for ecc.bytes = 3 case
>>>> only.  The tmio_nand driver uses ecc.bytes = 6.
>>> IIRC, tmio_nand driver accesses two ecc "sectors" at once, so this is
>>> most probably ok. I'll look into it though, when I have some time.
>> Are we really the only chip that does this?
> 
> TXx9 NDFMC can read 6 byte ECC (for two 256 byte sectors) at a time.
> I will try to see if doing it increase performance or not.

Cool,

If theres more than one chip that can do this, I think the change should 
go in the core mmc code.

      reply	other threads:[~2009-07-28 14:35 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-14 14:05 abuse of nand_correct_data in tmio_nand driver Atsushi Nemoto
2009-07-19  0:11 ` Dmitry Eremin-Solenikov
2009-07-19 15:14   ` Atsushi Nemoto
2009-07-19 16:08     ` Dmitry Eremin-Solenikov
2009-07-20  5:15       ` vimal singh
2009-07-21 15:20         ` Atsushi Nemoto
2009-07-22  8:43           ` vimal singh
2009-07-22 15:13             ` Atsushi Nemoto
2009-07-23  7:04               ` vimal singh
2009-07-23 15:11                 ` Atsushi Nemoto
2009-07-24 17:24                   ` Dmitry Eremin-Solenikov
2009-07-26 13:03                   ` vimal singh
2009-07-28 13:57   ` Ian molton
2009-07-28 14:11     ` Atsushi Nemoto
2009-07-28 14:35       ` Ian Molton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A6F0CA7.70006@mnementh.co.uk \
    --to=ian@mnementh.co.uk \
    --cc=anemo@mba.ocn.ne.jp \
    --cc=dbaryshkov@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox