From: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: linux-mtd@lists.infradead.org
Subject: Re: abuse of nand_correct_data in tmio_nand driver
Date: Sun, 19 Jul 2009 20:08:59 +0400 [thread overview]
Message-ID: <bc64b4640907190908m209572e8od16ac648f19503e@mail.gmail.com> (raw)
In-Reply-To: <20090720.001426.102579925.anemo@mba.ocn.ne.jp>
2009/7/19, Atsushi Nemoto <anemo@mba.ocn.ne.jp>:
> On Sun, 19 Jul 2009 04:11:27 +0400, Dmitry Eremin-Solenikov
> <dbaryshkov@gmail.com> wrote:
>> > The current nand_correct_data() can be used for ecc.bytes = 3 case
>> > only. The tmio_nand driver uses ecc.bytes = 6.
>>
>> IIRC, tmio_nand driver accesses two ecc "sectors" at once, so this is
>> most probably ok. I'll look into it though, when I have some time.
>
> Yes, tmio_nand driver read 512 byte data and calculate 6 byte ecc at
> once, but nand_correct_data only references first 3 byte of ecc.
>
> I doubt the driver cannot detect errors in the second 256 byte sector
> of the 512 byte block.
Hmm. That's strange: nand_correct_data() seems to support 512-byte sectors,
however it assumes that ECC is still 3 bytes. I'll have to check specs to see
who is wrong...
--
With best wishes
Dmitry
next prev parent reply other threads:[~2009-07-19 16:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-14 14:05 abuse of nand_correct_data in tmio_nand driver Atsushi Nemoto
2009-07-19 0:11 ` Dmitry Eremin-Solenikov
2009-07-19 15:14 ` Atsushi Nemoto
2009-07-19 16:08 ` Dmitry Eremin-Solenikov [this message]
2009-07-20 5:15 ` vimal singh
2009-07-21 15:20 ` Atsushi Nemoto
2009-07-22 8:43 ` vimal singh
2009-07-22 15:13 ` Atsushi Nemoto
2009-07-23 7:04 ` vimal singh
2009-07-23 15:11 ` Atsushi Nemoto
2009-07-24 17:24 ` Dmitry Eremin-Solenikov
2009-07-26 13:03 ` vimal singh
2009-07-28 13:57 ` Ian molton
2009-07-28 14:11 ` Atsushi Nemoto
2009-07-28 14:35 ` Ian Molton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc64b4640907190908m209572e8od16ac648f19503e@mail.gmail.com \
--to=dbaryshkov@gmail.com \
--cc=anemo@mba.ocn.ne.jp \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox