* Re: question about write/read sub-page with BCH algorithm or disable sub-page operation when using ubifs
2012-07-31 7:23 question about write/read sub-page with BCH algorithm or disable sub-page operation when using ubifs 曹荣荣
@ 2012-07-31 7:37 ` Matthieu CASTET
2012-07-31 7:52 ` 曹荣荣
2012-08-01 5:20 ` Iwo Mergler
1 sibling, 1 reply; 4+ messages in thread
From: Matthieu CASTET @ 2012-07-31 7:37 UTC (permalink / raw)
To: 曹荣荣; +Cc: linux-mtd@lists.infradead.org
Hi,
> Hello,
> I have a question about sub-page when using ubifs, so ask help from here.
>
> Let me take a 2048-size page with 4 sub-page Nand as example.
>
> The documentation said, "To write a sub-page, the driver may actually
> write whole NAND page, but put 0xFF bytes to the sub-pages which are
> not relevant to this operation."
> It's OK for some ECC algorithms such as Hamming algorithm, because the
> ECC codes generated by Hamming algorithm for the 0xFF data are still
> 0xFF'ed. However, if we use BCH algorithm, the generated ECC codes for
> 0xFF data will be not 0xFF'ed, and they will overwrite the previous
> OOB data, so error will be happened when reading next time.
It depends of your ecc algorithm. The software BCH algo in kernel take care of
generate code such as 0xFF data give 0xFF ecc.
This can be done by XORing the ecc before writing/after reading.
This may not possible on some controller that compute and send ecc without
software intervention.
>
> I try to resolve this issue by disabling sub-page operation, so I add
> NAND_NO_SUBPAGE_WRITE into chip->options, but chip->options will be
> flushed in nand_get_flash_type() funtion (chip->options &=
> ~NAND_CHIPOPTIONS_MSK).
You may better define chip->ecc.steps == 1
Matthieu
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: question about write/read sub-page with BCH algorithm or disable sub-page operation when using ubifs
2012-07-31 7:23 question about write/read sub-page with BCH algorithm or disable sub-page operation when using ubifs 曹荣荣
2012-07-31 7:37 ` Matthieu CASTET
@ 2012-08-01 5:20 ` Iwo Mergler
1 sibling, 0 replies; 4+ messages in thread
From: Iwo Mergler @ 2012-08-01 5:20 UTC (permalink / raw)
To: 曹荣荣, linux-mtd@lists.infradead.org
On Tue, 31 Jul 2012 17:23:25 +1000
曹荣荣 <caorr1980@gmail.com> wrote:
> Hello,
> I have a question about sub-page when using ubifs, so ask help from
> here.
>
> Let me take a 2048-size page with 4 sub-page Nand as example.
>
> The documentation said, "To write a sub-page, the driver may actually
> write whole NAND page, but put 0xFF bytes to the sub-pages which are
> not relevant to this operation."
> It's OK for some ECC algorithms such as Hamming algorithm, because the
> ECC codes generated by Hamming algorithm for the 0xFF data are still
> 0xFF'ed. However, if we use BCH algorithm, the generated ECC codes for
> 0xFF data will be not 0xFF'ed, and they will overwrite the previous
> OOB data, so error will be happened when reading next time.
>
> I try to resolve this issue by disabling sub-page operation, so I add
> NAND_NO_SUBPAGE_WRITE into chip->options, but chip->options will be
> flushed in nand_get_flash_type() funtion (chip->options &=
> ~NAND_CHIPOPTIONS_MSK).
>
> So, my question is, How can I do to write/read sub-page with BCH
> algorithm, or to disable sub-page operation?
>
Without sub-page support, UBI overhead doubles from about 1.5% to
over 3%, so sub-page support is worth considering.
Disclaimer: Some of the below is from memory only - read the source,
especially nand_base.c. Some details will depend on kernel version.
I'll assume for the moment that you have a hardware ECC controller
with BCH support. There shouldn't be a problem with software BCH.
Most hardware ECC controllers ignore FLASH command and address cycles,
although some will reset the ECC calculation during READ PAGE (0x00)
and PROGRAM PAGE (0x80) commands.
This means that if you can reset the ECC controller in software,
you can support sub-page reads & writes. You may have to change
the OOB layout and break compatibility with your previous versions.
This will usually also affect the boot loader.
Writing a sub-page is a matter of making sure that all the areas
of the page (+OOB) you don't intend to write are filled with 0xFF
bytes. The OOB must contain separate ECC byte fields for each
sub-page.
I'm not sure, but I think sub-page capable NAND will default
the page buffer to 0xFF internally. So you can jump to the
sub-page offset (Random Data Input, 0x85), reset the ECC,
write the data while the ECC controller is listening, then
issue another Random Data Input command to jump to the
correct OOB offset and write out the ECC bytes.
For sub-page read, you make sure that the ECC is reset, read
the subpage from the right offset, jump to the ECC value in
OOB and process. Depending on your controller, at this point
you either read the ECC bytes and get a syndrome or you read
the ECC register and the OOB bytes (in that order) and compare.
You need to make sure that pages written as whole pages can be
read as sub-pages and vice-versa. So you have to provide
ecc.write_page and ecc.read_page functions as well, using the
same OOB layout.
This means saving & resetting ECC bytes at sub-page boundaries
and possibly jumping between sub-pages and corresponding ECC
bytes during syndrome reads.
Best regards,
Iwo
______________________________________________________________________
This communication contains information which may be confidential or privileged. The information is intended solely for the use of the individual or entity named above. If you are not the intended recipient, be aware that any disclosure, copying, distribution or use of the contents of this information is prohibited. If you have received this communication in error, please notify me by telephone immediately.
______________________________________________________________________
^ permalink raw reply [flat|nested] 4+ messages in thread