public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH] include/common.h: fix build against current uClibc
@ 2014-04-13 12:26 Baruch Siach
  2014-04-14 22:35 ` Mike Frysinger
  2014-04-15 12:56 ` Artem Bityutskiy
  0 siblings, 2 replies; 3+ messages in thread
From: Baruch Siach @ 2014-04-13 12:26 UTC (permalink / raw)
  To: linux-mtd; +Cc: Baruch Siach, Mike Frysinger

Commit dbe0fd17f2 (mtd-utils: new prompt() helper for talking to the user)
introduced a rpmatch() call. However, uClibc versions older than (not yet
released) 0.9.34 don't have rpmatch() implementation. Add one.

Cc: Mike Frysinger <vapier@gentoo.org>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 include/common.h | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/include/common.h b/include/common.h
index 4ffccea17213..3b1366e927c4 100644
--- a/include/common.h
+++ b/include/common.h
@@ -102,6 +102,19 @@ extern "C" {
 	fprintf(stderr, "%s: warning!: " fmt "\n", PROGRAM_NAME, ##__VA_ARGS__); \
 } while(0)
 
+#if defined(__UCLIBC__)
+/* uClibc versions before 0.9.34 don't have rpmatch() */
+#if __UCLIBC_MAJOR__ == 0 && \
+		(__UCLIBC_MINOR__ < 9 || \
+		(__UCLIBC_MINOR__ == 9 && __UCLIBC_SUBLEVEL__ < 34))
+static inline int rpmatch(const char *resp)
+{
+    return (resp[0] == 'y' || resp[0] == 'Y') ? 1 :
+	(resp[0] == 'n' || resp[0] == 'N') ? 0 : -1;
+}
+#endif
+#endif
+
 /**
  * prompt the user for confirmation
  */
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] include/common.h: fix build against current uClibc
  2014-04-13 12:26 [PATCH] include/common.h: fix build against current uClibc Baruch Siach
@ 2014-04-14 22:35 ` Mike Frysinger
  2014-04-15 12:56 ` Artem Bityutskiy
  1 sibling, 0 replies; 3+ messages in thread
From: Mike Frysinger @ 2014-04-14 22:35 UTC (permalink / raw)
  To: Baruch Siach; +Cc: linux-mtd

[-- Attachment #1: Type: text/plain, Size: 51 bytes --]

Acked-by: Mike Frysinger <vapier@gentoo.org>
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] include/common.h: fix build against current uClibc
  2014-04-13 12:26 [PATCH] include/common.h: fix build against current uClibc Baruch Siach
  2014-04-14 22:35 ` Mike Frysinger
@ 2014-04-15 12:56 ` Artem Bityutskiy
  1 sibling, 0 replies; 3+ messages in thread
From: Artem Bityutskiy @ 2014-04-15 12:56 UTC (permalink / raw)
  To: Baruch Siach; +Cc: Mike Frysinger, linux-mtd

On Sun, 2014-04-13 at 15:26 +0300, Baruch Siach wrote:
> Commit dbe0fd17f2 (mtd-utils: new prompt() helper for talking to the user)
> introduced a rpmatch() call. However, uClibc versions older than (not yet
> released) 0.9.34 don't have rpmatch() implementation. Add one.
> 
> Cc: Mike Frysinger <vapier@gentoo.org>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Pushed to mtd-utils.git, thanks!

-- 
Best Regards,
Artem Bityutskiy

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-04-15 12:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-13 12:26 [PATCH] include/common.h: fix build against current uClibc Baruch Siach
2014-04-14 22:35 ` Mike Frysinger
2014-04-15 12:56 ` Artem Bityutskiy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox