From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Boris Brezillon <boris.brezillon@free-electrons.com> (by way of
Boris Brezillon <boris.brezillon@free-electrons.com>)
Cc: "Richard Weinberger" <richard@nod.at>,
linux-mtd@lists.infradead.org,
"David Woodhouse" <dwmw2@infradead.org>,
"Brian Norris" <computersforpeace@gmail.com>,
"Marek Vasut" <marek.vasut@gmail.com>,
"Cyrille Pitchen" <cyrille.pitchen@wedev4u.fr>,
"Ezequiel Garcia" <ezequiel@vanguardiasur.com.ar>,
"Sean Nyekjær" <sean.nyekjaer@prevas.dk>,
"Greg Cook" <greg@morpheus.ws>,
"Miquel RAYNAL" <miquel.raynal@free-electrons.com>,
stable@kernel.vger.org
Subject: Re: [PATCH] mtd: nand: pxa3xx: Fix READOOB implementation
Date: Mon, 18 Dec 2017 18:37:08 +0100 [thread overview]
Message-ID: <873748djjv.fsf@belgarion.home> (raw)
In-Reply-To: <20171218103245.22516-1-boris.brezillon@free-electrons.com> (Boris Brezillon's message of "Mon, 18 Dec 2017 11:32:45 +0100")
Boris Brezillon <boris.brezillon@free-electrons.com> (by way of Boris Brezillon
<boris.brezillon@free-electrons.com>) writes:
> In the current driver, OOB bytes are accessed in raw mode, and when a
> page access is done with NDCR_SPARE_EN set and NDCR_ECC_EN cleared, the
> driver must read the whole spare area (64 bytes in case of a 2k page,
> 16 bytes for a 512 page). The driver was only reading the free OOB
> bytes, which was leaving some unread data in the FIFO and was somehow
> leading to a timeout.
That's a very good catch.
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
Cheers.
--
Robert
prev parent reply other threads:[~2017-12-18 17:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-18 10:32 [PATCH] mtd: nand: pxa3xx: Fix READOOB implementation Boris Brezillon
2017-12-18 12:33 ` Ezequiel Garcia
2017-12-18 12:45 ` Sean Nyekjær
2017-12-18 17:37 ` Robert Jarzmik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873748djjv.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=dwmw2@infradead.org \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=greg@morpheus.ws \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@free-electrons.com \
--cc=richard@nod.at \
--cc=sean.nyekjaer@prevas.dk \
--cc=stable@kernel.vger.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox