Linux-mtd Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: "Michael Walle" <mwalle@kernel.org>
Cc: "Santhosh Kumar K" <s-k6@ti.com>,  <broonie@kernel.org>,
	<robh@kernel.org>,  <krzk+dt@kernel.org>,  <conor+dt@kernel.org>,
	<richard@nod.at>,  <vigneshr@ti.com>,  <pratyush@kernel.org>,
	<takahiro.kuwano@infineon.com>,  <linux-spi@vger.kernel.org>,
	<devicetree@vger.kernel.org>,  <linux-kernel@vger.kernel.org>,
	<linux-mtd@lists.infradead.org>,  <praneeth@ti.com>,
	<sebin.francis@ti.com>,  <u-kumar1@ti.com>,
	<srikanth.boyapally@amd.com>,  <m-shah@ti.com>
Subject: Re: [PATCH v11 00/19] spi: cadence-quadspi: add PHY tuning support
Date: Fri, 20 Nov 2026 14:18:31 +0100	[thread overview]
Message-ID: <87cxrzbpzs.fsf@bootlin.com> (raw)
In-Reply-To: <DN01ZL81VTHB.3PB0JO4WI6WU0@kernel.org> (Michael Walle's message of "Fri, 20 Nov 2026 13:56:44 +0100")

On 20/11/2026 at 13:56:44 +01, "Michael Walle" <mwalle@kernel.org> wrote:

> On Thu Nov 5, 2026 at 11:58 AM CET, Santhosh Kumar K wrote:
>> This series implements PHY tuning support for the Cadence QSPI controller
>> to enable reliable high-speed operations. Without PHY tuning, controllers
>> use conservative timing that limits performance. PHY tuning calibrates
>> RX/TX delay lines to find optimal data capture timing windows, enabling
>> operation up to the controller's maximum frequency.
>>
>> Background:
>> High-speed SPI memory controllers require precise timing calibration for
>> reliable operation. At higher frequencies, board-to-board variations make
>> fixed timing parameters inadequate. The Cadence QSPI controller includes
>> a PHY interface with programmable delay lines (0-127 taps) for RX and TX
>> paths, but these require runtime calibration to find the valid timing
>> window.
>>
>> Approach:
>> Add SDR/DDR PHY tuning algorithms for the Cadence controller:
>>
>> SDR Mode Tuning (1D search):
>>  - Searches for two consecutive valid RX delay windows
>>  - Selects the larger window and uses its midpoint for maximum margin
>>  - TX delay fixed at maximum (127) as it's less critical in SDR
>>
>> DDR Mode Tuning (2D search):
>>  - Finds RX boundaries (rxlow/rxhigh) using TX window sweeps
>>  - Finds TX boundaries (txlow/txhigh) at fixed RX positions
>>  - Defines valid region corners and detects gaps via binary search
>>  - Applies temperature compensation for optimal point selection
>>  - Handles single or dual passing regions with different strategies
>>
>> Patch description:
>> Infrastructure (1-5):
>>  - Patch 1:   Add spi-max-post-config-frequency-hz to describe maximum
>>               frequency achievable post controller configuration
>>  - Patch 2:   Add spi-phy-pattern-partition phandle for
>>               NOR flash PHY tuning pattern location
>>  - Patch 3:   Parse spi-max-post-config-frequency-hz in spi.c; adds
>>               spi_device.post_config_max_speed_hz (0 when not set
>>               keeping all existing DT fully compatible)
>>  - Patch 4:   Extend spi_mem_adjust_op_freq() with a bypass: if
>>               op->max_freq equals post_config_max_speed_hz, return
>>               immediately leaving op->max_freq unchanged. All other
>>               ops are capped to max_speed_hz. Also require per_op_freq
>>               controller capability for post-config ops in
>>               spi_mem_default_supports_op()
>>  - Patch 5:   Add execute_tuning callback to spi_controller_mem_ops and
>>               spi_mem_execute_tuning() wrapper in SPI-MEM core;
>>               serialises access via spi_mem_access_start/end and
>>               rejects GPIO chip selects
>>
>> Cadence QSPI Implementation (6-14):
>>  - Patch 6:   Move cqspi_readdata_capture() earlier (preparatory)
>>  - Patch 7:   Add DQS bit to cqspi_readdata_capture() (preparatory)
>>  - Patch 8:   Add complete PHY tuning support: DLL management, pattern
>>               verification (NOR via spi-phy-pattern-partition phandle,
>>               NAND via write-to-cache), SDR 1D and DDR 2D search
>>               algorithms with temperature compensation, AM654-specific
>>               execute_tuning entry point
>>  - Patch 9:   Reject 2-byte-address DDR operations via a new
>>               CQSPI_NO_PHY_TUNING_WITH_ODDR_2B_ADDR quirk flag to work
>>               around AM654 OSPI erratum i2383
>>  - Patch 10:  Refactor direct read path for PHY support (preparatory)
>>  - Patch 11:  Enable PHY for direct reads at the calibrated frequency
>>               when both transfer boundaries are 16-byte aligned,
>>               falling back to non-PHY DMA otherwise; also reprograms
>>               DLL on chip-select switch when two devices have
>>               different calibrated settings
>>  - Patch 12:  Enable PHY for indirect writes of at least
>>               CQSPI_PHY_MIN_INDIRECT_WRITE_LEN bytes
>>  - Patch 13:  Reprogram per-device CS timing on any chip-select switch
>>  - Patch 14:  Reprogram the PHY DLL (master config and RX/TX taps) on
>>               runtime resume, since the DLL loses its lock when the
>>               OSPI controller is power-gated
>>
>> MTD core (15-19):
>>  - Patch 15:  Extract spinand_select_op_variant() into a shared helper
>>               spinand_op_find_best_variant() with a skip_mask
>>  - Patch 16:  Negotiate optimal controller operating point before dirmap
>>               creation; iterate all read variants in performance order
>>               across ODTR and SSDR interfaces; re-pair cont_read_cache after
>>               PHY tuning via protocol-shape matching
>>  - Patch 17:  Extract spi_nor_spimem_get_read_op() helper (preparatory)
>>  - Patch 18:  Execute controller optimization in spi_nor_probe() before
>>               creating dirmaps
>>  - Patch 19:  Reset max_read_op frequency for security register reads
>
> So what is the merging strategy here? Getting the first parts in and
> then getting the spinand and spi_nor in in the next cycle?

Agreed.

> FWIW, the spi-nor parts looks good.

Same for the SPI NAND bits.

Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

      reply	other threads:[~2026-11-20 13:18 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-05 10:58 [PATCH v11 00/19] spi: cadence-quadspi: add PHY tuning support Santhosh Kumar K
2026-11-05 10:58 ` [PATCH v11 01/19] spi: dt-bindings: add spi-max-post-config-frequency-hz property Santhosh Kumar K
2026-11-05 16:41   ` Krzysztof Kozlowski
2026-11-05 16:42     ` Krzysztof Kozlowski
2026-11-05 10:58 ` [PATCH v11 02/19] spi: dt-bindings: add spi-phy-pattern-partition property Santhosh Kumar K
2026-11-05 16:42   ` Krzysztof Kozlowski
2026-11-05 10:58 ` [PATCH v11 03/19] spi: parse spi-max-post-config-frequency-hz into post_config_max_speed_hz Santhosh Kumar K
2026-11-05 11:18   ` sashiko-bot
2026-11-05 10:58 ` [PATCH v11 04/19] spi: spi-mem: teach spi_mem_adjust_op_freq() about post-config ops Santhosh Kumar K
2026-11-05 11:24   ` sashiko-bot
2026-11-05 10:58 ` [PATCH v11 05/19] spi: spi-mem: add execute_tuning callback and spi_mem_execute_tuning() Santhosh Kumar K
2026-11-05 10:58 ` [PATCH v11 06/19] spi: cadence-quadspi: move cqspi_readdata_capture earlier Santhosh Kumar K
2026-11-05 10:58 ` [PATCH v11 07/19] spi: cadence-quadspi: add DQS support to read data capture Santhosh Kumar K
2026-11-05 10:58 ` [PATCH v11 08/19] spi: cadence-quadspi: add PHY tuning support Santhosh Kumar K
2026-11-05 11:22   ` sashiko-bot
2026-11-15 19:02   ` Mark Brown
2026-11-05 10:58 ` [PATCH v11 09/19] spi: cadence-quadspi: skip DDR PHY tuning for 2-byte-address ops (i2383) Santhosh Kumar K
2026-11-05 10:58 ` [PATCH v11 10/19] spi: cadence-quadspi: refactor direct read path for PHY support Santhosh Kumar K
2026-11-05 10:58 ` [PATCH v11 11/19] spi: cadence-quadspi: enable PHY for direct reads Santhosh Kumar K
2026-11-05 11:27   ` sashiko-bot
2026-11-15 19:02   ` Mark Brown
2026-11-05 10:58 ` [PATCH v11 12/19] spi: cadence-quadspi: enable PHY for indirect writes Santhosh Kumar K
2026-11-05 11:21   ` sashiko-bot
2026-11-05 10:58 ` [PATCH v11 13/19] spi: cadence-quadspi: reprogram CS timing on every chip-select switch Santhosh Kumar K
2026-11-05 10:58 ` [PATCH v11 14/19] spi: cadence-quadspi: reprogram PHY DLL on runtime resume Santhosh Kumar K
2026-11-05 10:58 ` [PATCH v11 15/19] mtd: spinand: extract variant ranking logic into spinand_op_find_best_variant() Santhosh Kumar K
2026-11-05 10:58 ` [PATCH v11 16/19] mtd: spinand: negotiate optimal controller operating point before dirmap creation Santhosh Kumar K
2026-11-05 11:31   ` sashiko-bot
2026-11-05 10:58 ` [PATCH v11 17/19] mtd: spi-nor: extract read op template construction into helper Santhosh Kumar K
2026-11-05 10:58 ` [PATCH v11 18/19] mtd: spi-nor: run controller optimization before dirmap creation Santhosh Kumar K
2026-11-05 10:58 ` [PATCH v11 19/19] mtd: spi-nor: reset max_read_op frequency for security register reads Santhosh Kumar K
2026-11-20 12:56 ` [PATCH v11 00/19] spi: cadence-quadspi: add PHY tuning support Michael Walle
2026-11-20 13:18   ` Miquel Raynal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cxrzbpzs.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=m-shah@ti.com \
    --cc=mwalle@kernel.org \
    --cc=praneeth@ti.com \
    --cc=pratyush@kernel.org \
    --cc=richard@nod.at \
    --cc=robh@kernel.org \
    --cc=s-k6@ti.com \
    --cc=sebin.francis@ti.com \
    --cc=srikanth.boyapally@amd.com \
    --cc=takahiro.kuwano@infineon.com \
    --cc=u-kumar1@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox