Linux-mtd Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Jakub Czapiga <czapiga@google.com>
Cc: Tudor Ambarus <tudor.ambarus@linaro.org>,
	 Pratyush Yadav <pratyush@kernel.org>,
	 Michael Walle <mwalle@kernel.org>,
	 Richard Weinberger <richard@nod.at>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	linux-mtd@lists.infradead.org,  linux-kernel@vger.kernel.org,
	 Konrad Adamczyk <konrada@google.com>,
	 Adeel Arshad <adeel.arshad@intel.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: Re: [PATCH] mtd: spi-nor: core: Check read CR support
Date: Wed, 10 Sep 2025 14:04:42 +0200	[thread overview]
Message-ID: <87frcucy3p.fsf@bootlin.com> (raw)
In-Reply-To: <20250910103355.629421-1-czapiga@google.com> (Jakub Czapiga's message of "Wed, 10 Sep 2025 10:33:55 +0000")

Hi Jakub,

> diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c
> index ac4b960101cc..79deee3a50d3 100644
> --- a/drivers/mtd/spi-nor/core.c
> +++ b/drivers/mtd/spi-nor/core.c
> @@ -2608,6 +2608,10 @@ static int spi_nor_setup(struct spi_nor *nor,
>  		}
>  	}
>  
> +	/* Some SPI controllers might not support CR read opcode. */
> +	if (spi_nor_read_cr(nor, nor->bouncebuf) == -EOPNOTSUPP)

There is a spi_nor_spimem_check_op() helper which might be better suited
for this purpose?

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2025-09-10 12:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-10 10:33 [PATCH] mtd: spi-nor: core: Check read CR support Jakub Czapiga
2025-09-10 12:04 ` Miquel Raynal [this message]
2025-09-10 14:30   ` Jakub "Kuba" Czapiga
2025-09-10 14:45     ` Miquel Raynal
2025-09-10 15:00       ` Tudor Ambarus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87frcucy3p.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=adeel.arshad@intel.com \
    --cc=czapiga@google.com \
    --cc=konrada@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=mwalle@kernel.org \
    --cc=pratyush@kernel.org \
    --cc=richard@nod.at \
    --cc=tudor.ambarus@linaro.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox