Linux-mtd Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael Walle" <mwalle@kernel.org>
To: "Fabio Estevam" <festevam@gmail.com>, <pratyush@kernel.org>
Cc: <takahiro.kuwano@infineon.com>, <miquel.raynal@bootlin.com>,
	<richard@nod.at>, <vigneshr@ti.com>, <heiko@sntech.de>,
	<linux-mtd@lists.infradead.org>,
	"Fabio Estevam" <festevam@nabladev.com>
Subject: Re: [PATCH] mtd: spi-nor: xmc: Add XM25QH128C identification
Date: Mon, 20 Jul 2026 08:45:47 +0200	[thread overview]
Message-ID: <DK372KBK7E8X.383DA8L7J4JIX@kernel.org> (raw)
In-Reply-To: <20260718213827.701787-1-festevam@gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 2359 bytes --]

On Sat Jul 18, 2026 at 11:38 PM CEST, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@nabladev.com>
>
> The XMC XM25QH128C is a 128-Mbit SPI NOR flash with JEDEC ID
> 20 40 18.
>
> Add its identification entry. The device provides valid SFDP data, so
> its parameters continue to be initialized entirely from SFDP.

So why do you need an entry? We don't add .names on new entries.

> The flash is populated on the Firefly ROC-RK3399-PC Plus board.
>
> Signed-off-by: Fabio Estevam <festevam@nabladev.com>
> ---
> Tested on a Firefly ROC-RK3399-PC Plus using the
> "rockchip,rk3399-spi" controller at 30 MHz.
>
> root@rk3399-station-p1:~# cat /sys/bus/spi/devices/spi1.0/spi-nor/partname
> XM25QH128C
> root@rk3399-station-p1:~# cat /sys/bus/spi/devices/spi1.0/spi-nor/jedec_id
> 204018
> root@rk3399-station-p1:~# cat /sys/bus/spi/devices/spi1.0/spi-nor/manufacturer
> xmc
> root@rk3399-station-p1:~# hexdump -Cv /sys/bus/spi/devices/spi1.0/spi-nor/sfdp
> 00000000  53 46 44 50 06 01 02 ff  00 06 01 10 30 00 00 ff  |SFDP........0...|
> 00000010  20 00 01 04 d0 00 00 ff  84 00 01 02 c0 00 00 ff  | ...............|
> 00000020  ff ff ff ff ff ff ff ff  ff ff ff ff ff ff ff ff  |................|
> 00000030  e5 20 f1 ff ff ff ff 07  44 eb 08 6b 08 3b 42 bb  |. ......D..k.;B.|
> 00000040  fe ff ff ff ff ff 00 ff  ff ff 40 eb 0c 20 0f 52  |..........@.. .R|
> 00000050  10 d8 00 ff 24 02 06 01  82 a7 03 cd cc a1 06 35  |....$..........5|
> 00000060  7a 75 7a 75 f7 a9 d5 5c  19 f6 4d ff e9 10 c0 80  |zuzu...\..M.....|
> 00000070  ff ff ff ff ff ff ff ff  ff ff ff ff ff ff ff ff  |................|
> 00000080  ff ff ff ff ff ff ff ff  ff ff ff ff ff ff ff ff  |................|
> 00000090  ff ff ff ff ff ff ff ff  ff ff ff ff ff ff ff ff  |................|
> 000000a0  ff ff ff ff ff ff ff ff  ff ff ff ff ff ff ff ff  |................|
> 000000b0  ff ff ff ff ff ff ff ff  ff ff ff ff ff ff ff ff  |................|
> 000000c0  00 00 f0 ff ff ff ff ff  ff ff ff ff ff ff ff ff  |................|
> 000000d0  00 36 00 23 9f f9 77 64  00 e8 ff ff ff ff ff ff  |.6.#..wd........|
> 000000e0

Thanks!

> root@rk3399-station-p1:~# sha256sum /sys/bus/spi/devices/spi1.0/spi-nor/sfdp
> c027b82ebfdf18e455c6366a9d57602b36f2956d4307b770954544918102d9b3  /sys/bus/spi/devices/spi1.0/spi-nor/sfdp

-michael

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 297 bytes --]

[-- Attachment #2: Type: text/plain, Size: 144 bytes --]

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2026-07-20  6:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-18 21:38 [PATCH] mtd: spi-nor: xmc: Add XM25QH128C identification Fabio Estevam
2026-07-20  6:45 ` Michael Walle [this message]
2026-07-20 18:43   ` Fabio Estevam
2026-07-21  8:47     ` Michael Walle
2026-07-21 12:05       ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DK372KBK7E8X.383DA8L7J4JIX@kernel.org \
    --to=mwalle@kernel.org \
    --cc=festevam@gmail.com \
    --cc=festevam@nabladev.com \
    --cc=heiko@sntech.de \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=pratyush@kernel.org \
    --cc=richard@nod.at \
    --cc=takahiro.kuwano@infineon.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox