Re: [PATCH] mtd: spi-nor: xmc: Add XM25QH128C identification

["Michael Walle" <mwalle@kernel.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1423 bytes --]

Hi Fabio,

On Mon Jul 20, 2026 at 8:43 PM CEST, Fabio Estevam wrote:
> On Monday, July 20, 2026 03:45 -03, "Michael Walle" <mwalle@kernel.org> wrote:
>
>> So why do you need an entry? We don't add .names on new entries.
>
> Currently, I see:
>
> root@rk3399-station-p1:~# cat /sys/bus/spi/devices/spi1.0/spi-nor/partname
> spi-nor-generic
> root@rk3399-station-p1:~# cat /sys/bus/spi/devices/spi1.0/spi-nor/jedec_id
> 204018204018
> root@rk3399-station-p1:~# cat /sys/bus/spi/devices/spi1.0/spi-nor/manufacturer
> cat: /sys/bus/spi/devices/spi1.0/spi-nor/manufacturer: No such file or directory
> root@rk3399-station-p1:~# 
>
> After this patch:
>
> root@rk3399-station-p1:~# cat /sys/bus/spi/devices/spi1.0/spi-nor/partname
> XM25QH128C
> root@rk3399-station-p1:~# cat /sys/bus/spi/devices/spi1.0/spi-nor/jedec_id
> 204018
> root@rk3399-station-p1:~# cat /sys/bus/spi/devices/spi1.0/spi-nor/manufacturer
> xmc
>
> The advantage of this patch is to provide the partname and manufacturer entries for userspace.

Yeah I get that, but since vendors tend to reuse their flash ids for
different parts, the part name is useless (and probably wrong) most
of the time. The idea was to just expose the id nowadays and if you
really need the flash part name, it's the duty of an userspace
application to figure that out.

-michael

>
> If this is not wanted, feel free to discard this change.


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 297 bytes --]

[-- Attachment #2: Type: text/plain, Size: 144 bytes --]

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/