From: Marek Vasut <marek.vasut@gmail.com>
To: Ezequiel Garcia <ezequiel@collabora.com>,
Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
Cc: linux-mtd@lists.infradead.org,
Richard Weinberger <richard@nod.at>,
Brian Norris <computersforpeace@gmail.com>,
boris.brezillon@bootlin.com
Subject: Re: [PATCH] mtd: spi-nor: hisi: Avoid generic function names
Date: Tue, 10 Apr 2018 22:58:00 +0200 [thread overview]
Message-ID: <f2f9a818-e5d8-eb88-3a6c-56674d712f49@gmail.com> (raw)
In-Reply-To: <20180410200106.21173-1-ezequiel@collabora.com>
On 04/10/2018 10:01 PM, Ezequiel Garcia wrote:
> Using generic names such as get_if_type() is frowned
> upon: it suggests a core function (which is not),
> and then it makes code navigation harder.
>
> Given drivers are often used as starting point
> to write other drivers, generic names tend to spread
> like the flu. Cure the problem.
>
> Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
Reviewed-by: Marek Vasut <marek.vasut@gmail.com>
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2018-04-10 21:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 20:01 [PATCH] mtd: spi-nor: hisi: Avoid generic function names Ezequiel Garcia
2018-04-10 20:58 ` Marek Vasut [this message]
2018-04-22 17:20 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2f9a818-e5d8-eb88-3a6c-56674d712f49@gmail.com \
--to=marek.vasut@gmail.com \
--cc=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=ezequiel@collabora.com \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox