From: Kukjin Kim <kgene.kim@samsung.com>
To: 'Stephen Rothwell' <sfr@canb.auug.org.au>,
'Kyungmin Park' <kyungmin.park@samsung.com>
Cc: linux-next@vger.kernel.org, 'LKML' <linux-kernel@vger.kernel.org>
Subject: RE: linux-next: incorrect build fix
Date: Wed, 09 Nov 2011 14:08:35 +0900 [thread overview]
Message-ID: <001e01cc9e9d$a26dca20$e7495e60$%kim@samsung.com> (raw)
In-Reply-To: <20111109082624.ea5697763c50ef9128244783@canb.auug.org.au>
Stephen Rothwell wrote:
>
> Hi,
>
Hi Stephen,
> I noticed in commit 8644c202ff42 ("ARM: EXYNOS: Fix compiler error with
> THIS_MODULE") in the s5p tree, an include of linux/module.h is used to
> get THIS_MODULE. For THIS_MODULE, you only need to include
> linux/export.h, now. To fix the other errors that were fixed by side
> effects of including module.h, you should include linux/time.h (for
> struct timeval, USEC_PER_SEC and do_gettimeofday).
>
OK, I will fix it in my tree.
> Please try a bit harder to get these things right.
Thanks for your pointing out :)
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
next prev parent reply other threads:[~2011-11-09 5:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-08 21:26 linux-next: incorrect build fix Stephen Rothwell
2011-11-09 5:08 ` Kukjin Kim [this message]
2011-11-09 6:11 ` Kukjin Kim
2011-11-09 6:37 ` Stephen Rothwell
2011-11-09 7:12 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001e01cc9e9d$a26dca20$e7495e60$%kim@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox