From: Kukjin Kim <kgene.kim@samsung.com>
To: 'Stephen Rothwell' <sfr@canb.auug.org.au>
Cc: 'Kyungmin Park' <kyungmin.park@samsung.com>,
linux-next@vger.kernel.org, 'LKML' <linux-kernel@vger.kernel.org>
Subject: RE: linux-next: incorrect build fix
Date: Wed, 09 Nov 2011 16:12:44 +0900 [thread overview]
Message-ID: <004e01cc9eae$fa5f4ef0$ef1decd0$%kim@samsung.com> (raw)
In-Reply-To: <20111109173722.a7f4c7d65c13bcb80bf2e6ba@canb.auug.org.au>
Stephen Rothwell wrote:
>
> Hi,
>
> On Wed, 09 Nov 2011 15:11:50 +0900 Kukjin Kim <kgene.kim@samsung.com>
> wrote:
> >
> > I'm not sure following......
> > So only for THIS_MODULE, <linux/export.h> should be added instead of
> > <linux/module.h>?
>
> Yes, that is correct. It means that much less code is included. If
> replacing module.h with export.h causes other build errors, they should
> be fixed by including the correct files directly (module.h include a lot
> of other include files).
I agree, okay. Will update Samsung stuff :)
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
prev parent reply other threads:[~2011-11-09 7:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-08 21:26 linux-next: incorrect build fix Stephen Rothwell
2011-11-09 5:08 ` Kukjin Kim
2011-11-09 6:11 ` Kukjin Kim
2011-11-09 6:37 ` Stephen Rothwell
2011-11-09 7:12 ` Kukjin Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='004e01cc9eae$fa5f4ef0$ef1decd0$%kim@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox