* next-2008-11-27: tracing on alpha (again)
@ 2008-11-28 9:02 Alexey Dobriyan
2008-11-28 9:14 ` Frédéric Weisbecker
0 siblings, 1 reply; 4+ messages in thread
From: Alexey Dobriyan @ 2008-11-28 9:02 UTC (permalink / raw)
To: sfr; +Cc: linux-next, fweisbec, mingo, edwintorok, linux-kernel
On alpha-smp-n-debug-y:
CC kernel/trace/trace.o
kernel/trace/trace.c: In function 'ftrace_trace_userstack':
kernel/trace/trace.c:968: error: storage size of 'trace' isn't known
kernel/trace/trace.c:968: warning: unused variable 'trace'
make[3]: *** [kernel/trace/trace.o] Error 1
CC kernel/trace/trace_branch.o
kernel/trace/trace_branch.c: In function 'probe_likely_condition':
kernel/trace/trace_branch.c:44: error: implicit declaration of function 'raw_local_irq_save'
kernel/trace/trace_branch.c:76: error: implicit declaration of function 'raw_local_irq_restore'
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: next-2008-11-27: tracing on alpha (again)
2008-11-28 9:02 next-2008-11-27: tracing on alpha (again) Alexey Dobriyan
@ 2008-11-28 9:14 ` Frédéric Weisbecker
2008-11-28 9:17 ` [PATCH] fix build: add missing #ifdef CONFIG_STACKTRACE Török Edwin
0 siblings, 1 reply; 4+ messages in thread
From: Frédéric Weisbecker @ 2008-11-28 9:14 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: sfr, linux-next, mingo, edwintorok, linux-kernel
2008/11/28 Alexey Dobriyan <adobriyan@gmail.com>:
> On alpha-smp-n-debug-y:
>
> CC kernel/trace/trace.o
> kernel/trace/trace.c: In function 'ftrace_trace_userstack':
> kernel/trace/trace.c:968: error: storage size of 'trace' isn't known
> kernel/trace/trace.c:968: warning: unused variable 'trace'
> make[3]: *** [kernel/trace/trace.o] Error 1
I think it needs a missing #ifdef CONFIG_STACKTRACE inside
ftrace_trace_userstack.
> CC kernel/trace/trace_branch.o
> kernel/trace/trace_branch.c: In function 'probe_likely_condition':
> kernel/trace/trace_branch.c:44: error: implicit declaration of function 'raw_local_irq_save'
> kernel/trace/trace_branch.c:76: error: implicit declaration of function 'raw_local_irq_restore'
>
Needs a missing #include <linux/irqflags.h>
I don't have time to submit patches now. Probably this night....
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] fix build: add missing #ifdef CONFIG_STACKTRACE
2008-11-28 9:14 ` Frédéric Weisbecker
@ 2008-11-28 9:17 ` Török Edwin
2008-11-28 10:34 ` Ingo Molnar
0 siblings, 1 reply; 4+ messages in thread
From: Török Edwin @ 2008-11-28 9:17 UTC (permalink / raw)
To: adobriyan; +Cc: sfr, linux-next, mingo, linux-kernel, Török Edwin
Signed-off-by: Török Edwin <edwintorok@gmail.com>
---
kernel/trace/trace.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 5811e0a..91887a2 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -983,6 +983,7 @@ static void ftrace_trace_userstack(struct trace_array *tr,
struct trace_array_cpu *data,
unsigned long flags, int pc)
{
+#ifdef CONFIG_STACKTRACE
struct ring_buffer_event *event;
struct userstack_entry *entry;
struct stack_trace trace;
@@ -1008,6 +1009,7 @@ static void ftrace_trace_userstack(struct trace_array *tr,
save_stack_trace_user(&trace);
ring_buffer_unlock_commit(tr->buffer, event, irq_flags);
+#endif
}
void __trace_userstack(struct trace_array *tr,
--
1.5.6.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] fix build: add missing #ifdef CONFIG_STACKTRACE
2008-11-28 9:17 ` [PATCH] fix build: add missing #ifdef CONFIG_STACKTRACE Török Edwin
@ 2008-11-28 10:34 ` Ingo Molnar
0 siblings, 0 replies; 4+ messages in thread
From: Ingo Molnar @ 2008-11-28 10:34 UTC (permalink / raw)
To: Török Edwin; +Cc: adobriyan, sfr, linux-next, linux-kernel
* Török Edwin <edwintorok@gmail.com> wrote:
>
> Signed-off-by: Török Edwin <edwintorok@gmail.com>
> ---
> kernel/trace/trace.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
applied to tip/tracing/stack-tracer, and pushed out into ftrace-next, thanks
Edwin!
Ingo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-11-28 10:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-28 9:02 next-2008-11-27: tracing on alpha (again) Alexey Dobriyan
2008-11-28 9:14 ` Frédéric Weisbecker
2008-11-28 9:17 ` [PATCH] fix build: add missing #ifdef CONFIG_STACKTRACE Török Edwin
2008-11-28 10:34 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox