* next: CNIC: build fails
@ 2009-06-10 12:56 Alexander Beregalov
2009-06-10 14:55 ` James Bottomley
0 siblings, 1 reply; 3+ messages in thread
From: Alexander Beregalov @ 2009-06-10 12:56 UTC (permalink / raw)
To: linux-next, mchan, James.Bottomley
Hi
drivers/net/cnic.c: In function 'cnic_start_hw':
drivers/net/cnic.c:2391: error: implicit declaration of function 'pci_dev_get'
The problem is that kconfig selects CNIC without it dependencies
config SCSI_BNX2_ISCSI
tristate "Broadcom NetXtreme II iSCSI support"
select SCSI_ISCSI_ATTRS
select CNIC
config BNX2
tristate "Broadcom NetXtremeII support"
depends on PCI
select CRC32
select FW_LOADER
config CNIC
tristate "Broadcom CNIC support"
depends on BNX2
depends on UIO
$ egrep "CNIC|BNX|_PCI" .config
# CONFIG_PCI is not set
CONFIG_SCSI_BNX2_ISCSI=y
CONFIG_CNIC=y
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: next: CNIC: build fails
2009-06-10 12:56 next: CNIC: build fails Alexander Beregalov
@ 2009-06-10 14:55 ` James Bottomley
2009-06-10 15:14 ` Michael Chan
0 siblings, 1 reply; 3+ messages in thread
From: James Bottomley @ 2009-06-10 14:55 UTC (permalink / raw)
To: Alexander Beregalov; +Cc: linux-next, mchan, linux-scsi
On Wed, 2009-06-10 at 16:56 +0400, Alexander Beregalov wrote:
> Hi
>
> drivers/net/cnic.c: In function 'cnic_start_hw':
> drivers/net/cnic.c:2391: error: implicit declaration of function 'pci_dev_get'
>
> The problem is that kconfig selects CNIC without it dependencies
>
> config SCSI_BNX2_ISCSI
> tristate "Broadcom NetXtreme II iSCSI support"
> select SCSI_ISCSI_ATTRS
> select CNIC
>
> config BNX2
> tristate "Broadcom NetXtremeII support"
> depends on PCI
> select CRC32
> select FW_LOADER
>
> config CNIC
> tristate "Broadcom CNIC support"
> depends on BNX2
> depends on UIO
>
> $ egrep "CNIC|BNX|_PCI" .config
> # CONFIG_PCI is not set
> CONFIG_SCSI_BNX2_ISCSI=y
> CONFIG_CNIC=y
OK, so one way to fix this is to make BNX2_ISCSI depend on CNIC rather
than select it.
A better way might be to make CNIC select BNX and UIO and then make
BNX2_ISCSI depend on PCI as well.
James
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: next: CNIC: build fails
2009-06-10 14:55 ` James Bottomley
@ 2009-06-10 15:14 ` Michael Chan
0 siblings, 0 replies; 3+ messages in thread
From: Michael Chan @ 2009-06-10 15:14 UTC (permalink / raw)
To: 'James Bottomley', Alexander Beregalov
Cc: linux-next, linux-scsi, 'Mike Christie'
James Bottomley wrote:
> On Wed, 2009-06-10 at 16:56 +0400, Alexander Beregalov wrote:
> > Hi
> >
> > drivers/net/cnic.c: In function 'cnic_start_hw':
> > drivers/net/cnic.c:2391: error: implicit declaration of
> function 'pci_dev_get'
> >
> > The problem is that kconfig selects CNIC without it dependencies
> >
> > config SCSI_BNX2_ISCSI
> > tristate "Broadcom NetXtreme II iSCSI support"
> > select SCSI_ISCSI_ATTRS
> > select CNIC
> >
> > config BNX2
> > tristate "Broadcom NetXtremeII support"
> > depends on PCI
> > select CRC32
> > select FW_LOADER
> >
> > config CNIC
> > tristate "Broadcom CNIC support"
> > depends on BNX2
> > depends on UIO
> >
> > $ egrep "CNIC|BNX|_PCI" .config
> > # CONFIG_PCI is not set
> > CONFIG_SCSI_BNX2_ISCSI=y
> > CONFIG_CNIC=y
>
> OK, so one way to fix this is to make BNX2_ISCSI depend on CNIC rather
> than select it.
>
> A better way might be to make CNIC select BNX and UIO and then make
> BNX2_ISCSI depend on PCI as well.
>
We want BNX2_ISCSI to select CNIC, otherwise the user won't even see
the BNX2_ISCSI option under SCSI low-level drivers if CNIC is not
enabled.
So I like your second solution.
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-06-10 15:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-10 12:56 next: CNIC: build fails Alexander Beregalov
2009-06-10 14:55 ` James Bottomley
2009-06-10 15:14 ` Michael Chan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox