* next: voyager: sm/smp.h:205: error: 'smp_ops' undeclared
@ 2009-06-10 11:48 Alexander Beregalov
2009-06-10 19:14 ` James Bottomley
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Beregalov @ 2009-06-10 11:48 UTC (permalink / raw)
To: linux-next, James Bottomley
Hi
arch/x86/include/asm/smp.h: In function 'hard_smp_processor_id':
arch/x86/include/asm/smp.h:205: error: 'smp_ops' undeclared (first use
in this function)
The code
static inline int hard_smp_processor_id(void)
{
return smp_ops.hard_smp_processor_id();
}
should be under #ifdef CONFIG_SMP
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: next: voyager: sm/smp.h:205: error: 'smp_ops' undeclared
2009-06-10 11:48 next: voyager: sm/smp.h:205: error: 'smp_ops' undeclared Alexander Beregalov
@ 2009-06-10 19:14 ` James Bottomley
0 siblings, 0 replies; 2+ messages in thread
From: James Bottomley @ 2009-06-10 19:14 UTC (permalink / raw)
To: Alexander Beregalov; +Cc: linux-next
On Wed, 2009-06-10 at 15:48 +0400, Alexander Beregalov wrote:
> Hi
>
> arch/x86/include/asm/smp.h: In function 'hard_smp_processor_id':
> arch/x86/include/asm/smp.h:205: error: 'smp_ops' undeclared (first use
> in this function)
>
> The code
> static inline int hard_smp_processor_id(void)
> {
> return smp_ops.hard_smp_processor_id();
> }
> should be under #ifdef CONFIG_SMP
Actually, that won't work either ... it turns out the UP IO-APIC case
needs hard_smp_processor_id(). I'm starting to think that turning it
into an smp_ops function was the wrong thing to do.
James
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-06-10 19:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-10 11:48 next: voyager: sm/smp.h:205: error: 'smp_ops' undeclared Alexander Beregalov
2009-06-10 19:14 ` James Bottomley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox