public inbox for linux-next@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Fritz <chf.fritz@googlemail.com>
To: Dominik Brodowski <linux@dominikbrodowski.net>
Cc: linux-next@vger.kernel.org
Subject: [BUG -next] in pcmcia: use struct resource for PCMCIA devices, part 2
Date: Tue, 03 Aug 2010 01:53:21 +0200	[thread overview]
Message-ID: <1280793201.11158.32.camel@lovely.krouter> (raw)

Hi,

 buffer overflow in next-tree's commit 810654b4119fd8c6ce03ffeb4b78f0ff8ffe0559

drivers/pcmcia/ds.c
  555         for (i = 0; i < (MAX_IO_WIN + MAX_WIN); i++) {                                                                             
  556             c->io[i].name = p_dev->devname;                                                                                        

with 'io' only defined to MAX_IO_WIN

drivers/pcmcia/cs_internal.h
  42     struct resource io[MAX_IO_WIN]; /* io ports */                                                                        

non-tested fix:

diff --git a/drivers/pcmcia/cs_internal.h b/drivers/pcmcia/cs_internal.h
index da055dc..d14c6ec 100644
--- a/drivers/pcmcia/cs_internal.h
+++ b/drivers/pcmcia/cs_internal.h
@@ -39,7 +39,7 @@ typedef struct config_t {
 	unsigned char	Status, Pin, Copy, Option, ExtStatus;
 	unsigned int	CardValues;
 
-	struct resource io[MAX_IO_WIN]; /* io ports */
+	struct resource io[MAX_IO_WIN + MAX_WIN]; /* io ports */
 	struct resource mem[MAX_WIN];   /* mem areas */
 
 	struct {

             reply	other threads:[~2010-08-02 23:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-02 23:53 Christoph Fritz [this message]
2010-08-03  6:12 ` [BUG -next] in pcmcia: use struct resource for PCMCIA devices, part 2 Dominik Brodowski
2010-08-03 10:16   ` Christoph Fritz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1280793201.11158.32.camel@lovely.krouter \
    --to=chf.fritz@googlemail.com \
    --cc=linux-next@vger.kernel.org \
    --cc=linux@dominikbrodowski.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox