From: Christoph Fritz <chf.fritz@googlemail.com>
To: Dominik Brodowski <linux@dominikbrodowski.net>
Cc: linux-next@vger.kernel.org
Subject: Re: [BUG -next] in pcmcia: use struct resource for PCMCIA devices, part 2
Date: Tue, 03 Aug 2010 12:16:41 +0200 [thread overview]
Message-ID: <1280830601.3034.0.camel@lovely.krouter> (raw)
In-Reply-To: <20100803061257.GA9716@isilmar-3.linta.de>
On Tue, 2010-08-03 at 08:12 +0200, Dominik Brodowski wrote:
> Hey,
>
> On Tue, Aug 03, 2010 at 01:53:21AM +0200, Christoph Fritz wrote:
> > drivers/pcmcia/ds.c
> > 555 for (i = 0; i < (MAX_IO_WIN + MAX_WIN); i++) {
> > 556 c->io[i].name = p_dev->devname;
> >
> > with 'io' only defined to MAX_IO_WIN
> >
> > drivers/pcmcia/cs_internal.h
> > 42 struct resource io[MAX_IO_WIN]; /* io ports */
>
> Yes, this is ugly (and will be fixed right now), but it isn't really a bug,
> for we want c->mem[i].name to be set too, and c->mem[] follows immediately
> c->io[] and is sufficientyly large.
ah I see ;-)
thanks,
chf
prev parent reply other threads:[~2010-08-03 10:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-02 23:53 [BUG -next] in pcmcia: use struct resource for PCMCIA devices, part 2 Christoph Fritz
2010-08-03 6:12 ` Dominik Brodowski
2010-08-03 10:16 ` Christoph Fritz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1280830601.3034.0.camel@lovely.krouter \
--to=chf.fritz@googlemail.com \
--cc=linux-next@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox