[PATCH][-next] acpi/acpi_drivers.h: fix warnings when ACPI_DOCK is not enabled

[PATCH][-next] acpi/acpi_drivers.h: fix warnings when ACPI_DOCK is not enabled

[Arnaud Lacombe]

/src/linux/linux/drivers/ata/libata-acpi.c: In function 'ata_acpi_associate':
/src/linux/linux/drivers/ata/libata-acpi.c:266:11: warning: passing argument 2 of 'register_hotplug_dock_device' discards 'const' qualifier from pointer target type [enabled by default]
/src/linux/linux/include/acpi/acpi_drivers.h:146:19: note: expected 'struct acpi_dock_ops *' but argument is of type 'const struct acpi_dock_ops *'
/src/linux/linux/drivers/ata/libata-acpi.c:275:11: warning: passing argument 2 of 'register_hotplug_dock_device' discards 'const' qualifier from pointer target type [enabled by default]
/src/linux/linux/include/acpi/acpi_drivers.h:146:19: note: expected 'struct acpi_dock_ops *' but argument is of type 'const struct acpi_dock_ops *'

Cc: Vasiliy Kulikov <segoon@openwall.com>
Cc: Jeff Garzik <jgarzik@redhat.com>
Cc: Len Brown <len.brown@intel.com>
Signed-off-by: Arnaud Lacombe <lacombar@gmail.com>
---
 include/acpi/acpi_drivers.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/acpi/acpi_drivers.h b/include/acpi/acpi_drivers.h
index e49c36d..bb145e4 100644
--- a/include/acpi/acpi_drivers.h
+++ b/include/acpi/acpi_drivers.h
@@ -144,7 +144,7 @@ static inline void unregister_dock_notifier(struct notifier_block *nb)
 {
 }
 static inline int register_hotplug_dock_device(acpi_handle handle,
-					       struct acpi_dock_ops *ops,
+					       const struct acpi_dock_ops *ops,
 					       void *context)
 {
 	return -ENODEV;
-- 
1.7.6.153.g78432

Re: [PATCH][-next] acpi/acpi_drivers.h: fix warnings when ACPI_DOCK is not enabled

[Arnaud Lacombe]

Hi,

On Fri, Jul 29, 2011 at 12:34 PM, Arnaud Lacombe <lacombar@gmail.com> wrote:
> /src/linux/linux/drivers/ata/libata-acpi.c: In function 'ata_acpi_associate':
> /src/linux/linux/drivers/ata/libata-acpi.c:266:11: warning: passing argument 2 of 'register_hotplug_dock_device' discards 'const' qualifier from pointer target type [enabled by default]
> /src/linux/linux/include/acpi/acpi_drivers.h:146:19: note: expected 'struct acpi_dock_ops *' but argument is of type 'const struct acpi_dock_ops *'
> /src/linux/linux/drivers/ata/libata-acpi.c:275:11: warning: passing argument 2 of 'register_hotplug_dock_device' discards 'const' qualifier from pointer target type [enabled by default]
> /src/linux/linux/include/acpi/acpi_drivers.h:146:19: note: expected 'struct acpi_dock_ops *' but argument is of type 'const struct acpi_dock_ops *'
>
ping ? next-20110811 is still bad.

 - Arnaud

> Cc: Vasiliy Kulikov <segoon@openwall.com>
> Cc: Jeff Garzik <jgarzik@redhat.com>
> Cc: Len Brown <len.brown@intel.com>
> Signed-off-by: Arnaud Lacombe <lacombar@gmail.com>
> ---
>  include/acpi/acpi_drivers.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/acpi/acpi_drivers.h b/include/acpi/acpi_drivers.h
> index e49c36d..bb145e4 100644
> --- a/include/acpi/acpi_drivers.h
> +++ b/include/acpi/acpi_drivers.h
> @@ -144,7 +144,7 @@ static inline void unregister_dock_notifier(struct notifier_block *nb)
>  {
>  }
>  static inline int register_hotplug_dock_device(acpi_handle handle,
> -                                              struct acpi_dock_ops *ops,
> +                                              const struct acpi_dock_ops *ops,
>                                               void *context)
>  {
>        return -ENODEV;
> --
> 1.7.6.153.g78432
>
>