From: Joe Perches <joe@perches.com>
To: David Laight <David.Laight@ACULAB.COM>
Cc: Kalle Valo <kvalo@qca.qualcomm.com>,
linville@tuxdriver.com, sfr@canb.auug.org.au,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-next@vger.kernel.org,
ath6kl-devel@qualcomm.com, davem@davemloft.net
Subject: RE: [PATCH 5/6] ath6kl: convert ath6kl_dbg() and ath6kl_dbg_dump() into functions
Date: Thu, 05 Jan 2012 08:30:45 -0800 [thread overview]
Message-ID: <1325781045.22154.15.camel@joe2Laptop> (raw)
In-Reply-To: <AE90C24D6B3A694183C094C60CF0A2F6D8AF2F@saturn3.aculab.com>
On Thu, 2012-01-05 at 10:41 +0000, David Laight wrote:
> > > + va_start(args, fmt);
> > > + ath6kl_printk(KERN_DEBUG, fmt, &args);
> > Passing a va_list as an argument?
> > I believe this doesn't work.
> > I think you'll need to add and use:
> Passing a va_list certainly does work - vprintf() etc.
> What is problematical is taking the address of a va_list.
Nope. This referred to this specific instance.
Taking the address of a va_list works fine.
Look at the provide example.
next prev parent reply other threads:[~2012-01-05 16:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-04 23:07 [PATCH 0/6] ath6kl: create ath6kl_core.ko Kalle Valo
2012-01-04 23:07 ` [PATCH 1/6] ath6kl: rename vif init and cleanup functions Kalle Valo
2012-01-04 23:08 ` [PATCH 2/6] ath6kl: unify cfg80211 init/cleanup functions Kalle Valo
2012-01-04 23:08 ` [PATCH 3/6] ath6kl: create core.c Kalle Valo
2012-01-04 23:09 ` [PATCH 4/6] ath6kl: get rid of AR_DBG_LVL_CHECK() Kalle Valo
2012-01-04 23:58 ` Joe Perches
2012-01-05 8:57 ` Kalle Valo
2012-01-04 23:09 ` [PATCH 5/6] ath6kl: convert ath6kl_dbg() and ath6kl_dbg_dump() into functions Kalle Valo
2012-01-04 23:41 ` Joe Perches
2012-01-05 8:22 ` Kalle Valo
2012-01-05 10:41 ` David Laight
2012-01-05 16:30 ` Joe Perches [this message]
2012-01-04 23:10 ` [PATCH 6/6] ath6kl: create ath6kl_core.ko Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1325781045.22154.15.camel@joe2Laptop \
--to=joe@perches.com \
--cc=David.Laight@ACULAB.COM \
--cc=ath6kl-devel@qualcomm.com \
--cc=davem@davemloft.net \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox