linux-next: cputime tree build warning

linux-next: cputime tree build warning

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 437 bytes --]

Hi Martin,

Today's linux-next build (x86_64 allmodconfig) produced this warning:

fs/proc/uptime.c: In function 'uptime_proc_show':
fs/proc/uptime.c:14: warning: unused variable 'len'

Introduced by commit ed7e789abfc433e46524419b7cc51d949552505e ("[PATCH]
Fix idle time field in /proc/uptime") from the cputime tree.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

RE: linux-next: cputime tree build warning

[Abbott, MG (Michael)]

> Today's linux-next build (x86_64 allmodconfig) produced this warning:
> 
> fs/proc/uptime.c: In function 'uptime_proc_show':
> fs/proc/uptime.c:14: warning: unused variable 'len'
> 
> Introduced by commit ed7e789abfc433e46524419b7cc51d949552505e 
> ("[PATCH]
> Fix idle time field in /proc/uptime") from the cputime tree.

Ouch.  I do apologise.  The (now) bogus variable len must have been
preserved when I rebased from 2.6.29.3 to current git, and I guess I
didn't spot the warning among all the other warnings in the build.

--
I'm very sorry about the junk below generated from this account.
This e-mail and any attachments may contain confidential, copyright and or privileged material, and are for the use of the intended addressee only. If you are not the intended addressee or an authorised recipient of the addressee please notify us of receipt by returning the e-mail and do not use, copy, retain, distribute or disclose the information in or attached to the e-mail.
Any opinions expressed within this e-mail are those of the individual and not necessarily of Diamond Light Source Ltd. 
Diamond Light Source Ltd. cannot guarantee that this e-mail or any attachments are free from viruses and we cannot accept liability for any damage which you may sustain as a result of software viruses which may be transmitted in or with the message.
Diamond Light Source Limited (company no. 4375679). Registered in England and Wales with its registered office at Diamond House, Harwell Science and Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United Kingdom
 

Re: linux-next: cputime tree build warning

[Martin Schwidefsky]

On Tue, 19 May 2009 08:39:32 +0100
"Abbott, MG (Michael)" <michael.abbott@diamond.ac.uk> wrote:

> > Today's linux-next build (x86_64 allmodconfig) produced this warning:
> > 
> > fs/proc/uptime.c: In function 'uptime_proc_show':
> > fs/proc/uptime.c:14: warning: unused variable 'len'
> > 
> > Introduced by commit ed7e789abfc433e46524419b7cc51d949552505e 
> > ("[PATCH]
> > Fix idle time field in /proc/uptime") from the cputime tree.
> 
> Ouch.  I do apologise.  The (now) bogus variable len must have been
> preserved when I rebased from 2.6.29.3 to current git, and I guess I
> didn't spot the warning among all the other warnings in the build.
 
I'll fix the two problems with the patch: 1) remove len, 2) use
cputime_zero to initialize idletime and update the cputime branch.

-- 
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.