* linux-next: hid tree build failure
@ 2009-06-26 5:31 Stephen Rothwell
2009-06-26 8:53 ` Jiri Kosina
0 siblings, 1 reply; 7+ messages in thread
From: Stephen Rothwell @ 2009-06-26 5:31 UTC (permalink / raw)
To: Jiri Kosina; +Cc: linux-next, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1466 bytes --]
Hi Jiri,
Today's linux-next build (sparc32 defconfig) failed like this:
drivers/hid/hid-core.c:862:34: error: macro "hid_dump_input" passed 3 arguments, but takes just 2
drivers/hid/hid-core.c: In function 'hid_process_event':
drivers/hid/hid-core.c:862: error: 'hid_dump_input' undeclared (first use in this function)
drivers/hid/hid-core.c:862: error: (Each undeclared identifier is reported only once
drivers/hid/hid-core.c:862: error: for each function it appears in.)
drivers/hid/hid-core.c:984:68: error: macro "hid_dump_input" passed 3 arguments, but takes just 2
drivers/hid/hid-core.c: In function 'hid_set_field':
drivers/hid/hid-core.c:984: error: 'hid_dump_input' undeclared (first use in this function)
drivers/hid/hid-core.c: In function 'hid_input_report':
drivers/hid/hid-core.c:1090: error: 'HID_DEBUG_BUFSIZE' undeclared (first use in this function)
Caused by commit cd667ce24796700e1a0e6e7528efc61c96ff832e ("HID: use
debugfs for events/reports dumping") which modified the prototype for
hid_dump_input, but not the !CONFIG_DEBUG_FS version. It also added
HID_DEBUG_BUFSIZE when CONFIG_DEBUG_FS, but used it otherwise.
I have reverted that commit for today (along with commit
a635f9dd83f3382577f4544a96df12356e951a40 ("HID: use debugfs for report
dumping descriptor") which doesn't build without the other one).
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: linux-next: hid tree build failure
2009-06-26 5:31 linux-next: hid tree build failure Stephen Rothwell
@ 2009-06-26 8:53 ` Jiri Kosina
2009-06-26 17:28 ` Stephen Rothwell
0 siblings, 1 reply; 7+ messages in thread
From: Jiri Kosina @ 2009-06-26 8:53 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next, linux-kernel
On Fri, 26 Jun 2009, Stephen Rothwell wrote:
> Today's linux-next build (sparc32 defconfig) failed like this:
>
> drivers/hid/hid-core.c:862:34: error: macro "hid_dump_input" passed 3 arguments, but takes just 2
> drivers/hid/hid-core.c: In function 'hid_process_event':
> drivers/hid/hid-core.c:862: error: 'hid_dump_input' undeclared (first use in this function)
> drivers/hid/hid-core.c:862: error: (Each undeclared identifier is reported only once
> drivers/hid/hid-core.c:862: error: for each function it appears in.)
> drivers/hid/hid-core.c:984:68: error: macro "hid_dump_input" passed 3 arguments, but takes just 2
> drivers/hid/hid-core.c: In function 'hid_set_field':
> drivers/hid/hid-core.c:984: error: 'hid_dump_input' undeclared (first use in this function)
> drivers/hid/hid-core.c: In function 'hid_input_report':
> drivers/hid/hid-core.c:1090: error: 'HID_DEBUG_BUFSIZE' undeclared (first use in this function)
>
> Caused by commit cd667ce24796700e1a0e6e7528efc61c96ff832e ("HID: use
> debugfs for events/reports dumping") which modified the prototype for
> hid_dump_input, but not the !CONFIG_DEBUG_FS version. It also added
> HID_DEBUG_BUFSIZE when CONFIG_DEBUG_FS, but used it otherwise.
>
> I have reverted that commit for today (along with commit
> a635f9dd83f3382577f4544a96df12356e951a40 ("HID: use debugfs for report
> dumping descriptor") which doesn't build without the other one).
Hi Stephen,
should be now fixed in the branch you pull into -next.
Thanks,
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 7+ messages in thread
* linux-next: hid tree build failure
@ 2009-01-19 1:33 Stephen Rothwell
2009-01-19 8:23 ` Jiri Kosina
0 siblings, 1 reply; 7+ messages in thread
From: Stephen Rothwell @ 2009-01-19 1:33 UTC (permalink / raw)
To: Jiri Kosina; +Cc: linux-next, Oliver Neukum
[-- Attachment #1: Type: text/plain, Size: 781 bytes --]
Hi Jiri,
Today's linux-next build (powerpc ppc64_defconfig) failed like this:
drivers/hid/usbhid/hid-core.c: In function 'hid_suspend':
drivers/hid/usbhid/hid-core.c:1220: error: 'struct usb_device' has no member named 'auto_pm'
drivers/hid/usbhid/hid-core.c:1245: error: 'struct usb_device' has no member named 'auto_pm'
drivers/hid/usbhid/hid-core.c:1258: error: 'struct usb_device' has no member named 'auto_pm'
The immediate cause is commit ae14e83aaa975a732ed46dcc9a080172a60f08a6
("HID: autosuspend support for USB HID"). The above config does not have
CONFIG_PM set and auto_pm is only defined for CONFIG_PM.
I have dropped the hid tree for today.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: linux-next: hid tree build failure
2009-01-19 1:33 Stephen Rothwell
@ 2009-01-19 8:23 ` Jiri Kosina
2009-01-19 8:42 ` Stephen Rothwell
0 siblings, 1 reply; 7+ messages in thread
From: Jiri Kosina @ 2009-01-19 8:23 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next, Oliver Neukum
On Mon, 19 Jan 2009, Stephen Rothwell wrote:
> Hi Jiri,
>
> Today's linux-next build (powerpc ppc64_defconfig) failed like this:
>
> drivers/hid/usbhid/hid-core.c: In function 'hid_suspend':
> drivers/hid/usbhid/hid-core.c:1220: error: 'struct usb_device' has no member named 'auto_pm'
> drivers/hid/usbhid/hid-core.c:1245: error: 'struct usb_device' has no member named 'auto_pm'
> drivers/hid/usbhid/hid-core.c:1258: error: 'struct usb_device' has no member named 'auto_pm'
Hi Stephen,
thanks a lot for reporting this. I have applied the patch below into the
branch that gets pulled by you.
From: Jiri Kosina <jkosina@suse.cz>
Subject: [PATCH] HID: do not try to compile PM code with CONFIG_PM unset
Fixes this build breakage in case when CONFIG_PM is not set
drivers/hid/usbhid/hid-core.c: In function 'hid_suspend':
drivers/hid/usbhid/hid-core.c:1220: error: 'struct usb_device' has no member named 'auto_pm'
drivers/hid/usbhid/hid-core.c:1245: error: 'struct usb_device' has no member named 'auto_pm'
drivers/hid/usbhid/hid-core.c:1258: error: 'struct usb_device' has no member named 'auto_pm'
by throwing both the hid_suspend() and hid_resume() away completely
in such case, as they won't be used anyway.
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---
drivers/hid/usbhid/hid-core.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/drivers/hid/usbhid/hid-core.c b/drivers/hid/usbhid/hid-core.c
index 625e7e8..d8799a1 100644
--- a/drivers/hid/usbhid/hid-core.c
+++ b/drivers/hid/usbhid/hid-core.c
@@ -1210,6 +1210,7 @@ static void hid_cease_io(struct usbhid_device *usbhid)
flush_scheduled_work();
}
+#ifdef CONFIG_PM
static int hid_suspend(struct usb_interface *intf, pm_message_t message)
{
struct hid_device *hid = usb_get_intfdata(intf);
@@ -1292,6 +1293,8 @@ static int hid_resume(struct usb_interface *intf)
return 0;
}
+#endif /* CONFIG_PM */
+
/* Treat USB reset pretty much the same as suspend/resume */
static int hid_pre_reset(struct usb_interface *intf)
{
@@ -1353,9 +1356,11 @@ static struct usb_driver hid_driver = {
.name = "usbhid",
.probe = hid_probe,
.disconnect = hid_disconnect,
+#ifdef CONFIG_PM
.suspend = hid_suspend,
.resume = hid_resume,
.reset_resume = hid_post_reset,
+#endif
.pre_reset = hid_pre_reset,
.post_reset = hid_post_reset,
.id_table = hid_usb_ids,
--
1.5.6
^ permalink raw reply related [flat|nested] 7+ messages in thread
* linux-next: hid tree build failure
@ 2008-08-25 5:14 Stephen Rothwell
0 siblings, 0 replies; 7+ messages in thread
From: Stephen Rothwell @ 2008-08-25 5:14 UTC (permalink / raw)
To: Jiri Kosina, Greg KH; +Cc: linux-next, Jiri Slaby
Hi Jiri, Greg,
Today's linux-next build (powerpc ppc64_defconfig) failed like this:
drivers/hid/usbhid/hid-core.c: In function 'usbhid_submit_report':
drivers/hid/usbhid/hid-core.c:417: error: incompatible type for argument 1 of 'dev_driver_string'
drivers/hid/usbhid/hid-core.c:417: error: incompatible type for argument 1 of 'dev_name'
drivers/hid/usbhid/hid-core.c:436: error: incompatible type for argument 1 of 'dev_driver_string'
drivers/hid/usbhid/hid-core.c:436: error: incompatible type for argument 1 of 'dev_name'
drivers/hid/usbhid/hid-core.c: In function 'usbhid_init_reports':
drivers/hid/usbhid/hid-core.c:568: error: incompatible type for argument 1 of 'dev_driver_string'
drivers/hid/usbhid/hid-core.c:568: error: incompatible type for argument 1 of 'dev_name'
The x86_64 allmod config build also git these:
drivers/hid/usbhid/hid-tmff.c: In function 'hid_tmff_init':
drivers/hid/usbhid/hid-tmff.c:166: error: incompatible type for argument 1 of 'dev_driver_string'
drivers/hid/usbhid/hid-tmff.c:166: error: incompatible type for argument 1 of 'dev_name'
drivers/hid/usbhid/hid-tmff.c:172: error: incompatible type for argument 1 of 'dev_driver_string'
drivers/hid/usbhid/hid-tmff.c:172: error: incompatible type for argument 1 of 'dev_name'
drivers/hid/usbhid/hid-tmff.c:178: error: incompatible type for argument 1 of 'dev_driver_string'
drivers/hid/usbhid/hid-tmff.c:178: error: incompatible type for argument 1 of 'dev_name'
drivers/hid/usbhid/hid-tmff.c:184: error: incompatible type for argument 1 of 'dev_driver_string'
drivers/hid/usbhid/hid-tmff.c:184: error: incompatible type for argument 1 of 'dev_name'
drivers/hid/usbhid/hid-tmff.c:206: error: incompatible type for argument 1 of 'dev_driver_string'
drivers/hid/usbhid/hid-tmff.c:206: error: incompatible type for argument 1 of 'dev_name'
drivers/hid/usbhid/hid-tmff.c:224: error: incompatible type for argument 1 of 'dev_driver_string'
drivers/hid/usbhid/hid-tmff.c:224: error: incompatible type for argument 1 of 'dev_name'
Introduced by commits 42c057049eb3ca9bad38fb0acc6290771a11d9ff ("USB:
remove warn() macro from usb.h") and
ca5f17ab52be0a1bbb2cc06fd127f5aa953b8619 ("USB: remove info() macro from
usb.h") from the usb tree interacting with commit
d9eecf89c2ca548dd102b87113a1145c5bfcdbf2 ("HID: make a bus from hid
code") from the hid tree. The latter changed the "dev" member of "struct
hid_device" from a "struct device *" to s "struct device".
I applied the following fixup which should be added to the hid tree if
you incorporate Greg's warn() removal patch.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 25 Aug 2008 14:49:42 +1000
Subject: [PATCH] HID: fix for warn() removal
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
drivers/hid/usbhid/hid-core.c | 6 +++---
drivers/hid/usbhid/hid-tmff.c | 12 ++++++------
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/hid/usbhid/hid-core.c b/drivers/hid/usbhid/hid-core.c
index 9cc9a75..5f32e30 100644
--- a/drivers/hid/usbhid/hid-core.c
+++ b/drivers/hid/usbhid/hid-core.c
@@ -414,7 +414,7 @@ void usbhid_submit_report(struct hid_device *hid, struct hid_report *report, uns
if ((head = (usbhid->outhead + 1) & (HID_OUTPUT_FIFO_SIZE - 1)) == usbhid->outtail) {
spin_unlock_irqrestore(&usbhid->outlock, flags);
- dev_warn(hid->dev, "output queue full\n");
+ dev_warn(&hid->dev, "output queue full\n");
return;
}
@@ -433,7 +433,7 @@ void usbhid_submit_report(struct hid_device *hid, struct hid_report *report, uns
if ((head = (usbhid->ctrlhead + 1) & (HID_CONTROL_FIFO_SIZE - 1)) == usbhid->ctrltail) {
spin_unlock_irqrestore(&usbhid->ctrllock, flags);
- dev_warn(hid->dev, "control queue full\n");
+ dev_warn(&hid->dev, "control queue full\n");
return;
}
@@ -565,7 +565,7 @@ void usbhid_init_reports(struct hid_device *hid)
}
if (err)
- dev_warn(hid->dev, "timeout initializing reports\n");
+ dev_warn(&hid->dev, "timeout initializing reports\n");
}
/*
diff --git a/drivers/hid/usbhid/hid-tmff.c b/drivers/hid/usbhid/hid-tmff.c
index beccdfb..451a8e6 100644
--- a/drivers/hid/usbhid/hid-tmff.c
+++ b/drivers/hid/usbhid/hid-tmff.c
@@ -163,25 +163,25 @@ int hid_tmff_init(struct hid_device *hid)
switch (field->usage[0].hid) {
case THRUSTMASTER_USAGE_FF:
if (field->report_count < 2) {
- dev_warn(hid->dev,
+ dev_warn(&hid->dev,
"ignoring FF field with report_count < 2\n");
continue;
}
if (field->logical_maximum == field->logical_minimum) {
- dev_warn(hid->dev,
+ dev_warn(&hid->dev,
"ignoring FF field with logical_maximum == logical_minimum\n");
continue;
}
if (tmff->report && tmff->report != report) {
- dev_warn(hid->dev,
+ dev_warn(&hid->dev,
"ignoring FF field in other report\n");
continue;
}
if (tmff->ff_field && tmff->ff_field != field) {
- dev_warn(hid->dev,
+ dev_warn(&hid->dev,
"ignoring duplicate FF field\n");
continue;
}
@@ -203,7 +203,7 @@ int hid_tmff_init(struct hid_device *hid)
break;
default:
- dev_warn(hid->dev,
+ dev_warn(&hid->dev,
"ignoring unknown output usage %08x\n",
field->usage[0].hid);
continue;
@@ -221,7 +221,7 @@ int hid_tmff_init(struct hid_device *hid)
if (error)
goto fail;
- dev_info(hid->dev,
+ dev_info(&hid->dev,
"Force feedback for ThrustMaster devices by Zinx Verituse <zinx@epicsol.org>\n");
return 0;
--
1.5.6.3
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2009-06-26 17:28 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-26 5:31 linux-next: hid tree build failure Stephen Rothwell
2009-06-26 8:53 ` Jiri Kosina
2009-06-26 17:28 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2009-01-19 1:33 Stephen Rothwell
2009-01-19 8:23 ` Jiri Kosina
2009-01-19 8:42 ` Stephen Rothwell
2008-08-25 5:14 Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox