linux-next: security-testing tree build failure

linux-next: security-testing tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 699 bytes --]

Hi ,

Today's linux-next build (sparc64 defconfig) failed like this:

cc1: warnings being treated as errors
include/linux/security.h:3012: error: 'security_key_session_to_parent' declared 'static' but never defined

Caused by commit ee18d64c1f632043a02e6f5ba5e045bb26a5465f ("KEYS: Add a
keyctl to install a process's session keyring on its parent [try #6]")
which I have reverted for today.

(I also reverted commit 945af7c3289c26c9070d6b1bf3ca759d36643e0b ("KEYS:
security_cred_alloc_blank() should return int under all circumstances")
which is a fix for the above commit.)

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

[PATCH] KEYS: Fix default security_session_to_parent()

[David Howells]

Fix the default security_session_to_parent() in linux/security.h to have a
body.

Signed-off-by: David Howells <dhowells@redhat.com>
---

 include/linux/security.h |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)


diff --git a/include/linux/security.h b/include/linux/security.h
index f4eb32d..10a0925 100644
--- a/include/linux/security.h
+++ b/include/linux/security.h
@@ -2988,7 +2988,10 @@ static inline int security_key_getsecurity(struct key *key, char **_buffer)
 
 static inline int security_key_session_to_parent(const struct cred *cred,
 						 const struct cred *parent_cred,
-						 struct key *key);
+						 struct key *key)
+{
+	return 0;
+}
 
 #endif
 #endif /* CONFIG_KEYS */

Re: [PATCH] KEYS: Fix default security_session_to_parent()

[James Morris]

On Mon, 7 Sep 2009, David Howells wrote:

> Fix the default security_session_to_parent() in linux/security.h to have a
> body.
> 
> Signed-off-by: David Howells <dhowells@redhat.com>

Thanks!


Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next


-- 
James Morris
<jmorris@namei.org>