* linux-next: security-testing tree build failure
@ 2009-09-07 13:40 Stephen Rothwell
2009-09-07 13:43 ` Stephen Rothwell
0 siblings, 1 reply; 7+ messages in thread
From: Stephen Rothwell @ 2009-09-07 13:40 UTC (permalink / raw)
To: James Morris; +Cc: linux-next, LKML, David Howells, Russell King
[-- Attachment #1: Type: text/plain, Size: 541 bytes --]
Hi David,
Today's linux-next build (arm lots of configs) failed like this:
arch/arm/kernel/signal.c: In function 'do_notify_resume':
arch/arm/kernel/signal.c:701: error: implicit declaration of function 'tracehook_notify_resume'
Caused by commit d0420c83f39f79afb82010c2d2cafd150eef651b ("KEYS: Extend
TIF_NOTIFY_RESUME to (almost) all architectures [try #6]"). Presumably
the include of linux/tracehook.h is missing.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: linux-next: security-testing tree build failure 2009-09-07 13:40 linux-next: security-testing tree build failure Stephen Rothwell @ 2009-09-07 13:43 ` Stephen Rothwell 2009-09-08 0:40 ` Stephen Rothwell 0 siblings, 1 reply; 7+ messages in thread From: Stephen Rothwell @ 2009-09-07 13:43 UTC (permalink / raw) To: James Morris; +Cc: linux-next, LKML, David Howells, Russell King [-- Attachment #1: Type: text/plain, Size: 745 bytes --] On Mon, 7 Sep 2009 23:40:28 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > Today's linux-next build (arm lots of configs) failed like this: > > arch/arm/kernel/signal.c: In function 'do_notify_resume': > arch/arm/kernel/signal.c:701: error: implicit declaration of function 'tracehook_notify_resume' > > Caused by commit d0420c83f39f79afb82010c2d2cafd150eef651b ("KEYS: Extend > TIF_NOTIFY_RESUME to (almost) all architectures [try #6]"). Presumably > the include of linux/tracehook.h is missing. The avr32 defconfig build fails the same way as well. Thee may be others, that is as far as we have gone so far. -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ [-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: linux-next: security-testing tree build failure 2009-09-07 13:43 ` Stephen Rothwell @ 2009-09-08 0:40 ` Stephen Rothwell 2009-09-08 3:22 ` Stephen Rothwell 2009-09-09 7:30 ` [PATCH] KEYS: Add missing linux/tracehook.h #inclusions David Howells 0 siblings, 2 replies; 7+ messages in thread From: Stephen Rothwell @ 2009-09-08 0:40 UTC (permalink / raw) To: James Morris; +Cc: linux-next, LKML, David Howells, Russell King [-- Attachment #1: Type: text/plain, Size: 1078 bytes --] Hi James, David, On Mon, 7 Sep 2009 23:43:31 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > On Mon, 7 Sep 2009 23:40:28 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > > > Today's linux-next build (arm lots of configs) failed like this: > > > > arch/arm/kernel/signal.c: In function 'do_notify_resume': > > arch/arm/kernel/signal.c:701: error: implicit declaration of function 'tracehook_notify_resume' > > > > Caused by commit d0420c83f39f79afb82010c2d2cafd150eef651b ("KEYS: Extend > > TIF_NOTIFY_RESUME to (almost) all architectures [try #6]"). Presumably > > the include of linux/tracehook.h is missing. > > The avr32 defconfig build fails the same way as well. Thee may be > others, that is as far as we have gone so far. This also broke the alpha and mips builds. I am going to use the version of the security-testing tree from next-20090902 (the latest version I have before the above commit was added) for today. -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ [-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: linux-next: security-testing tree build failure 2009-09-08 0:40 ` Stephen Rothwell @ 2009-09-08 3:22 ` Stephen Rothwell 2009-09-09 7:30 ` [PATCH] KEYS: Add missing linux/tracehook.h #inclusions David Howells 1 sibling, 0 replies; 7+ messages in thread From: Stephen Rothwell @ 2009-09-08 3:22 UTC (permalink / raw) To: James Morris; +Cc: linux-next, LKML, David Howells, Russell King [-- Attachment #1: Type: text/plain, Size: 307 bytes --] Hi James, David, On Tue, 8 Sep 2009 10:40:12 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > This also broke the alpha and mips builds. I am going to use the version And cris :-( -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ [-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] KEYS: Add missing linux/tracehook.h #inclusions 2009-09-08 0:40 ` Stephen Rothwell 2009-09-08 3:22 ` Stephen Rothwell @ 2009-09-09 7:30 ` David Howells 2009-09-09 8:38 ` James Morris 1 sibling, 1 reply; 7+ messages in thread From: David Howells @ 2009-09-09 7:30 UTC (permalink / raw) To: jmorris, sfr; +Cc: linux-next, linux-kernel, David Howells Add #inclusions of linux/tracehook.h to those arch files that had the tracehook call for TIF_NOTIFY_RESUME added when support for that flag was added to that arch. Signed-off-by: David Howells <dhowells@redhat.com> --- arch/alpha/kernel/signal.c | 1 + arch/arm/kernel/signal.c | 1 + arch/avr32/kernel/signal.c | 1 + arch/cris/kernel/ptrace.c | 1 + arch/h8300/kernel/signal.c | 1 + arch/m32r/kernel/signal.c | 1 + arch/mips/kernel/signal.c | 1 + arch/parisc/kernel/signal.c | 1 + 8 files changed, 8 insertions(+), 0 deletions(-) diff --git a/arch/alpha/kernel/signal.c b/arch/alpha/kernel/signal.c index d91aaa7..0932dbb 100644 --- a/arch/alpha/kernel/signal.c +++ b/arch/alpha/kernel/signal.c @@ -20,6 +20,7 @@ #include <linux/binfmts.h> #include <linux/bitops.h> #include <linux/syscalls.h> +#include <linux/tracehook.h> #include <asm/uaccess.h> #include <asm/sigcontext.h> diff --git a/arch/arm/kernel/signal.c b/arch/arm/kernel/signal.c index ea4ad3a..b76fe06 100644 --- a/arch/arm/kernel/signal.c +++ b/arch/arm/kernel/signal.c @@ -12,6 +12,7 @@ #include <linux/personality.h> #include <linux/freezer.h> #include <linux/uaccess.h> +#include <linux/tracehook.h> #include <asm/elf.h> #include <asm/cacheflush.h> diff --git a/arch/avr32/kernel/signal.c b/arch/avr32/kernel/signal.c index de9f7fe..64f886f 100644 --- a/arch/avr32/kernel/signal.c +++ b/arch/avr32/kernel/signal.c @@ -16,6 +16,7 @@ #include <linux/ptrace.h> #include <linux/unistd.h> #include <linux/freezer.h> +#include <linux/tracehook.h> #include <asm/uaccess.h> #include <asm/ucontext.h> diff --git a/arch/cris/kernel/ptrace.c b/arch/cris/kernel/ptrace.c index 32e9d5e..48b0f39 100644 --- a/arch/cris/kernel/ptrace.c +++ b/arch/cris/kernel/ptrace.c @@ -16,6 +16,7 @@ #include <linux/errno.h> #include <linux/ptrace.h> #include <linux/user.h> +#include <linux/tracehook.h> #include <asm/uaccess.h> #include <asm/page.h> diff --git a/arch/h8300/kernel/signal.c b/arch/h8300/kernel/signal.c index abac3ee..af842c3 100644 --- a/arch/h8300/kernel/signal.c +++ b/arch/h8300/kernel/signal.c @@ -39,6 +39,7 @@ #include <linux/tty.h> #include <linux/binfmts.h> #include <linux/freezer.h> +#include <linux/tracehook.h> #include <asm/setup.h> #include <asm/uaccess.h> diff --git a/arch/m32r/kernel/signal.c b/arch/m32r/kernel/signal.c index f80bac1..144b0f1 100644 --- a/arch/m32r/kernel/signal.c +++ b/arch/m32r/kernel/signal.c @@ -21,6 +21,7 @@ #include <linux/stddef.h> #include <linux/personality.h> #include <linux/freezer.h> +#include <linux/tracehook.h> #include <asm/cacheflush.h> #include <asm/ucontext.h> #include <asm/uaccess.h> diff --git a/arch/mips/kernel/signal.c b/arch/mips/kernel/signal.c index c2acf31..6254041 100644 --- a/arch/mips/kernel/signal.c +++ b/arch/mips/kernel/signal.c @@ -21,6 +21,7 @@ #include <linux/compiler.h> #include <linux/syscalls.h> #include <linux/uaccess.h> +#include <linux/tracehook.h> #include <asm/abi.h> #include <asm/asm.h> diff --git a/arch/parisc/kernel/signal.c b/arch/parisc/kernel/signal.c index 5ca1c02..8eb3c63 100644 --- a/arch/parisc/kernel/signal.c +++ b/arch/parisc/kernel/signal.c @@ -25,6 +25,7 @@ #include <linux/stddef.h> #include <linux/compat.h> #include <linux/elf.h> +#include <linux/tracehook.h> #include <asm/ucontext.h> #include <asm/rt_sigframe.h> #include <asm/uaccess.h> ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] KEYS: Add missing linux/tracehook.h #inclusions 2009-09-09 7:30 ` [PATCH] KEYS: Add missing linux/tracehook.h #inclusions David Howells @ 2009-09-09 8:38 ` James Morris 2009-09-09 8:48 ` Stephen Rothwell 0 siblings, 1 reply; 7+ messages in thread From: James Morris @ 2009-09-09 8:38 UTC (permalink / raw) To: David Howells; +Cc: sfr, linux-next, linux-kernel On Wed, 9 Sep 2009, David Howells wrote: > Add #inclusions of linux/tracehook.h to those arch files that had the tracehook > call for TIF_NOTIFY_RESUME added when support for that flag was added to that > arch. > > Signed-off-by: David Howells <dhowells@redhat.com> Applied to git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next -- James Morris <jmorris@namei.org> ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] KEYS: Add missing linux/tracehook.h #inclusions 2009-09-09 8:38 ` James Morris @ 2009-09-09 8:48 ` Stephen Rothwell 0 siblings, 0 replies; 7+ messages in thread From: Stephen Rothwell @ 2009-09-09 8:48 UTC (permalink / raw) To: James Morris; +Cc: David Howells, linux-next, linux-kernel [-- Attachment #1: Type: text/plain, Size: 326 bytes --] Hi James, David, On Wed, 9 Sep 2009 18:38:55 +1000 (EST) James Morris <jmorris@namei.org> wrote: > > Applied to > git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next Thanks guys. -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ [-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2009-09-09 8:48 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2009-09-07 13:40 linux-next: security-testing tree build failure Stephen Rothwell 2009-09-07 13:43 ` Stephen Rothwell 2009-09-08 0:40 ` Stephen Rothwell 2009-09-08 3:22 ` Stephen Rothwell 2009-09-09 7:30 ` [PATCH] KEYS: Add missing linux/tracehook.h #inclusions David Howells 2009-09-09 8:38 ` James Morris 2009-09-09 8:48 ` Stephen Rothwell
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox