* linux-next:als tree build failure
@ 2010-01-28 7:23 Stephen Rothwell
2010-01-28 7:41 ` Jean Delvare
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2010-01-28 7:23 UTC (permalink / raw)
To: Jonathan Cameron, Zhang Rui; +Cc: linux-next, linux-kernel, Jean Delvare
[-- Attachment #1: Type: text/plain, Size: 588 bytes --]
Hi all,
Today's linux-next build (powerpc allnoconfig) failed like this:
ld: drivers/i2c/chips/built-in.o: No such file: No such file or directory
Caused by commit b75349f118718a435f2bb7b6e675572ecd591627 ("tsl2550: Move
form i2c/chips to als and update interfaces"). This removes the last
driver from drivers/i2c/chips/ . Maybe it needs to remove the directory
completely and the references to it from drivers/i2c as well.
I have reverted that commit for today.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: linux-next:als tree build failure
2010-01-28 7:23 linux-next:als tree build failure Stephen Rothwell
@ 2010-01-28 7:41 ` Jean Delvare
2010-01-28 11:59 ` Jonathan Cameron
0 siblings, 1 reply; 6+ messages in thread
From: Jean Delvare @ 2010-01-28 7:41 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Jonathan Cameron, Zhang Rui, linux-next, linux-kernel
On Thu, 28 Jan 2010 18:23:34 +1100, Stephen Rothwell wrote:
> Hi all,
>
> Today's linux-next build (powerpc allnoconfig) failed like this:
>
> ld: drivers/i2c/chips/built-in.o: No such file: No such file or directory
>
> Caused by commit b75349f118718a435f2bb7b6e675572ecd591627 ("tsl2550: Move
> form i2c/chips to als and update interfaces"). This removes the last
> driver from drivers/i2c/chips/ . Maybe it needs to remove the directory
> completely and the references to it from drivers/i2c as well.
>
> I have reverted that commit for today.
My bad. I asked Jonathan to split the directory removal from the driver
move for clarity. I didn't expect this to cause a build failure.
Jonathan, I guess that at least the drivers/i2c/Makefile part must be
moved back to the tsl2550 driver move patch. I leave it to you whether
you want to move all the rest back as well, or just that part.
Thanks Stephen for the heads up and sorry again for the breakage.
--
Jean Delvare
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: linux-next:als tree build failure
2010-01-28 7:41 ` Jean Delvare
@ 2010-01-28 11:59 ` Jonathan Cameron
2010-01-28 12:17 ` Stephen Rothwell
0 siblings, 1 reply; 6+ messages in thread
From: Jonathan Cameron @ 2010-01-28 11:59 UTC (permalink / raw)
To: Jean Delvare; +Cc: Stephen Rothwell, Zhang Rui, linux-next, linux-kernel
On 01/28/10 07:41, Jean Delvare wrote:
> On Thu, 28 Jan 2010 18:23:34 +1100, Stephen Rothwell wrote:
>> Hi all,
>>
>> Today's linux-next build (powerpc allnoconfig) failed like this:
>>
>> ld: drivers/i2c/chips/built-in.o: No such file: No such file or directory
>>
>> Caused by commit b75349f118718a435f2bb7b6e675572ecd591627 ("tsl2550: Move
>> form i2c/chips to als and update interfaces"). This removes the last
>> driver from drivers/i2c/chips/ . Maybe it needs to remove the directory
>> completely and the references to it from drivers/i2c as well.
>>
>> I have reverted that commit for today.
>
> My bad. I asked Jonathan to split the directory removal from the driver
> move for clarity. I didn't expect this to cause a build failure.
>
> Jonathan, I guess that at least the drivers/i2c/Makefile part must be
> moved back to the tsl2550 driver move patch. I leave it to you whether
> you want to move all the rest back as well, or just that part.
>
> Thanks Stephen for the heads up and sorry again for the breakage.
>
Sorry from me as well. It never occurred to me either that it might cause
a build failure.
It does make sense to keep these two steps separate. Ah well, I guess any
work around would be a pretty terrible cludge. I'll roll these two patches
back together and otherwise we will end up with something even less coherent.
Thanks,
Jonathan
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: linux-next:als tree build failure
2010-01-28 11:59 ` Jonathan Cameron
@ 2010-01-28 12:17 ` Stephen Rothwell
2010-01-28 12:33 ` Jonathan Cameron
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2010-01-28 12:17 UTC (permalink / raw)
To: Jonathan Cameron; +Cc: Jean Delvare, Zhang Rui, linux-next, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 470 bytes --]
Hi Jonathan, Jean,
On Thu, 28 Jan 2010 11:59:37 +0000 Jonathan Cameron <jic23@cam.ac.uk> wrote:
>
> It does make sense to keep these two steps separate. Ah well, I guess any
> work around would be a pretty terrible cludge. I'll roll these two patches
> back together and otherwise we will end up with something even less coherent.
OK, thanks guys.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next:als tree build failure
2010-01-28 12:17 ` Stephen Rothwell
@ 2010-01-28 12:33 ` Jonathan Cameron
2010-01-28 12:45 ` Jean Delvare
0 siblings, 1 reply; 6+ messages in thread
From: Jonathan Cameron @ 2010-01-28 12:33 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Jean Delvare, Zhang Rui, linux-next, linux-kernel
On 01/28/10 12:17, Stephen Rothwell wrote:
> Hi Jonathan, Jean,
>
> On Thu, 28 Jan 2010 11:59:37 +0000 Jonathan Cameron <jic23@cam.ac.uk> wrote:
>>
>> It does make sense to keep these two steps separate. Ah well, I guess any
>> work around would be a pretty terrible cludge. I'll roll these two patches
>> back together and otherwise we will end up with something even less coherent.
>
> OK, thanks guys.
>
Everything should now be fixed in the als tree. New version of the move commit
cleans out the i2c/chips directory and changes the i2c/Makefile and i2c/Kconfig
appropriately. Only remaining related elements are the debug Kconfig option for
i2c/chips but that can definitely go through the i2c tree rather than als (if there
are no other users) and shouldn't break any builds.
Thanks,
Jonathan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next:als tree build failure
2010-01-28 12:33 ` Jonathan Cameron
@ 2010-01-28 12:45 ` Jean Delvare
0 siblings, 0 replies; 6+ messages in thread
From: Jean Delvare @ 2010-01-28 12:45 UTC (permalink / raw)
To: Jonathan Cameron; +Cc: Stephen Rothwell, Zhang Rui, linux-next, linux-kernel
On Thu, 28 Jan 2010 12:33:22 +0000, Jonathan Cameron wrote:
> On 01/28/10 12:17, Stephen Rothwell wrote:
> > Hi Jonathan, Jean,
> >
> > On Thu, 28 Jan 2010 11:59:37 +0000 Jonathan Cameron <jic23@cam.ac.uk> wrote:
> >>
> >> It does make sense to keep these two steps separate. Ah well, I guess any
> >> work around would be a pretty terrible cludge. I'll roll these two patches
> >> back together and otherwise we will end up with something even less coherent.
> >
> > OK, thanks guys.
> >
> Everything should now be fixed in the als tree. New version of the move commit
> cleans out the i2c/chips directory and changes the i2c/Makefile and i2c/Kconfig
> appropriately. Only remaining related elements are the debug Kconfig option for
> i2c/chips but that can definitely go through the i2c tree rather than als (if there
> are no other users) and shouldn't break any builds.
I'll take care of the debug option later, no problem.
--
Jean Delvare
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-01-28 12:45 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-28 7:23 linux-next:als tree build failure Stephen Rothwell
2010-01-28 7:41 ` Jean Delvare
2010-01-28 11:59 ` Jonathan Cameron
2010-01-28 12:17 ` Stephen Rothwell
2010-01-28 12:33 ` Jonathan Cameron
2010-01-28 12:45 ` Jean Delvare
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox