* linux-next: build failure after merge final merge
@ 2010-02-16 7:36 Stephen Rothwell
2010-02-16 16:36 ` Jesse Barnes
2010-02-16 17:03 ` Bjorn Helgaas
0 siblings, 2 replies; 6+ messages in thread
From: Stephen Rothwell @ 2010-02-16 7:36 UTC (permalink / raw)
To: Jesse Barnes; +Cc: linux-next, linux-kernel, Bjorn Helgaas, David Miller
[-- Attachment #1: Type: text/plain, Size: 2658 bytes --]
Hi Jesse,
After merging, today's linux-next build (sparc64 defconfig) failed like
this:
arch/sparc/kernel/pci.c: In function 'pci_cfg_fake_ranges':
arch/sparc/kernel/pci.c:404: error: 'struct pci_bus' has no member named 'resource'
arch/sparc/kernel/pci.c:419: error: 'struct pci_bus' has no member named 'resource'
arch/sparc/kernel/pci.c:450: error: 'struct pci_bus' has no member named 'resource'
arch/sparc/kernel/pci.c: In function 'apb_fake_ranges':
arch/sparc/kernel/pci.c:473: error: 'struct pci_bus' has no member named 'resource'
arch/sparc/kernel/pci.c:481: error: 'struct pci_bus' has no member named 'resource'
arch/sparc/kernel/pci.c: In function 'of_scan_pci_bridge':
arch/sparc/kernel/pci.c:539: error: 'struct pci_bus' has no member named 'resource'
arch/sparc/kernel/pci.c:558: error: 'struct pci_bus' has no member named 'resource'
arch/sparc/kernel/pci.c:571: error: 'struct pci_bus' has no member named 'resource'
arch/sparc/kernel/pci.c: In function 'pci_scan_one_pbm':
arch/sparc/kernel/pci.c:693: error: 'struct pci_bus' has no member named 'resource'
arch/sparc/kernel/pci.c:694: error: 'struct pci_bus' has no member named 'resource'
arch/sparc/kernel/pci.c: In function 'pcibios_fixup_bus':
arch/sparc/kernel/pci.c:710: error: 'struct pci_bus' has no member named 'resource'
arch/sparc/kernel/pci.c:711: error: 'struct pci_bus' has no member named 'resource'
Cause by commit 94a8887c501b22a2818ee58197864e9eab983510 ("PCI: replace
bus resource table with a list") from the pci tree. I don't know why I
didn't notice this failure yesterday.
I have reverted that commit and the following 4 commits from the pci tree
for today:
6b673390ae99fbaeeafc40a6e42ba97e1beada0b "x86/PCI: use host bridge _CRS
info by default on 2008 and newer machines"
6776104e550aa6600549e204865cb3d4ed29e04e "PCI: make disabled window
printk style match the enabled ones"
a0266ed60a7ac8ce5c97d860cd927ba542325cb4 "PCI: break out
primary/secondary/subordinate for readability"
0c2a8aaaba0d1a16a468cf48ba2fec6139d20a66 "PCI: reference bridge window
resources explicitly"
Jesse, can you please remove these commits from the pci tree until the
above problem is fixed.
OK, I just checked the build results for last night
(http://kisskb.ellerman.id.au/kisskb/head/2579/) and there are quite a few
more (alpha, some arm, parisc and more ...) ... please fix them up as
well. Try something like:
git grep -l -w resource $(git grep -l -w 'struct pci_bus')
for a starting list of files to check.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: build failure after merge final merge
2010-02-16 7:36 linux-next: build failure after merge final merge Stephen Rothwell
@ 2010-02-16 16:36 ` Jesse Barnes
2010-02-16 17:05 ` Bjorn Helgaas
2010-02-16 17:03 ` Bjorn Helgaas
1 sibling, 1 reply; 6+ messages in thread
From: Jesse Barnes @ 2010-02-16 16:36 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Bjorn Helgaas, David Miller
On Tue, 16 Feb 2010 18:36:50 +1100
Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Jesse,
>
> After merging, today's linux-next build (sparc64 defconfig) failed
> like this:
>
> arch/sparc/kernel/pci.c: In function 'pci_cfg_fake_ranges':
> arch/sparc/kernel/pci.c:404: error: 'struct pci_bus' has no member
> named 'resource' arch/sparc/kernel/pci.c:419: error: 'struct pci_bus'
> has no member named 'resource' arch/sparc/kernel/pci.c:450: error:
> 'struct pci_bus' has no member named 'resource'
> arch/sparc/kernel/pci.c: In function 'apb_fake_ranges':
> arch/sparc/kernel/pci.c:473: error: 'struct pci_bus' has no member
> named 'resource' arch/sparc/kernel/pci.c:481: error: 'struct pci_bus'
> has no member named 'resource' arch/sparc/kernel/pci.c: In function
> 'of_scan_pci_bridge': arch/sparc/kernel/pci.c:539: error: 'struct
> pci_bus' has no member named 'resource' arch/sparc/kernel/pci.c:558:
> error: 'struct pci_bus' has no member named 'resource'
> arch/sparc/kernel/pci.c:571: error: 'struct pci_bus' has no member
> named 'resource' arch/sparc/kernel/pci.c: In function
> 'pci_scan_one_pbm': arch/sparc/kernel/pci.c:693: error: 'struct
> pci_bus' has no member named 'resource' arch/sparc/kernel/pci.c:694:
> error: 'struct pci_bus' has no member named 'resource'
> arch/sparc/kernel/pci.c: In function 'pcibios_fixup_bus':
> arch/sparc/kernel/pci.c:710: error: 'struct pci_bus' has no member
> named 'resource' arch/sparc/kernel/pci.c:711: error: 'struct pci_bus'
> has no member named 'resource'
>
> Cause by commit 94a8887c501b22a2818ee58197864e9eab983510 ("PCI:
> replace bus resource table with a list") from the pci tree. I don't
> know why I didn't notice this failure yesterday.
>
> I have reverted that commit and the following 4 commits from the pci
> tree for today:
>
> 6b673390ae99fbaeeafc40a6e42ba97e1beada0b "x86/PCI: use host bridge
> _CRS info by default on 2008 and newer machines"
> 6776104e550aa6600549e204865cb3d4ed29e04e "PCI: make disabled window
> printk style match the enabled ones"
> a0266ed60a7ac8ce5c97d860cd927ba542325cb4 "PCI: break out
> primary/secondary/subordinate for readability"
> 0c2a8aaaba0d1a16a468cf48ba2fec6139d20a66 "PCI: reference bridge window
> resources explicitly"
>
> Jesse, can you please remove these commits from the pci tree until the
> above problem is fixed.
>
> OK, I just checked the build results for last night
> (http://kisskb.ellerman.id.au/kisskb/head/2579/) and there are quite
> a few more (alpha, some arm, parisc and more ...) ... please fix them
> up as well. Try something like:
>
> git grep -l -w resource $(git grep -l -w 'struct pci_bus')
>
> for a starting list of files to check.
Arg I thought we had fixed this one; maybe I applied an old patchset...
Bjorn?
Thanks,
--
Jesse Barnes, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: build failure after merge final merge
2010-02-16 7:36 linux-next: build failure after merge final merge Stephen Rothwell
2010-02-16 16:36 ` Jesse Barnes
@ 2010-02-16 17:03 ` Bjorn Helgaas
2010-02-16 17:41 ` Bjorn Helgaas
1 sibling, 1 reply; 6+ messages in thread
From: Bjorn Helgaas @ 2010-02-16 17:03 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Jesse Barnes, linux-next, linux-kernel, David Miller
On Tuesday 16 February 2010 12:36:50 am Stephen Rothwell wrote:
> After merging, today's linux-next build (sparc64 defconfig) failed like
> this:
>
> arch/sparc/kernel/pci.c: In function 'pci_cfg_fake_ranges':
> arch/sparc/kernel/pci.c:404: error: 'struct pci_bus' has no member named 'resource'
Huh. I built sparc64 defconfig (and alpha, arm, i686, ia64, mips,
powerpc, sh, and sparc) in Jesse's linux-next branch, but obviously
that's not doing the right thing for some reason.
> OK, I just checked the build results for last night
> (http://kisskb.ellerman.id.au/kisskb/head/2579/) and there are quite a few
> more (alpha, some arm, parisc and more ...) ... please fix them up as
> well. Try something like:
>
> git grep -l -w resource $(git grep -l -w 'struct pci_bus')
>
> for a starting list of files to check.
Thanks for the specifics about all the failures. That will help
me a lot. And thanks for the git grep magic. I've clearly been
missing out on a very useful tool.
Bjorn
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: build failure after merge final merge
2010-02-16 16:36 ` Jesse Barnes
@ 2010-02-16 17:05 ` Bjorn Helgaas
0 siblings, 0 replies; 6+ messages in thread
From: Bjorn Helgaas @ 2010-02-16 17:05 UTC (permalink / raw)
To: Jesse Barnes; +Cc: Stephen Rothwell, linux-next, linux-kernel, David Miller
On Tuesday 16 February 2010 09:36:51 am Jesse Barnes wrote:
> On Tue, 16 Feb 2010 18:36:50 +1100
> Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> > Hi Jesse,
> >
> > After merging, today's linux-next build (sparc64 defconfig) failed
> > like this:
> >
> > arch/sparc/kernel/pci.c: In function 'pci_cfg_fake_ranges':
> > arch/sparc/kernel/pci.c:404: error: 'struct pci_bus' has no member
> Arg I thought we had fixed this one; maybe I applied an old patchset...
> Bjorn?
Nope, my patch doesn't touch that file, so I missed it (and a bunch
of others, it looks like).
Bjorn
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: build failure after merge final merge
2010-02-16 17:03 ` Bjorn Helgaas
@ 2010-02-16 17:41 ` Bjorn Helgaas
2010-02-16 23:09 ` Stephen Rothwell
0 siblings, 1 reply; 6+ messages in thread
From: Bjorn Helgaas @ 2010-02-16 17:41 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Jesse Barnes, linux-next, linux-kernel, David Miller
On Tuesday 16 February 2010 10:03:29 am Bjorn Helgaas wrote:
> On Tuesday 16 February 2010 12:36:50 am Stephen Rothwell wrote:
> > After merging, today's linux-next build (sparc64 defconfig) failed like
> > this:
> >
> > arch/sparc/kernel/pci.c: In function 'pci_cfg_fake_ranges':
> > arch/sparc/kernel/pci.c:404: error: 'struct pci_bus' has no member named 'resource'
>
> Huh. I built sparc64 defconfig (and alpha, arm, i686, ia64, mips,
> powerpc, sh, and sparc) in Jesse's linux-next branch, but obviously
> that's not doing the right thing for some reason.
BTW, do you have cross-compilers for all those targets? It'd be great
if they were all available somewhere. My set is incomplete and getting
old.
Bjorn
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: build failure after merge final merge
2010-02-16 17:41 ` Bjorn Helgaas
@ 2010-02-16 23:09 ` Stephen Rothwell
0 siblings, 0 replies; 6+ messages in thread
From: Stephen Rothwell @ 2010-02-16 23:09 UTC (permalink / raw)
To: Bjorn Helgaas; +Cc: Jesse Barnes, linux-next, linux-kernel, David Miller
[-- Attachment #1: Type: text/plain, Size: 530 bytes --]
Hi Bjorn,
On Tue, 16 Feb 2010 10:41:55 -0700 Bjorn Helgaas <bjorn.helgaas@hp.com> wrote:
>
> BTW, do you have cross-compilers for all those targets? It'd be great
> if they were all available somewhere. My set is incomplete and getting
> old.
There are various cross-compilers (x86 hosted) available at
http://bakeyournoodle.com/cross/ . These are only good for building
kernels as they have no libc stuff.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-02-16 23:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-16 7:36 linux-next: build failure after merge final merge Stephen Rothwell
2010-02-16 16:36 ` Jesse Barnes
2010-02-16 17:05 ` Bjorn Helgaas
2010-02-16 17:03 ` Bjorn Helgaas
2010-02-16 17:41 ` Bjorn Helgaas
2010-02-16 23:09 ` Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox