From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Narendra_K@Dell.com
Cc: linux-kernel@vger.kernel.org, linux-next@vger.kernel.org,
sfr@canb.auug.org.au, Matt_Domsch@Dell.com,
Charles_Rose@Dell.com, Surya_Prabhakar@Dell.com
Subject: Re: CONFIG_NLS=m resulting in undefined reference to utf16s_to_utf8s causing build failure
Date: Wed, 12 Jan 2011 16:02:29 -0800 [thread overview]
Message-ID: <20110112160229.7b8d82c1@jbarnes-desktop> (raw)
In-Reply-To: <20110112203414.GA5657@fedora14-r610.oslab.blr.amer.dell.com>
On Wed, 12 Jan 2011 12:10:17 -0800
<Narendra_K@Dell.com> wrote:
> Hello,
>
> As described in the post http://marc.info/?l=linux-next&m=129478755528194&w=2
> setting CONFIG_NLS=m (generated by 'make allmodconfig) is causing a build
> failure on linux-next as following while compiling the patch
> http://marc.info/?l=linux-pci&m=129313294112736&w=1 ([PATCH V2] Export
> ACPI _DSM provided firmware instance number and string to sysfs)
>
> drivers/built-in.o: In function `dsm_label_utf16s_to_utf8s':
> /usr/src/Linux-Next/linux-next/drivers/pci/pci-label.c:195: undefined reference to `utf16s_to_utf8s'
> make: *** [.tmp_vmlinux1] Error 1
>
> The drivers/pci/pci-label.c is compiled as part of vmlinux as defined by
> the makefile drivers/pci/Makefile.
>
> #
> # ACPI Related PCI FW Functions
> # ACPI _DSM provided firmware instance and string name
> #
> obj-$(CONFIG_ACPI) += pci-acpi.o pci-label.o
>
> # SMBIOS provided firmware instance and labels
> obj-$(CONFIG_DMI) += pci-label.o
>
> This could be prevented by one of the following methods -
>
> * forcing CONFIG_NLS=y if CONFIG_PCI=y
> * move `utf16s_to_utf8s' out of nls_base.c to a new file to be always
> built into vmlinux
>
> Please correct me if i missed something here and let me know what would be the right
> way to fix this build failure.
So there's no other ACPI code that depends on this function? I'd hate
to make PCI depend on NLS, so assuming ACPI doesn't need it (in which
case the select or depend should be there), I guess it should be pulled
into a common file that will always be included.
Thanks,
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2011-01-13 0:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-12 20:10 CONFIG_NLS=m resulting in undefined reference to utf16s_to_utf8s causing build failure Narendra_K
2011-01-13 0:02 ` Jesse Barnes [this message]
2011-01-13 3:23 ` Len Brown
2011-01-13 15:55 ` Jesse Barnes
2011-01-13 16:03 ` Narendra_K
2011-01-14 15:22 ` [PATCH] Fix build failure when CONFIG_NLS is set to 'm' by allmodconfig Narendra_K
2011-01-14 15:29 ` Sedat Dilek
2011-01-14 16:06 ` Narendra_K
2011-01-14 21:09 ` Stephen Rothwell
2011-01-17 19:28 ` Narendra_K
2011-01-20 18:41 ` Narendra_K
2011-01-28 15:30 ` Narendra_K
2011-01-28 16:45 ` Jesse Barnes
2011-02-01 16:28 ` Narendra_K
2011-02-01 16:59 ` Narendra_K
2011-01-14 17:14 ` CONFIG_NLS=m resulting in undefined reference to utf16s_to_utf8s causing build failure Jesse Barnes
2011-01-13 16:46 ` Narendra_K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110112160229.7b8d82c1@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=Charles_Rose@Dell.com \
--cc=Matt_Domsch@Dell.com \
--cc=Narendra_K@Dell.com \
--cc=Surya_Prabhakar@Dell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox