From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Narendra_K@Dell.com
Cc: sfr@canb.auug.org.au, lenb@kernel.org,
linux-kernel@vger.kernel.org, linux-next@vger.kernel.org,
Matt_Domsch@Dell.com, Charles_Rose@Dell.com,
Surya_Prabhakar@Dell.com
Subject: Re: [PATCH] Fix build failure when CONFIG_NLS is set to 'm' by allmodconfig
Date: Fri, 28 Jan 2011 08:45:18 -0800 [thread overview]
Message-ID: <20110128084518.7783091e@jbarnes-desktop> (raw)
In-Reply-To: <20110128155337.GA27642@fedora14-r610.oslab.blr.amer.dell.com>
On Fri, 28 Jan 2011 07:30:36 -0800
<Narendra_K@Dell.com> wrote:
> On Fri, Jan 21, 2011 at 12:11:50AM +0530, K, Narendra wrote:
> > On Tue, Jan 18, 2011 at 12:58:48AM +0530, K, Narendra wrote:
> > > On Sat, Jan 15, 2011 at 02:39:49AM +0530, Stephen Rothwell wrote:
> > > > Hi Narendra,
> > > >
> > > > On Fri, 14 Jan 2011 20:52:42 +0530 <Narendra_K@Dell.com> wrote:
> > > > >
> > > > > This patch addresses the build failure described in this thread by
> > > > > compiling fs/nls/nls_base.c always into vmlinux, thus making the base
> > > > > nls functions available always.
> > > >
> > > > Even on platforms that don't support ACPI or DMI ...
> > > >
> > > > You should really restrict this to CONFIG_ACPI || CONFIG_DMI ||
> > > > CONFIG_NLS ... maybe create a CONFIG_NLS_BASE that is selected by ACPI,
> > > > DMI and NLS?
> > >
> > > Hi Stephen,
> > >
> > > Thank you for the suggestions.
> > >
> > > I agree with your suggestion that we should compile nls_base.o
> > > conditionally, only when ACPI || DMI || NLS. I have introduced a bew
> > > config option CONFIG_NLS_BASE and made ACPI, DMI and NLS select it.
> > >
> > > V1 -> V2:
> > >
> > > 1. Conditionally compile fs/nls/nls_base.c by introducing a new config
> > > option CONFIG_NLS_BASE, which is selected by (ACPI || DMI || NLS).
> > > Behavior of the rest of the files under fs/nls is not changed.
> > >
> > > From: Narendra K <narendra_k@dell.com>
> > > Subject: [PATCH V2] Fix build failure when CONFIG_NLS is set to 'm' by allmodconfig
> >
> > Hi,
> >
> > Please let me know if there are any concerns with Version 2 of the patch.
> > If it looks good please consider it for inclusion.
>
> Hi Jesse,
>
> Please let me know if there are any concerns with this patch. If it is
> acceptable, please consider this for inclusion.
I think the fs stuff will have to get an ack from Al. If he doesn't
like it, see my earlier mail for another suggestion.
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2011-01-28 16:45 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-12 20:10 CONFIG_NLS=m resulting in undefined reference to utf16s_to_utf8s causing build failure Narendra_K
2011-01-13 0:02 ` Jesse Barnes
2011-01-13 3:23 ` Len Brown
2011-01-13 15:55 ` Jesse Barnes
2011-01-13 16:03 ` Narendra_K
2011-01-14 15:22 ` [PATCH] Fix build failure when CONFIG_NLS is set to 'm' by allmodconfig Narendra_K
2011-01-14 15:29 ` Sedat Dilek
2011-01-14 16:06 ` Narendra_K
2011-01-14 21:09 ` Stephen Rothwell
2011-01-17 19:28 ` Narendra_K
2011-01-20 18:41 ` Narendra_K
2011-01-28 15:30 ` Narendra_K
2011-01-28 16:45 ` Jesse Barnes [this message]
2011-02-01 16:28 ` Narendra_K
2011-02-01 16:59 ` Narendra_K
2011-01-14 17:14 ` CONFIG_NLS=m resulting in undefined reference to utf16s_to_utf8s causing build failure Jesse Barnes
2011-01-13 16:46 ` Narendra_K
-- strict thread matches above, loose matches on Subject: below --
2011-02-23 12:54 [PATCH] Fix build failure when CONFIG_NLS is set to 'm' by allmodconfig Narendra_K
2011-02-23 13:17 ` Matthew Garrett
2011-03-04 18:15 ` Jesse Barnes
2011-03-28 15:02 ` Randy Dunlap
2011-03-28 16:17 ` Jesse Barnes
2011-03-28 19:14 ` Shyam_Iyer
2011-03-28 20:22 ` Randy Dunlap
2011-03-29 1:55 ` OGAWA Hirofumi
2011-03-29 16:18 ` Randy Dunlap
2011-03-29 16:23 ` Jesse Barnes
2011-03-29 16:39 ` OGAWA Hirofumi
2011-04-19 6:06 ` Ingo Molnar
2011-04-19 8:43 ` Narendra_K
2011-04-19 16:25 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110128084518.7783091e@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=Charles_Rose@Dell.com \
--cc=Matt_Domsch@Dell.com \
--cc=Narendra_K@Dell.com \
--cc=Surya_Prabhakar@Dell.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox