linux-next: build warning after merge of the rpmsg tree

linux-next: build warning after merge of the rpmsg tree

[Stephen Rothwell]

Hi Bjorn,

After merging the rpmsg tree, today's linux-next build
(arm_multi_v7_defconfig) produced this warning:

drivers/i2c/Kconfig:7:error: recursive dependency detected!
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/i2c/Kconfig:7:	symbol I2C is selected by FB_DDC
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/video/fbdev/Kconfig:63:	symbol FB_DDC is selected by FB_CYBER2000_DDC
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/video/fbdev/Kconfig:390:	symbol FB_CYBER2000_DDC depends on FB_CYBER2000
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/video/fbdev/Kconfig:378:	symbol FB_CYBER2000 depends on FB
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/video/fbdev/Kconfig:5:	symbol FB is selected by DRM_KMS_FB_HELPER
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/gpu/drm/Kconfig:72:	symbol DRM_KMS_FB_HELPER depends on DRM_KMS_HELPER
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/gpu/drm/Kconfig:66:	symbol DRM_KMS_HELPER is selected by DRM_VIRTIO_GPU
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/gpu/drm/virtio/Kconfig:1:	symbol DRM_VIRTIO_GPU depends on VIRTIO
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/virtio/Kconfig:1:	symbol VIRTIO is selected by RPMSG_VIRTIO
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/rpmsg/Kconfig:35:	symbol RPMSG_VIRTIO is selected by KEYSTONE_REMOTEPROC
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/remoteproc/Kconfig:74:	symbol KEYSTONE_REMOTEPROC depends on RESET_CONTROLLER
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/reset/Kconfig:4:	symbol RESET_CONTROLLER is selected by QCOM_SCM
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/firmware/Kconfig:205:	symbol QCOM_SCM is selected by VIDEO_QCOM_VENUS
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/media/platform/Kconfig:474:	symbol VIDEO_QCOM_VENUS depends on V4L_MEM2MEM_DRIVERS
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/media/platform/Kconfig:162:	symbol V4L_MEM2MEM_DRIVERS depends on VIDEO_V4L2
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/media/v4l2-core/Kconfig:6:	symbol VIDEO_V4L2 depends on I2C

and more ...

Probably introduced by commit

  e88bb8f7a12c ("remoteproc/keystone: Add a remoteproc driver for Keystone 2 DSPs")

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the rpmsg tree

[Bjorn Andersson]

On Mon 26 Jun 21:43 PDT 2017, Stephen Rothwell wrote:

> Hi Bjorn,
> 
> After merging the rpmsg tree, today's linux-next build
> (arm_multi_v7_defconfig) produced this warning:
> 
> drivers/i2c/Kconfig:7:error: recursive dependency detected!

Thanks Stephen, I've updated the branch to work around the two issues
you found.

Regards,
Bjorn

linux-next: build warning after merge of the rpmsg tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 495 bytes --]

Hi all,

After merging the rpmsg tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

WARNING: unmet direct dependencies detected for OMAP2PLUS_MBOX
  Depends on [n]: MAILBOX [=y] && (ARCH_OMAP2PLUS || ARCH_K3)
  Selected by [m]:
  - TI_K3_M4_REMOTEPROC [=m] && REMOTEPROC [=y] && (ARCH_K3 || COMPILE_TEST [=y])

Probably introduced by commit

  ebcf9008a895 ("remoteproc: k3-m4: Add a remoteproc driver for M4F subsystem")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the rpmsg tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 638 bytes --]

Hi all,

On Thu, 22 Aug 2024 14:26:03 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the rpmsg tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> WARNING: unmet direct dependencies detected for OMAP2PLUS_MBOX
>   Depends on [n]: MAILBOX [=y] && (ARCH_OMAP2PLUS || ARCH_K3)
>   Selected by [m]:
>   - TI_K3_M4_REMOTEPROC [=m] && REMOTEPROC [=y] && (ARCH_K3 || COMPILE_TEST [=y])
> 
> Probably introduced by commit
> 
>   ebcf9008a895 ("remoteproc: k3-m4: Add a remoteproc driver for M4F subsystem")

I am still seeing this warning.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the rpmsg tree

[Martyn Welch]

On Wed, 2024-08-28 at 15:09 +1000, Stephen Rothwell wrote:
> Hi all,
> 
> On Thu, 22 Aug 2024 14:26:03 +1000 Stephen Rothwell
> <sfr@canb.auug.org.au> wrote:
> > 
> > After merging the rpmsg tree, today's linux-next build (x86_64
> > allmodconfig) produced this warning:
> > 
> > WARNING: unmet direct dependencies detected for OMAP2PLUS_MBOX
> >   Depends on [n]: MAILBOX [=y] && (ARCH_OMAP2PLUS || ARCH_K3)
> >   Selected by [m]:
> >   - TI_K3_M4_REMOTEPROC [=m] && REMOTEPROC [=y] && (ARCH_K3 ||
> > COMPILE_TEST [=y])
> > 
> > Probably introduced by commit
> > 
> >   ebcf9008a895 ("remoteproc: k3-m4: Add a remoteproc driver for M4F
> > subsystem")
> 
> I am still seeing this warning.
> 

OK, just taken a look into this. I think the issue is the result of the
inclusion of `COMPILE_TEST` in the Kconfig entry:

  config TI_K3_M4_REMOTEPROC
         tristate "TI K3 M4 remoteproc support"
         depends on ARCH_K3 || COMPILE_TEST
         select MAILBOX
         select OMAP2PLUS_MBOX
  ...

Looking at the entry for `OMAP2PLUS_MBOX`, that doesn't have
`COMPILE_TEST` listed under it's dependencies:

  config OMAP2PLUS_MBOX
          tristate "OMAP2+ Mailbox framework support"
          depends on ARCH_OMAP2PLUS || ARCH_K3
  ...

If I understand right, either the `COMPILE_TEST` needs to be removed
from `TI_K3_M4_REMOTEPROC` or added to `OMAP2PLUS_MBOX`.

It appears that the OMAP2+ Mailbox support can at least be compiled on
x86_64. so I assume the correct thing to do here is to enable that
right?

Jassi, I assume there's not specific reason for the OMAP2+ Mailbox
framework support not having `COMPILE_TEST`, other than potentially
being added just before it was a thing?

Martyn

Re: linux-next: build warning after merge of the rpmsg tree

[Jassi Brar]

On Wed, Aug 28, 2024 at 4:45 AM Martyn Welch <martyn.welch@collabora.com> wrote:
>
> On Wed, 2024-08-28 at 15:09 +1000, Stephen Rothwell wrote:
> > Hi all,
> >
> > On Thu, 22 Aug 2024 14:26:03 +1000 Stephen Rothwell
> > <sfr@canb.auug.org.au> wrote:
> > >
> > > After merging the rpmsg tree, today's linux-next build (x86_64
> > > allmodconfig) produced this warning:
> > >
> > > WARNING: unmet direct dependencies detected for OMAP2PLUS_MBOX
> > >   Depends on [n]: MAILBOX [=y] && (ARCH_OMAP2PLUS || ARCH_K3)
> > >   Selected by [m]:
> > >   - TI_K3_M4_REMOTEPROC [=m] && REMOTEPROC [=y] && (ARCH_K3 ||
> > > COMPILE_TEST [=y])
> > >
> > > Probably introduced by commit
> > >
> > >   ebcf9008a895 ("remoteproc: k3-m4: Add a remoteproc driver for M4F
> > > subsystem")
> >
> > I am still seeing this warning.
> >
>
> OK, just taken a look into this. I think the issue is the result of the
> inclusion of `COMPILE_TEST` in the Kconfig entry:
>
>   config TI_K3_M4_REMOTEPROC
>          tristate "TI K3 M4 remoteproc support"
>          depends on ARCH_K3 || COMPILE_TEST
>          select MAILBOX
>          select OMAP2PLUS_MBOX
>   ...
>
> Looking at the entry for `OMAP2PLUS_MBOX`, that doesn't have
> `COMPILE_TEST` listed under it's dependencies:
>
>   config OMAP2PLUS_MBOX
>           tristate "OMAP2+ Mailbox framework support"
>           depends on ARCH_OMAP2PLUS || ARCH_K3
>   ...
>
> If I understand right, either the `COMPILE_TEST` needs to be removed
> from `TI_K3_M4_REMOTEPROC` or added to `OMAP2PLUS_MBOX`.
>
> It appears that the OMAP2+ Mailbox support can at least be compiled on
> x86_64. so I assume the correct thing to do here is to enable that
> right?
>
> Jassi, I assume there's not specific reason for the OMAP2+ Mailbox
> framework support not having `COMPILE_TEST`, other than potentially
> being added just before it was a thing?
>
Seems like it.

-j

Re: linux-next: build warning after merge of the rpmsg tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 792 bytes --]

Hi all,

On Wed, 28 Aug 2024 15:09:00 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Thu, 22 Aug 2024 14:26:03 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > After merging the rpmsg tree, today's linux-next build (x86_64
> > allmodconfig) produced this warning:
> > 
> > WARNING: unmet direct dependencies detected for OMAP2PLUS_MBOX
> >   Depends on [n]: MAILBOX [=y] && (ARCH_OMAP2PLUS || ARCH_K3)
> >   Selected by [m]:
> >   - TI_K3_M4_REMOTEPROC [=m] && REMOTEPROC [=y] && (ARCH_K3 || COMPILE_TEST [=y])
> > 
> > Probably introduced by commit
> > 
> >   ebcf9008a895 ("remoteproc: k3-m4: Add a remoteproc driver for M4F subsystem")  
> 
> I am still seeing this warning.

I am still getting this warning.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the rpmsg tree

[Martyn Welch]

On Fri, 2024-09-06 at 18:36 +1000, Stephen Rothwell wrote:
> Hi all,
> 
> On Wed, 28 Aug 2024 15:09:00 +1000 Stephen Rothwell
> <sfr@canb.auug.org.au> wrote:
> > 
> > On Thu, 22 Aug 2024 14:26:03 +1000 Stephen Rothwell
> > <sfr@canb.auug.org.au> wrote:
> > > 
> > > After merging the rpmsg tree, today's linux-next build (x86_64
> > > allmodconfig) produced this warning:
> > > 
> > > WARNING: unmet direct dependencies detected for OMAP2PLUS_MBOX
> > >   Depends on [n]: MAILBOX [=y] && (ARCH_OMAP2PLUS || ARCH_K3)
> > >   Selected by [m]:
> > >   - TI_K3_M4_REMOTEPROC [=m] && REMOTEPROC [=y] && (ARCH_K3 ||
> > > COMPILE_TEST [=y])
> > > 
> > > Probably introduced by commit
> > > 
> > >   ebcf9008a895 ("remoteproc: k3-m4: Add a remoteproc driver for
> > > M4F subsystem")  
> > 
> > I am still seeing this warning.
> 
> I am still getting this warning.
> 

Hi Stephen,

I believe this is the required fix, but I believe it's waiting for
review/merging:

https://lore.kernel.org/all/010201919d8b298f-dd1585dd-7c4d-4865-9483-ff6cd7399a90-000000@eu-west-1.amazonses.com/

Martyn

Re: linux-next: build warning after merge of the rpmsg tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1289 bytes --]

Hi all,

On Fri, 06 Sep 2024 09:58:23 +0100 Martyn Welch <martyn.welch@collabora.com> wrote:
>
> On Fri, 2024-09-06 at 18:36 +1000, Stephen Rothwell wrote:
> > 
> > On Wed, 28 Aug 2024 15:09:00 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:  
> > > 
> > > On Thu, 22 Aug 2024 14:26:03 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:  
> > > > 
> > > > After merging the rpmsg tree, today's linux-next build (x86_64
> > > > allmodconfig) produced this warning:
> > > > 
> > > > WARNING: unmet direct dependencies detected for OMAP2PLUS_MBOX
> > > >   Depends on [n]: MAILBOX [=y] && (ARCH_OMAP2PLUS || ARCH_K3)
> > > >   Selected by [m]:
> > > >   - TI_K3_M4_REMOTEPROC [=m] && REMOTEPROC [=y] && (ARCH_K3 || COMPILE_TEST [=y])
> > > > 
> > > > Probably introduced by commit
> > > > 
> > > >   ebcf9008a895 ("remoteproc: k3-m4: Add a remoteproc driver for M4F subsystem")    
> > > 
> > > I am still seeing this warning.  
> > 
> > I am still getting this warning.
> 
> I believe this is the required fix, but I believe it's waiting for
> review/merging:
> 
> https://lore.kernel.org/all/010201919d8b298f-dd1585dd-7c4d-4865-9483-ff6cd7399a90-000000@eu-west-1.amazonses.com/

I am still getting this warning.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the rpmsg tree

[Jassi Brar]

On Thu, Sep 12, 2024 at 3:34 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> On Fri, 06 Sep 2024 09:58:23 +0100 Martyn Welch <martyn.welch@collabora.com> wrote:
> >
> > On Fri, 2024-09-06 at 18:36 +1000, Stephen Rothwell wrote:
> > >
> > > On Wed, 28 Aug 2024 15:09:00 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > > >
> > > > On Thu, 22 Aug 2024 14:26:03 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > > > >
> > > > > After merging the rpmsg tree, today's linux-next build (x86_64
> > > > > allmodconfig) produced this warning:
> > > > >
> > > > > WARNING: unmet direct dependencies detected for OMAP2PLUS_MBOX
> > > > >   Depends on [n]: MAILBOX [=y] && (ARCH_OMAP2PLUS || ARCH_K3)
> > > > >   Selected by [m]:
> > > > >   - TI_K3_M4_REMOTEPROC [=m] && REMOTEPROC [=y] && (ARCH_K3 || COMPILE_TEST [=y])
> > > > >
> > > > > Probably introduced by commit
> > > > >
> > > > >   ebcf9008a895 ("remoteproc: k3-m4: Add a remoteproc driver for M4F subsystem")
> > > >
> > > > I am still seeing this warning.
> > >
> > > I am still getting this warning.
> >
> > I believe this is the required fix, but I believe it's waiting for
> > review/merging:
> >
> > https://lore.kernel.org/all/010201919d8b298f-dd1585dd-7c4d-4865-9483-ff6cd7399a90-000000@eu-west-1.amazonses.com/
>
> I am still getting this warning.
>
 This https://lore.kernel.org/lkml/20240909203825.1666947-1-arnd@kernel.org/T/#u
  seems like a more complete solution.

I am ok if it goes through TI or another tree.

Acked-by: Jassi Brar <jassisinghbrar@gmail.com>

Re: linux-next: build warning after merge of the rpmsg tree

[Martyn Welch]

On Thu, 2024-09-12 at 09:15 -0500, Jassi Brar wrote:
> On Thu, Sep 12, 2024 at 3:34 AM Stephen Rothwell
> <sfr@canb.auug.org.au> wrote:
> > 
> > Hi all,
> > 
> > On Fri, 06 Sep 2024 09:58:23 +0100 Martyn Welch
> > <martyn.welch@collabora.com> wrote:
> > > 
> > > On Fri, 2024-09-06 at 18:36 +1000, Stephen Rothwell wrote:
> > > > 
> > > > On Wed, 28 Aug 2024 15:09:00 +1000 Stephen Rothwell
> > > > <sfr@canb.auug.org.au> wrote:
> > > > > 
> > > > > On Thu, 22 Aug 2024 14:26:03 +1000 Stephen Rothwell
> > > > > <sfr@canb.auug.org.au> wrote:
> > > > > > 
> > > > > > After merging the rpmsg tree, today's linux-next build
> > > > > > (x86_64
> > > > > > allmodconfig) produced this warning:
> > > > > > 
> > > > > > WARNING: unmet direct dependencies detected for
> > > > > > OMAP2PLUS_MBOX
> > > > > >   Depends on [n]: MAILBOX [=y] && (ARCH_OMAP2PLUS ||
> > > > > > ARCH_K3)
> > > > > >   Selected by [m]:
> > > > > >   - TI_K3_M4_REMOTEPROC [=m] && REMOTEPROC [=y] && (ARCH_K3
> > > > > > || COMPILE_TEST [=y])
> > > > > > 
> > > > > > Probably introduced by commit
> > > > > > 
> > > > > >   ebcf9008a895 ("remoteproc: k3-m4: Add a remoteproc driver
> > > > > > for M4F subsystem")
> > > > > 
> > > > > I am still seeing this warning.
> > > > 
> > > > I am still getting this warning.
> > > 
> > > I believe this is the required fix, but I believe it's waiting
> > > for
> > > review/merging:
> > > 
> > > https://lore.kernel.org/all/010201919d8b298f-dd1585dd-7c4d-4865-9483-ff6cd7399a90-000000@eu-west-1.amazonses.com/
> > 
> > I am still getting this warning.
> > 
>  This
> https://lore.kernel.org/lkml/20240909203825.1666947-1-arnd@kernel.org/T/#u
>   seems like a more complete solution.
> 
> I am ok if it goes through TI or another tree.
> 
> Acked-by: Jassi Brar <jassisinghbrar@gmail.com>


That solution works for me.

Martyn

Re: linux-next: build warning after merge of the rpmsg tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 791 bytes --]

Hi all,

On Wed, 28 Aug 2024 15:09:00 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Thu, 22 Aug 2024 14:26:03 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > After merging the rpmsg tree, today's linux-next build (x86_64
> > allmodconfig) produced this warning:
> > 
> > WARNING: unmet direct dependencies detected for OMAP2PLUS_MBOX
> >   Depends on [n]: MAILBOX [=y] && (ARCH_OMAP2PLUS || ARCH_K3)
> >   Selected by [m]:
> >   - TI_K3_M4_REMOTEPROC [=m] && REMOTEPROC [=y] && (ARCH_K3 || COMPILE_TEST [=y])
> > 
> > Probably introduced by commit
> > 
> >   ebcf9008a895 ("remoteproc: k3-m4: Add a remoteproc driver for M4F subsystem")  
> 
> I am still seeing this warning.

I am still seeing this warning.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]