* linux-next: build warning after merge of the regmap tree
@ 2017-11-06 0:54 Stephen Rothwell
0 siblings, 0 replies; 6+ messages in thread
From: Stephen Rothwell @ 2017-11-06 0:54 UTC (permalink / raw)
To: Mark Brown; +Cc: Linux-Next Mailing List, Linux Kernel Mailing List
Hi Mark,
After merging the regmap tree, today's linux-next build
(arm_multi_v7_defconfig) produced this warning:
drivers/base/regmap/regmap.c: In function '__regmap_init':
drivers/base/regmap/regmap.c:1121:1: warning: label 'err_map' defined but not used [-Wunused-label]
err_map:
^
Introduced by commit
f25637a6b89e ("regmap: Add a config option for hwspinlock")
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 6+ messages in thread* linux-next: build warning after merge of the regmap tree
@ 2017-11-06 0:52 Stephen Rothwell
2017-11-06 4:21 ` Stephen Rothwell
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2017-11-06 0:52 UTC (permalink / raw)
To: Mark Brown; +Cc: Linux-Next Mailing List, Linux Kernel Mailing List
Hi Mark,
After merging the regmap tree, today's linux-next build
(arm_multi_v7_defconfig) produced this warning:
drivers/gpio/Kconfig:13:error: recursive dependency detected!
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/gpio/Kconfig:13: symbol GPIOLIB is selected by PINCTRL_SUNXI
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/pinctrl/sunxi/Kconfig:3: symbol PINCTRL_SUNXI is selected by PINCTRL_SUN6I_A31_R
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/pinctrl/sunxi/Kconfig:21: symbol PINCTRL_SUN6I_A31_R depends on RESET_CONTROLLER
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/reset/Kconfig:4: symbol RESET_CONTROLLER is selected by QCOM_SCM
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/firmware/Kconfig:205: symbol QCOM_SCM is selected by QCOM_ADSP_PIL
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/remoteproc/Kconfig:90: symbol QCOM_ADSP_PIL depends on QCOM_SMEM
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/soc/qcom/Kconfig:49: symbol QCOM_SMEM depends on HWSPINLOCK
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/hwspinlock/Kconfig:5: symbol HWSPINLOCK is selected by REGMAP
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/base/regmap/Kconfig:6: symbol REGMAP is selected by PINCTRL_SX150X
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/pinctrl/Kconfig:227: symbol PINCTRL_SX150X is selected by GPIO_SX150X
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/gpio/Kconfig:821: symbol GPIO_SX150X depends on GPIOLIB
warning: (ARCH_VEXPRESS) selects MFD_VEXPRESS_SYSREG which has unmet direct dependencies (HAS_IOMEM && VEXPRESS_CONFIG && GPIOLIB && !ARCH_USES_GETTIMEOFFSET)
warning: (ARCH_NOMADIK && ARCH_U8500) selects PINCTRL_NOMADIK which has unmet direct dependencies (PINCTRL && (ARCH_U8500 || ARCH_NOMADIK) && OF && GPIOLIB)
warning: (PINCTRL_AT91 && PINCTRL_AT91PIO4 && PINCTRL_MESON && PINCTRL_OXNAS && PINCTRL_PISTACHIO && PINCTRL_PIC32 && PINCTRL_NOMADIK && PINCTRL_MTK && GPIO_TB10X) selects OF_GPIO which has unmet direct dependencies (GPIOLIB && OF && HAS_IOMEM)
Maybe introduced by commit
f25637a6b89e ("regmap: Add a config option for hwspinlock")
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: linux-next: build warning after merge of the regmap tree
2017-11-06 0:52 Stephen Rothwell
@ 2017-11-06 4:21 ` Stephen Rothwell
2017-11-06 4:30 ` Stephen Rothwell
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2017-11-06 4:21 UTC (permalink / raw)
To: Mark Brown; +Cc: Linux-Next Mailing List, Linux Kernel Mailing List
Hi Mark,
On Mon, 6 Nov 2017 11:52:14 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the regmap tree, today's linux-next build
> (arm_multi_v7_defconfig) produced this warning:
>
> drivers/gpio/Kconfig:13:error: recursive dependency detected!
> For a resolution refer to Documentation/kbuild/kconfig-language.txt
> subsection "Kconfig recursive dependency limitations"
> drivers/gpio/Kconfig:13: symbol GPIOLIB is selected by PINCTRL_SUNXI
> For a resolution refer to Documentation/kbuild/kconfig-language.txt
> subsection "Kconfig recursive dependency limitations"
> drivers/pinctrl/sunxi/Kconfig:3: symbol PINCTRL_SUNXI is selected by PINCTRL_SUN6I_A31_R
> For a resolution refer to Documentation/kbuild/kconfig-language.txt
> subsection "Kconfig recursive dependency limitations"
> drivers/pinctrl/sunxi/Kconfig:21: symbol PINCTRL_SUN6I_A31_R depends on RESET_CONTROLLER
> For a resolution refer to Documentation/kbuild/kconfig-language.txt
> subsection "Kconfig recursive dependency limitations"
> drivers/reset/Kconfig:4: symbol RESET_CONTROLLER is selected by QCOM_SCM
> For a resolution refer to Documentation/kbuild/kconfig-language.txt
> subsection "Kconfig recursive dependency limitations"
> drivers/firmware/Kconfig:205: symbol QCOM_SCM is selected by QCOM_ADSP_PIL
> For a resolution refer to Documentation/kbuild/kconfig-language.txt
> subsection "Kconfig recursive dependency limitations"
> drivers/remoteproc/Kconfig:90: symbol QCOM_ADSP_PIL depends on QCOM_SMEM
> For a resolution refer to Documentation/kbuild/kconfig-language.txt
> subsection "Kconfig recursive dependency limitations"
> drivers/soc/qcom/Kconfig:49: symbol QCOM_SMEM depends on HWSPINLOCK
> For a resolution refer to Documentation/kbuild/kconfig-language.txt
> subsection "Kconfig recursive dependency limitations"
> drivers/hwspinlock/Kconfig:5: symbol HWSPINLOCK is selected by REGMAP
> For a resolution refer to Documentation/kbuild/kconfig-language.txt
> subsection "Kconfig recursive dependency limitations"
> drivers/base/regmap/Kconfig:6: symbol REGMAP is selected by PINCTRL_SX150X
> For a resolution refer to Documentation/kbuild/kconfig-language.txt
> subsection "Kconfig recursive dependency limitations"
> drivers/pinctrl/Kconfig:227: symbol PINCTRL_SX150X is selected by GPIO_SX150X
> For a resolution refer to Documentation/kbuild/kconfig-language.txt
> subsection "Kconfig recursive dependency limitations"
> drivers/gpio/Kconfig:821: symbol GPIO_SX150X depends on GPIOLIB
> warning: (ARCH_VEXPRESS) selects MFD_VEXPRESS_SYSREG which has unmet direct dependencies (HAS_IOMEM && VEXPRESS_CONFIG && GPIOLIB && !ARCH_USES_GETTIMEOFFSET)
> warning: (ARCH_NOMADIK && ARCH_U8500) selects PINCTRL_NOMADIK which has unmet direct dependencies (PINCTRL && (ARCH_U8500 || ARCH_NOMADIK) && OF && GPIOLIB)
> warning: (PINCTRL_AT91 && PINCTRL_AT91PIO4 && PINCTRL_MESON && PINCTRL_OXNAS && PINCTRL_PISTACHIO && PINCTRL_PIC32 && PINCTRL_NOMADIK && PINCTRL_MTK && GPIO_TB10X) selects OF_GPIO which has unmet direct dependencies (GPIOLIB && OF && HAS_IOMEM)
>
> Maybe introduced by commit
>
> f25637a6b89e ("regmap: Add a config option for hwspinlock")
Things got worse during the day until config started segfaulting, so I
reverted this commit.
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: linux-next: build warning after merge of the regmap tree
2017-11-06 4:21 ` Stephen Rothwell
@ 2017-11-06 4:30 ` Stephen Rothwell
2017-11-06 11:21 ` Mark Brown
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2017-11-06 4:30 UTC (permalink / raw)
To: Mark Brown; +Cc: Linux-Next Mailing List, Linux Kernel Mailing List
Hi Mark,
On Mon, 6 Nov 2017 15:21:57 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Mon, 6 Nov 2017 11:52:14 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > After merging the regmap tree, today's linux-next build
> > (arm_multi_v7_defconfig) produced this warning:
> >
> > drivers/gpio/Kconfig:13:error: recursive dependency detected!
> > For a resolution refer to Documentation/kbuild/kconfig-language.txt
> > subsection "Kconfig recursive dependency limitations"
> > drivers/gpio/Kconfig:13: symbol GPIOLIB is selected by PINCTRL_SUNXI
> > For a resolution refer to Documentation/kbuild/kconfig-language.txt
> > subsection "Kconfig recursive dependency limitations"
> > drivers/pinctrl/sunxi/Kconfig:3: symbol PINCTRL_SUNXI is selected by PINCTRL_SUN6I_A31_R
> > For a resolution refer to Documentation/kbuild/kconfig-language.txt
> > subsection "Kconfig recursive dependency limitations"
> > drivers/pinctrl/sunxi/Kconfig:21: symbol PINCTRL_SUN6I_A31_R depends on RESET_CONTROLLER
> > For a resolution refer to Documentation/kbuild/kconfig-language.txt
> > subsection "Kconfig recursive dependency limitations"
> > drivers/reset/Kconfig:4: symbol RESET_CONTROLLER is selected by QCOM_SCM
> > For a resolution refer to Documentation/kbuild/kconfig-language.txt
> > subsection "Kconfig recursive dependency limitations"
> > drivers/firmware/Kconfig:205: symbol QCOM_SCM is selected by QCOM_ADSP_PIL
> > For a resolution refer to Documentation/kbuild/kconfig-language.txt
> > subsection "Kconfig recursive dependency limitations"
> > drivers/remoteproc/Kconfig:90: symbol QCOM_ADSP_PIL depends on QCOM_SMEM
> > For a resolution refer to Documentation/kbuild/kconfig-language.txt
> > subsection "Kconfig recursive dependency limitations"
> > drivers/soc/qcom/Kconfig:49: symbol QCOM_SMEM depends on HWSPINLOCK
> > For a resolution refer to Documentation/kbuild/kconfig-language.txt
> > subsection "Kconfig recursive dependency limitations"
> > drivers/hwspinlock/Kconfig:5: symbol HWSPINLOCK is selected by REGMAP
> > For a resolution refer to Documentation/kbuild/kconfig-language.txt
> > subsection "Kconfig recursive dependency limitations"
> > drivers/base/regmap/Kconfig:6: symbol REGMAP is selected by PINCTRL_SX150X
> > For a resolution refer to Documentation/kbuild/kconfig-language.txt
> > subsection "Kconfig recursive dependency limitations"
> > drivers/pinctrl/Kconfig:227: symbol PINCTRL_SX150X is selected by GPIO_SX150X
> > For a resolution refer to Documentation/kbuild/kconfig-language.txt
> > subsection "Kconfig recursive dependency limitations"
> > drivers/gpio/Kconfig:821: symbol GPIO_SX150X depends on GPIOLIB
> > warning: (ARCH_VEXPRESS) selects MFD_VEXPRESS_SYSREG which has unmet direct dependencies (HAS_IOMEM && VEXPRESS_CONFIG && GPIOLIB && !ARCH_USES_GETTIMEOFFSET)
> > warning: (ARCH_NOMADIK && ARCH_U8500) selects PINCTRL_NOMADIK which has unmet direct dependencies (PINCTRL && (ARCH_U8500 || ARCH_NOMADIK) && OF && GPIOLIB)
> > warning: (PINCTRL_AT91 && PINCTRL_AT91PIO4 && PINCTRL_MESON && PINCTRL_OXNAS && PINCTRL_PISTACHIO && PINCTRL_PIC32 && PINCTRL_NOMADIK && PINCTRL_MTK && GPIO_TB10X) selects OF_GPIO which has unmet direct dependencies (GPIOLIB && OF && HAS_IOMEM)
> >
> > Maybe introduced by commit
> >
> > f25637a6b89e ("regmap: Add a config option for hwspinlock")
>
> Things got worse during the day until config started segfaulting, so I
> reverted this commit.
That necessitated me reverting commits
8698b9364710 ("regmap: Add hardware spinlock support")
267f3e4f18f1 ("regmap: Also protect hwspinlock in error handling path")
e8419c40a5ad ("regmap: Clean up hwspinlock on regmap exit")
as well.
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: linux-next: build warning after merge of the regmap tree
2017-11-06 4:30 ` Stephen Rothwell
@ 2017-11-06 11:21 ` Mark Brown
2017-11-07 6:01 ` Bjorn Andersson
0 siblings, 1 reply; 6+ messages in thread
From: Mark Brown @ 2017-11-06 11:21 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Linux-Next Mailing List, Linux Kernel Mailing List, linux-kbuild,
Yann E. MORIN, linux-remoteproc, Ohad Ben-Cohen, Bjorn Andersson
[-- Attachment #1: Type: text/plain, Size: 4289 bytes --]
On Mon, Nov 06, 2017 at 03:30:37PM +1100, Stephen Rothwell wrote:
> On Mon, 6 Nov 2017 15:21:57 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > On Mon, 6 Nov 2017 11:52:14 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > > After merging the regmap tree, today's linux-next build
> > > (arm_multi_v7_defconfig) produced this warning:
Not snipping Kconfig errors for context, looks like Kconfig is exploding...
> > > drivers/gpio/Kconfig:13:error: recursive dependency detected!
> > > For a resolution refer to Documentation/kbuild/kconfig-language.txt
> > > subsection "Kconfig recursive dependency limitations"
> > > drivers/gpio/Kconfig:13: symbol GPIOLIB is selected by PINCTRL_SUNXI
> > > For a resolution refer to Documentation/kbuild/kconfig-language.txt
> > > subsection "Kconfig recursive dependency limitations"
> > > drivers/pinctrl/sunxi/Kconfig:3: symbol PINCTRL_SUNXI is selected by PINCTRL_SUN6I_A31_R
> > > For a resolution refer to Documentation/kbuild/kconfig-language.txt
> > > subsection "Kconfig recursive dependency limitations"
> > > drivers/pinctrl/sunxi/Kconfig:21: symbol PINCTRL_SUN6I_A31_R depends on RESET_CONTROLLER
> > > For a resolution refer to Documentation/kbuild/kconfig-language.txt
> > > subsection "Kconfig recursive dependency limitations"
> > > drivers/reset/Kconfig:4: symbol RESET_CONTROLLER is selected by QCOM_SCM
> > > For a resolution refer to Documentation/kbuild/kconfig-language.txt
> > > subsection "Kconfig recursive dependency limitations"
> > > drivers/firmware/Kconfig:205: symbol QCOM_SCM is selected by QCOM_ADSP_PIL
> > > For a resolution refer to Documentation/kbuild/kconfig-language.txt
> > > subsection "Kconfig recursive dependency limitations"
> > > drivers/remoteproc/Kconfig:90: symbol QCOM_ADSP_PIL depends on QCOM_SMEM
> > > For a resolution refer to Documentation/kbuild/kconfig-language.txt
> > > subsection "Kconfig recursive dependency limitations"
> > > drivers/soc/qcom/Kconfig:49: symbol QCOM_SMEM depends on HWSPINLOCK
> > > For a resolution refer to Documentation/kbuild/kconfig-language.txt
> > > subsection "Kconfig recursive dependency limitations"
> > > drivers/hwspinlock/Kconfig:5: symbol HWSPINLOCK is selected by REGMAP
> > > For a resolution refer to Documentation/kbuild/kconfig-language.txt
> > > subsection "Kconfig recursive dependency limitations"
> > > drivers/base/regmap/Kconfig:6: symbol REGMAP is selected by PINCTRL_SX150X
> > > For a resolution refer to Documentation/kbuild/kconfig-language.txt
> > > subsection "Kconfig recursive dependency limitations"
> > > drivers/pinctrl/Kconfig:227: symbol PINCTRL_SX150X is selected by GPIO_SX150X
> > > For a resolution refer to Documentation/kbuild/kconfig-language.txt
> > > subsection "Kconfig recursive dependency limitations"
> > > drivers/gpio/Kconfig:821: symbol GPIO_SX150X depends on GPIOLIB
> > > warning: (ARCH_VEXPRESS) selects MFD_VEXPRESS_SYSREG which has unmet direct dependencies (HAS_IOMEM && VEXPRESS_CONFIG && GPIOLIB && !ARCH_USES_GETTIMEOFFSET)
> > > warning: (ARCH_NOMADIK && ARCH_U8500) selects PINCTRL_NOMADIK which has unmet direct dependencies (PINCTRL && (ARCH_U8500 || ARCH_NOMADIK) && OF && GPIOLIB)
> > > warning: (PINCTRL_AT91 && PINCTRL_AT91PIO4 && PINCTRL_MESON && PINCTRL_OXNAS && PINCTRL_PISTACHIO && PINCTRL_PIC32 && PINCTRL_NOMADIK && PINCTRL_MTK && GPIO_TB10X) selects OF_GPIO which has unmet direct dependencies (GPIOLIB && OF && HAS_IOMEM)
> > > Maybe introduced by commit
> > > f25637a6b89e ("regmap: Add a config option for hwspinlock")
> > Things got worse during the day until config started segfaulting, so I
> > reverted this commit.
> That necessitated me reverting commits
> 8698b9364710 ("regmap: Add hardware spinlock support")
> 267f3e4f18f1 ("regmap: Also protect hwspinlock in error handling path")
> e8419c40a5ad ("regmap: Clean up hwspinlock on regmap exit")
This seems like there's a Kconfig bug, it's claiming HWSPINLOCK is
selected by regmap but the select is conditional and not actually
enabled. You could potentially get a recursive dependency but there
isn't one right now. The root issue here is that HWSPINLOCK can be
built modular which makes it very painful to use from core code.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: linux-next: build warning after merge of the regmap tree
2017-11-06 11:21 ` Mark Brown
@ 2017-11-07 6:01 ` Bjorn Andersson
0 siblings, 0 replies; 6+ messages in thread
From: Bjorn Andersson @ 2017-11-07 6:01 UTC (permalink / raw)
To: Mark Brown
Cc: Stephen Rothwell, Linux-Next Mailing List,
Linux Kernel Mailing List, linux-kbuild, Yann E. MORIN,
linux-remoteproc, Ohad Ben-Cohen
On Mon 06 Nov 03:21 PST 2017, Mark Brown wrote:
> On Mon, Nov 06, 2017 at 03:30:37PM +1100, Stephen Rothwell wrote:
> > On Mon, 6 Nov 2017 15:21:57 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > > On Mon, 6 Nov 2017 11:52:14 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> > > > After merging the regmap tree, today's linux-next build
> > > > (arm_multi_v7_defconfig) produced this warning:
>
[..]
> isn't one right now. The root issue here is that HWSPINLOCK can be
> built modular which makes it very painful to use from core code.
I've picked Baolin's patch for making the hwspinlock core bool.
Hopefully this help avoid this issue. Looks like I missed today's
linux-next though.
Regards,
Bjorn
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-11-07 6:01 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-06 0:54 linux-next: build warning after merge of the regmap tree Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2017-11-06 0:52 Stephen Rothwell
2017-11-06 4:21 ` Stephen Rothwell
2017-11-06 4:30 ` Stephen Rothwell
2017-11-06 11:21 ` Mark Brown
2017-11-07 6:01 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox