public inbox for linux-next@vger.kernel.org
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Daniel Borkmann <daniel@iogearbox.net>,
	Alexei Starovoitov <ast@kernel.org>,
	Networking <netdev@vger.kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: Signed-off-by missing for commits in the bpf-next tree
Date: Thu, 13 Dec 2018 09:48:20 +1100	[thread overview]
Message-ID: <20181213094820.62d26354@canb.auug.org.au> (raw)
In-Reply-To: <20181212205253.d3reuxcyjhnwh3ul@ast-mbp.dhcp.thefacebook.com>

[-- Attachment #1: Type: text/plain, Size: 1392 bytes --]

Hi Alexei,

On Wed, 12 Dec 2018 12:53:11 -0800 Alexei Starovoitov <alexei.starovoitov@gmail.com> wrote:
>
> On Thu, Dec 13, 2018 at 07:32:45AM +1100, Stephen Rothwell wrote:
> > Hi all,
> > 
> > Commits
> > 
> >   3bdc28aa2340 ("selftests/bpf: add btf annotations for cgroup_local_storage maps")
> >   1dfd1959fed4 ("bpf: add bpffs pretty print for cgroup local storage maps")
> >   3adc62d9a5be ("bpf: pass struct btf pointer to the map_check_btf() callback")
> >   9cf3a785dc4c ("selftests/bpf: use __bpf_constant_htons in test_prog.c")
> > 
> > are missing a Signed-off-by from their committers.  
> 
> the must be a script mistake?
> 
> I clearly see SOBs for all of them.

For example:

commit 3bdc28aa2340bf1e5af753287b373522bd1c02a9 (bpf-next/master)
Author: Roman Gushchin <guroan@gmail.com>
Date:   Mon Dec 10 15:43:02 2018 -0800

    selftests/bpf: add btf annotations for cgroup_local_storage maps
    
    Add btf annotations to cgroup local storage maps (per-cpu and shared)
    in the network packet counting example.
    
    Signed-off-by: Roman Gushchin <guro@fb.com>
    Cc: Alexei Starovoitov <ast@kernel.org>
    Cc: Daniel Borkmann <daniel@iogearbox.net>
    Acked-by: Martin KaFai Lau <kafai@fb.com>
    Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>

But it was committed by you, not Daniel.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2018-12-12 22:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-12 20:32 linux-next: Signed-off-by missing for commits in the bpf-next tree Stephen Rothwell
2018-12-12 20:53 ` Alexei Starovoitov
2018-12-12 22:48   ` Stephen Rothwell [this message]
2018-12-12 23:39     ` Alexei Starovoitov
2018-12-12 23:45       ` Bart Van Assche
2018-12-13  0:20         ` Alexei Starovoitov
2018-12-13  0:45       ` David Miller
2018-12-13  4:33         ` Alexei Starovoitov
2018-12-13  5:37           ` Stephen Rothwell
2018-12-13  5:45             ` Alexei Starovoitov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181213094820.62d26354@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=alexei.starovoitov@gmail.com \
    --cc=ast@kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox