From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: David Miller <davem@davemloft.net>,
daniel@iogearbox.net, ast@kernel.org, netdev@vger.kernel.org,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: linux-next: Signed-off-by missing for commits in the bpf-next tree
Date: Thu, 13 Dec 2018 16:37:28 +1100 [thread overview]
Message-ID: <20181213163728.037ac535@canb.auug.org.au> (raw)
In-Reply-To: <20181213043339.znj2674c2povyl2n@ast-mbp.dhcp.thefacebook.com>
[-- Attachment #1: Type: text/plain, Size: 760 bytes --]
Hi Alexei,
On Wed, 12 Dec 2018 20:33:41 -0800 Alexei Starovoitov <alexei.starovoitov@gmail.com> wrote:
>
> If Stephen's scripts can recognize SOB anywhere in the log then
> --signoff can theoretically solve it.
My script just grabs all the Signed-off-by lines in the commit message.
> Unfortunately it's "Incompatible with the --interactive option"
> So we have to do things manually
> or fix scripts
> or fix git.
My version (2.19.1 and 2.20.0) of git does not say it is incompatible
with --interactive, so maybe the last is true :-) It says:
Note that
if --interactive is given then only commits marked to be picked,
edited or reworded will have the trailer added.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-12-13 5:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 20:32 linux-next: Signed-off-by missing for commits in the bpf-next tree Stephen Rothwell
2018-12-12 20:53 ` Alexei Starovoitov
2018-12-12 22:48 ` Stephen Rothwell
2018-12-12 23:39 ` Alexei Starovoitov
2018-12-12 23:45 ` Bart Van Assche
2018-12-13 0:20 ` Alexei Starovoitov
2018-12-13 0:45 ` David Miller
2018-12-13 4:33 ` Alexei Starovoitov
2018-12-13 5:37 ` Stephen Rothwell [this message]
2018-12-13 5:45 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181213163728.037ac535@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox