public inbox for linux-next@vger.kernel.org
 help / color / mirror / Atom feed
* Re: [PATCH V2] ARM: imx: add i.MX7ULP cpuidle support
       [not found] ` <20190114005600.GN11426@dragon>
@ 2019-01-15 12:30   ` Leonard Crestez
  2019-01-15 13:10     ` Stephen Rothwell
  0 siblings, 1 reply; 3+ messages in thread
From: Leonard Crestez @ 2019-01-15 12:30 UTC (permalink / raw)
  To: sfr@canb.auug.org.au, shawnguo@kernel.org
  Cc: dl-linux-imx, linux-kernel@vger.kernel.org, linux@armlinux.org.uk,
	Fabio Estevam, linux-next@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, Anson Huang,
	kernel@pengutronix.de, s.hauer@pengutronix.de

On 1/14/19 2:56 AM, Shawn Guo wrote:
> On Fri, Jan 11, 2019 at 05:57:30AM +0000, Anson Huang wrote:
> > This patch adds cpuidle support for i.MX7ULP, 3 cpuidle
> > states supported as below:
> > 
> > 1. WFI, just ARM wfi;
> > 2. WAIT mode, mapped to SoC's partial stop mode #3;
> > 3. STOP mode, mapped to SoC's partial stop mode #1.
> > 
> > In WAIT mode, system clock and bus clock will be enabled;
> > In STOP mode, system clock and bus clock will be disabled.
> > 
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> 
> Applied, thanks.
> 

Hello,

I'm not sure if anyone else already noticed but it seems the
arch/arm/mach-imx/cpuidle-imx7ulp.c file was dropped?

It's not in your tree:

https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git/commit/?h=imx/soc&id=cf2d2d392906f5603cf0d0f3630f6386babf7e4b

This causes build failures in next-20190115 with imx_v6_v7_defconfig.

--
Regards,
Leonard

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH V2] ARM: imx: add i.MX7ULP cpuidle support
  2019-01-15 12:30   ` [PATCH V2] ARM: imx: add i.MX7ULP cpuidle support Leonard Crestez
@ 2019-01-15 13:10     ` Stephen Rothwell
  2019-01-15 15:12       ` Shawn Guo
  0 siblings, 1 reply; 3+ messages in thread
From: Stephen Rothwell @ 2019-01-15 13:10 UTC (permalink / raw)
  To: Leonard Crestez
  Cc: shawnguo@kernel.org, dl-linux-imx, linux-kernel@vger.kernel.org,
	linux@armlinux.org.uk, Fabio Estevam, linux-next@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, Anson Huang,
	kernel@pengutronix.de, s.hauer@pengutronix.de

[-- Attachment #1: Type: text/plain, Size: 1227 bytes --]

Hi Leonard,

On Tue, 15 Jan 2019 12:30:23 +0000 Leonard Crestez <leonard.crestez@nxp.com> wrote:
>
> On 1/14/19 2:56 AM, Shawn Guo wrote:
> > On Fri, Jan 11, 2019 at 05:57:30AM +0000, Anson Huang wrote:  
> > > This patch adds cpuidle support for i.MX7ULP, 3 cpuidle
> > > states supported as below:
> > > 
> > > 1. WFI, just ARM wfi;
> > > 2. WAIT mode, mapped to SoC's partial stop mode #3;
> > > 3. STOP mode, mapped to SoC's partial stop mode #1.
> > > 
> > > In WAIT mode, system clock and bus clock will be enabled;
> > > In STOP mode, system clock and bus clock will be disabled.
> > > 
> > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>  
> > 
> > Applied, thanks.
> >   
> 
> Hello,
> 
> I'm not sure if anyone else already noticed but it seems the
> arch/arm/mach-imx/cpuidle-imx7ulp.c file was dropped?
> 
> It's not in your tree:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git/commit/?h=imx/soc&id=cf2d2d392906f5603cf0d0f3630f6386babf7e4b
> 
> This causes build failures in next-20190115 with imx_v6_v7_defconfig.

That file does not exist in Linus' tree either.  And there are no
commits in linux-next that add it.


-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH V2] ARM: imx: add i.MX7ULP cpuidle support
  2019-01-15 13:10     ` Stephen Rothwell
@ 2019-01-15 15:12       ` Shawn Guo
  0 siblings, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2019-01-15 15:12 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Leonard Crestez, dl-linux-imx, linux-kernel@vger.kernel.org,
	linux@armlinux.org.uk, Fabio Estevam, linux-next@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, Anson Huang,
	kernel@pengutronix.de, s.hauer@pengutronix.de

On Wed, Jan 16, 2019 at 12:10:43AM +1100, Stephen Rothwell wrote:
> Hi Leonard,
> 
> On Tue, 15 Jan 2019 12:30:23 +0000 Leonard Crestez <leonard.crestez@nxp.com> wrote:
> >
> > On 1/14/19 2:56 AM, Shawn Guo wrote:
> > > On Fri, Jan 11, 2019 at 05:57:30AM +0000, Anson Huang wrote:  
> > > > This patch adds cpuidle support for i.MX7ULP, 3 cpuidle
> > > > states supported as below:
> > > > 
> > > > 1. WFI, just ARM wfi;
> > > > 2. WAIT mode, mapped to SoC's partial stop mode #3;
> > > > 3. STOP mode, mapped to SoC's partial stop mode #1.
> > > > 
> > > > In WAIT mode, system clock and bus clock will be enabled;
> > > > In STOP mode, system clock and bus clock will be disabled.
> > > > 
> > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>  
> > > 
> > > Applied, thanks.
> > >   
> > 
> > Hello,
> > 
> > I'm not sure if anyone else already noticed but it seems the
> > arch/arm/mach-imx/cpuidle-imx7ulp.c file was dropped?
> > 
> > It's not in your tree:
> > 
> > https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git/commit/?h=imx/soc&id=cf2d2d392906f5603cf0d0f3630f6386babf7e4b
> > 
> > This causes build failures in next-20190115 with imx_v6_v7_defconfig.
> 
> That file does not exist in Linus' tree either.  And there are no
> commits in linux-next that add it.

Sorry.  That's my fault.  The patch doesn't apply to my tree and I had
to use 'patch' command.  However, I forgot to add this new
cpuidle-imx7ulp.c file.

Just fixed it.

Shawn

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-01-15 15:12 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <1547185955-2395-1-git-send-email-Anson.Huang@nxp.com>
     [not found] ` <20190114005600.GN11426@dragon>
2019-01-15 12:30   ` [PATCH V2] ARM: imx: add i.MX7ULP cpuidle support Leonard Crestez
2019-01-15 13:10     ` Stephen Rothwell
2019-01-15 15:12       ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox