* linux-next: build warnings after merge of the kunit-next tree
@ 2020-10-15 5:30 Stephen Rothwell
2020-10-15 10:43 ` Vitor Massaru Iha
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2020-10-15 5:30 UTC (permalink / raw)
To: Shuah Khan, Brendan Higgins
Cc: Vitor Massaru Iha, Linux Kernel Mailing List,
Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 786 bytes --]
Hi all,
After merging the kunit-next tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
lib/bitfield_kunit.c: In function 'test_bitfields_compile':
lib/bitfield_kunit.c:136:21: warning: unsigned conversion from 'int' to 'u16' {aka 'short unsigned int'} changes value from '393216' to '0' [-Woverflow]
136 | u16_encode_bits(0, 0x60000);
| ^~~~~~~
At top level:
lib/bitfield_kunit.c:129:20: warning: 'test_bitfields_compile' defined but not used [-Wunused-function]
129 | static void __init test_bitfields_compile(struct kunit *context)
| ^~~~~~~~~~~~~~~~~~~~~~
Introduced by commit
d2585f5164c2 ("lib: kunit: add bitfield test conversion to KUnit")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: linux-next: build warnings after merge of the kunit-next tree
2020-10-15 5:30 linux-next: build warnings after merge of the kunit-next tree Stephen Rothwell
@ 2020-10-15 10:43 ` Vitor Massaru Iha
2020-10-15 18:01 ` Shuah Khan
0 siblings, 1 reply; 6+ messages in thread
From: Vitor Massaru Iha @ 2020-10-15 10:43 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Shuah Khan, Brendan Higgins, Linux Kernel Mailing List,
Linux Next Mailing List
Hi Stephen,
On Thu, Oct 15, 2020 at 2:31 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the kunit-next tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> lib/bitfield_kunit.c: In function 'test_bitfields_compile':
> lib/bitfield_kunit.c:136:21: warning: unsigned conversion from 'int' to 'u16' {aka 'short unsigned int'} changes value from '393216' to '0' [-Woverflow]
> 136 | u16_encode_bits(0, 0x60000);
> | ^~~~~~~
> At top level:
> lib/bitfield_kunit.c:129:20: warning: 'test_bitfields_compile' defined but not used [-Wunused-function]
> 129 | static void __init test_bitfields_compile(struct kunit *context)
> | ^~~~~~~~~~~~~~~~~~~~~~
>
> Introduced by commit
>
> d2585f5164c2 ("lib: kunit: add bitfield test conversion to KUnit")
I saw the problem, I will send the patch.
Thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: linux-next: build warnings after merge of the kunit-next tree
2020-10-15 10:43 ` Vitor Massaru Iha
@ 2020-10-15 18:01 ` Shuah Khan
2020-10-15 18:10 ` Vitor Massaru Iha
0 siblings, 1 reply; 6+ messages in thread
From: Shuah Khan @ 2020-10-15 18:01 UTC (permalink / raw)
To: Vitor Massaru Iha, Stephen Rothwell
Cc: Brendan Higgins, Linux Kernel Mailing List,
Linux Next Mailing List, Shuah Khan
On 10/15/20 4:43 AM, Vitor Massaru Iha wrote:
> Hi Stephen,
>
> On Thu, Oct 15, 2020 at 2:31 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>
>> Hi all,
>>
>> After merging the kunit-next tree, today's linux-next build (x86_64
>> allmodconfig) produced this warning:
>>
>> lib/bitfield_kunit.c: In function 'test_bitfields_compile':
>> lib/bitfield_kunit.c:136:21: warning: unsigned conversion from 'int' to 'u16' {aka 'short unsigned int'} changes value from '393216' to '0' [-Woverflow]
>> 136 | u16_encode_bits(0, 0x60000);
>> | ^~~~~~~
>> At top level:
>> lib/bitfield_kunit.c:129:20: warning: 'test_bitfields_compile' defined but not used [-Wunused-function]
>> 129 | static void __init test_bitfields_compile(struct kunit *context)
>> | ^~~~~~~~~~~~~~~~~~~~~~
>>
>> Introduced by commit
>>
>> d2585f5164c2 ("lib: kunit: add bitfield test conversion to KUnit")
>
> I saw the problem, I will send the patch.
>
Please send the fix in as soon as possible. I will go ahead and send the
pull request and will apply the fix in rc2.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: linux-next: build warnings after merge of the kunit-next tree
2020-10-15 18:01 ` Shuah Khan
@ 2020-10-15 18:10 ` Vitor Massaru Iha
0 siblings, 0 replies; 6+ messages in thread
From: Vitor Massaru Iha @ 2020-10-15 18:10 UTC (permalink / raw)
To: Shuah Khan
Cc: Stephen Rothwell, Brendan Higgins, Linux Kernel Mailing List,
Linux Next Mailing List
Hi Shuah,
I already sent the patch:
https://patchwork.kernel.org/project/linux-kselftest/patch/20201015120851.229242-1-vitor@massaru.org
On Thu, Oct 15, 2020 at 3:01 PM Shuah Khan <skhan@linuxfoundation.org> wrote:
>
> On 10/15/20 4:43 AM, Vitor Massaru Iha wrote:
> > Hi Stephen,
> >
> > On Thu, Oct 15, 2020 at 2:31 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >>
> >> Hi all,
> >>
> >> After merging the kunit-next tree, today's linux-next build (x86_64
> >> allmodconfig) produced this warning:
> >>
> >> lib/bitfield_kunit.c: In function 'test_bitfields_compile':
> >> lib/bitfield_kunit.c:136:21: warning: unsigned conversion from 'int' to 'u16' {aka 'short unsigned int'} changes value from '393216' to '0' [-Woverflow]
> >> 136 | u16_encode_bits(0, 0x60000);
> >> | ^~~~~~~
> >> At top level:
> >> lib/bitfield_kunit.c:129:20: warning: 'test_bitfields_compile' defined but not used [-Wunused-function]
> >> 129 | static void __init test_bitfields_compile(struct kunit *context)
> >> | ^~~~~~~~~~~~~~~~~~~~~~
> >>
> >> Introduced by commit
> >>
> >> d2585f5164c2 ("lib: kunit: add bitfield test conversion to KUnit")
> >
> > I saw the problem, I will send the patch.
> >
>
> Please send the fix in as soon as possible. I will go ahead and send the
> pull request and will apply the fix in rc2.
>
> thanks,
> -- Shuah
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* linux-next: build warnings after merge of the kunit-next tree
@ 2023-05-30 5:18 Stephen Rothwell
2023-05-30 7:59 ` David Gow
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2023-05-30 5:18 UTC (permalink / raw)
To: Shuah Khan, Brendan Higgins
Cc: David Gow, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 1170 bytes --]
Hi all,
After merging the kunit-next tree, today's linux-next build (htmldocs)
produced these warnings:
include/kunit/resource.h:413: warning: Function parameter or member 'action' not described in 'kunit_add_action'
include/kunit/resource.h:413: warning: Excess function parameter 'func' description in 'kunit_add_action'
include/kunit/resource.h:439: warning: Function parameter or member 'action' not described in 'kunit_add_action_or_reset'
include/kunit/resource.h:439: warning: Excess function parameter 'func' description in 'kunit_add_action_or_re`set'
include/kunit/resource.h:457: warning: Function parameter or member 'action' not described in 'kunit_remove_action'
include/kunit/resource.h:457: warning: Excess function parameter 'func' description in 'kunit_remove_action'
include/kunit/resource.h:481: warning: Function parameter or member 'action' not described in 'kunit_release_action'
include/kunit/resource.h:481: warning: Excess function parameter 'func' description in 'kunit_release_action'
Introduced by commit
b9dce8a1ed3e ("kunit: Add kunit_add_action() to defer a call until test exit")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: linux-next: build warnings after merge of the kunit-next tree
2023-05-30 5:18 Stephen Rothwell
@ 2023-05-30 7:59 ` David Gow
0 siblings, 0 replies; 6+ messages in thread
From: David Gow @ 2023-05-30 7:59 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Shuah Khan, Brendan Higgins, Linux Kernel Mailing List,
Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 1403 bytes --]
On Tue, 30 May 2023 at 13:18, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the kunit-next tree, today's linux-next build (htmldocs)
> produced these warnings:
>
> include/kunit/resource.h:413: warning: Function parameter or member 'action' not described in 'kunit_add_action'
> include/kunit/resource.h:413: warning: Excess function parameter 'func' description in 'kunit_add_action'
> include/kunit/resource.h:439: warning: Function parameter or member 'action' not described in 'kunit_add_action_or_reset'
> include/kunit/resource.h:439: warning: Excess function parameter 'func' description in 'kunit_add_action_or_re`set'
> include/kunit/resource.h:457: warning: Function parameter or member 'action' not described in 'kunit_remove_action'
> include/kunit/resource.h:457: warning: Excess function parameter 'func' description in 'kunit_remove_action'
> include/kunit/resource.h:481: warning: Function parameter or member 'action' not described in 'kunit_release_action'
> include/kunit/resource.h:481: warning: Excess function parameter 'func' description in 'kunit_release_action'
>
> Introduced by commit
>
> b9dce8a1ed3e ("kunit: Add kunit_add_action() to defer a call until test exit")
>
Nice catch, thanks!
Fix is out here, will hopefully land soon:
https://lore.kernel.org/linux-kselftest/20230530075557.1558422-2-davidgow@google.com/T/#u
Cheers,
-- David
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4003 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-05-30 7:59 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-15 5:30 linux-next: build warnings after merge of the kunit-next tree Stephen Rothwell
2020-10-15 10:43 ` Vitor Massaru Iha
2020-10-15 18:01 ` Shuah Khan
2020-10-15 18:10 ` Vitor Massaru Iha
-- strict thread matches above, loose matches on Subject: below --
2023-05-30 5:18 Stephen Rothwell
2023-05-30 7:59 ` David Gow
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox