linux-next: Fixes tag needs some work in the mmc tree

linux-next: Fixes tag needs some work in the mmc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 193 bytes --]

Hi all,

Commit

  14b473254d60 ("mmc: sh_mmcif: correctly report success when obtaining DMA channels")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the mmc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 329 bytes --]

Hi all,

I got the wrong subject there, sorry.

On Wed, 9 Oct 2024 07:20:44 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Commit
> 
>   14b473254d60 ("mmc: sh_mmcif: correctly report success when obtaining DMA channels")
> 
> is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the mmc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 382 bytes --]

Hi all,

In commit

  7aada8ecf66b ("mmc: loongson2: prevent integer overflow in ret variable")

Fixes tag

  Fixes: d0f8e961deae ("mc: loongson2: Add Loongson-2K2000 SD/SDIO/eMMC controller driver")

has these problem(s):

  - Subject does not match target commit subject
    Just use
        git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the mmc tree

[Ulf Hansson]

On Thu, 10 Jul 2025 at 00:10, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> In commit
>
>   7aada8ecf66b ("mmc: loongson2: prevent integer overflow in ret variable")
>
> Fixes tag
>
>   Fixes: d0f8e961deae ("mc: loongson2: Add Loongson-2K2000 SD/SDIO/eMMC controller driver")
>
> has these problem(s):
>
>   - Subject does not match target commit subject
>     Just use
>         git log -1 --format='Fixes: %h ("%s")'
>

Thanks for reporting. It was a small typo, I have amended the fixes tag.

Kind regards
Uffe

linux-next: Fixes tag needs some work in the mmc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 360 bytes --]

Hi all,

In commit

  79055e47336e ("mmc: core: Remove redundant null check")

Fixes tag

  Fixes: 737d220bb2be ("mmc: core: Add open-ended Ext memory addressing")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 403a0293f1c2 ("mmc: core: Add open-ended Ext memory addressing")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

RE: linux-next: Fixes tag needs some work in the mmc tree

[Avri Altman]

> Hi all,
> 
> In commit
> 
>   79055e47336e ("mmc: core: Remove redundant null check")
> 
> Fixes tag
> 
>   Fixes: 737d220bb2be ("mmc: core: Add open-ended Ext memory
> addressing")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
I was using Ulf's for/next branch, as I always do, and their the sha1 is 737d220bb2be.
Should I be using different tree/branch ?

Thanks,
Avri

> 
> Maybe you meant
> 
> Fixes: 403a0293f1c2 ("mmc: core: Add open-ended Ext memory addressing")
> 
> --
> Cheers,
> Stephen Rothwell

RE: linux-next: Fixes tag needs some work in the mmc tree

[Avri Altman]

> > Hi all,
> >
> > In commit
> >
> >   79055e47336e ("mmc: core: Remove redundant null check")
> >
> > Fixes tag
> >
> >   Fixes: 737d220bb2be ("mmc: core: Add open-ended Ext memory
> > addressing")
> >
> > has these problem(s):
> >
> >   - Target SHA1 does not exist
> I was using Ulf's for/next branch, as I always do, and their the sha1 is
> 737d220bb2be.
> Should I be using different tree/branch ?
I apologize.  Looks like 403a0293f1c2 does exist and presumably point to the same commit (impossible):

commit 737d220bb2bef9efd43267c757faff003533b631
Author: Avri Altman <avri.altman@wdc.com>
Date:   Sun Oct 6 08:11:42 2024 +0300

    mmc: core: Add open-ended Ext memory addressing

commit 403a0293f1c230524e0185b31f69c02a6aed12c7
Author: Avri Altman <avri.altman@wdc.com>
Date:   Sun Oct 6 08:11:42 2024 +0300

    mmc: core: Add open-ended Ext memory addressing

I guess something in the metadata is different.

Thanks,
Avri
> 
> Thanks,
> Avri
> 
> >
> > Maybe you meant
> >
> > Fixes: 403a0293f1c2 ("mmc: core: Add open-ended Ext memory
> addressing")
> >
> > --
> > Cheers,
> > Stephen Rothwell

Re: linux-next: Fixes tag needs some work in the mmc tree

[Ulf Hansson]

On Fri, 21 Mar 2025 at 08:33, Avri Altman <Avri.Altman@sandisk.com> wrote:
>
> > > Hi all,
> > >
> > > In commit
> > >
> > >   79055e47336e ("mmc: core: Remove redundant null check")
> > >
> > > Fixes tag
> > >
> > >   Fixes: 737d220bb2be ("mmc: core: Add open-ended Ext memory
> > > addressing")
> > >
> > > has these problem(s):
> > >
> > >   - Target SHA1 does not exist
> > I was using Ulf's for/next branch, as I always do, and their the sha1 is
> > 737d220bb2be.
> > Should I be using different tree/branch ?
> I apologize.  Looks like 403a0293f1c2 does exist and presumably point to the same commit (impossible):
>
> commit 737d220bb2bef9efd43267c757faff003533b631
> Author: Avri Altman <avri.altman@wdc.com>
> Date:   Sun Oct 6 08:11:42 2024 +0300
>
>     mmc: core: Add open-ended Ext memory addressing
>
> commit 403a0293f1c230524e0185b31f69c02a6aed12c7
> Author: Avri Altman <avri.altman@wdc.com>
> Date:   Sun Oct 6 08:11:42 2024 +0300
>
>     mmc: core: Add open-ended Ext memory addressing
>
> I guess something in the metadata is different.

Sometimes I am re-basing my tree, so I am guessing the sha is from an
old tree/branch.

Anway I have moved to use 403a0293f1c2 as that should be the correct one.

[...]

Kind regards
Uffe

linux-next: Fixes tag needs some work in the mmc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 428 bytes --]

Hi all,

In commit

  7b16993c2bb2 ("mmc: sdhci-msm: Clear tuning done flag while hs400 tuning")

Fixes tag

  Fixes: ff06ce4 ("mmc: sdhci-msm: Add HS400 platform support")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the mmc tree

[Ulf Hansson]

On Fri, 29 May 2020 at 14:16, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> In commit
>
>   7b16993c2bb2 ("mmc: sdhci-msm: Clear tuning done flag while hs400 tuning")
>
> Fixes tag
>
>   Fixes: ff06ce4 ("mmc: sdhci-msm: Add HS400 platform support")
>
> has these problem(s):
>
>   - SHA1 should be at least 12 digits long
>     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
>     or later) just making sure it is not set (or set to "auto").

Stephen, thanks for the notification, patch amended!

Kind regards
Uffe

linux-next: Fixes tag needs some work in the mmc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 396 bytes --]

Hi all,

In commit

  59592cc1f593 ("mmc: sdhci_am654: Add dependency on MMC_SDHCI_AM654")

Fixes tag

  Fixes: aff88ff23512 ("mmc: sdhci_am654: Add Initial Support for AM654 SDHCI driver")

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: 41fd4caeb00b ("mmc: sdhci_am654: Add Initial Support for AM654 SDHCI driver")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the mmc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 396 bytes --]

Hi all,

In commit

  adca963337c7 ("mmc: sdhci_am654: Add dependency on MMC_SDHCI_AM654")

Fixes tag

  Fixes: aff88ff23512 ("mmc: sdhci_am654: Add Initial Support for AM654 SDHCI driver")

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: 41fd4caeb00b ("mmc: sdhci_am654: Add Initial Support for AM654 SDHCI driver")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the mmc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 473 bytes --]

Hi Ulf,

In commit

  98bc384ce704 ("mmc: core: fix possible use after free of host")

Fixes tag

  Fixes: 1ed21719448("mmc: core: fix error path in mmc_host_alloc")

has these problem(s):

  - missing space between the SHA1 and the subject
  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]