linux-next: build failure after merge of the cpufreq-arm tree

linux-next: build failure after merge of the cpufreq-arm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1523 bytes --]

Hi all,

After merging the cpufreq-arm tree, today's linux-next build (x86_64
allmodconfig) failed like this:

error[E0308]: mismatched types
   --> rust/kernel/cpufreq.rs:950:18
    |
950 |             Some(Self::update_limits_callback)
    |             ---- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected fn pointer, found fn item
    |             |
    |             arguments to this enum variant are incorrect
    |
    = note: expected fn pointer `unsafe extern "C" fn(*mut bindings::cpufreq_policy)`
                  found fn item `extern "C" fn(u32) {cpufreq::Registration::<T>::update_limits_callback}`
help: the type constructed contains `extern "C" fn(u32) {cpufreq::Registration::<T>::update_limits_callback}` due to the type of the argument passed
   --> rust/kernel/cpufreq.rs:950:13
    |
950 |             Some(Self::update_limits_callback)
    |             ^^^^^----------------------------^
    |                  |
    |                  this argument influences the type of `Some`
note: tuple variant defined here
   --> /usr/lib/rustlib/src/rust/library/core/src/option.rs:580:5
    |
580 |     Some(#[stable(feature = "rust1", since = "1.0.0")] T),
    |     ^^^^

error: aborting due to 1 previous error

For more information about this error, try `rustc --explain E0308`.

Caused by commit

  c490d1f07bec ("rust: cpufreq: Extend abstractions for driver registration")

I have used the cpufreq-arm tree from next-20250424 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the cpufreq-arm tree

[Viresh Kumar]

On 28-04-25, 11:57, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the cpufreq-arm tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> error[E0308]: mismatched types
>    --> rust/kernel/cpufreq.rs:950:18
>     |
> 950 |             Some(Self::update_limits_callback)
>     |             ---- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected fn pointer, found fn item
>     |             |
>     |             arguments to this enum variant are incorrect
>     |
>     = note: expected fn pointer `unsafe extern "C" fn(*mut bindings::cpufreq_policy)`
>                   found fn item `extern "C" fn(u32) {cpufreq::Registration::<T>::update_limits_callback}`
> help: the type constructed contains `extern "C" fn(u32) {cpufreq::Registration::<T>::update_limits_callback}` due to the type of the argument passed
>    --> rust/kernel/cpufreq.rs:950:13
>     |
> 950 |             Some(Self::update_limits_callback)
>     |             ^^^^^----------------------------^
>     |                  |
>     |                  this argument influences the type of `Some`
> note: tuple variant defined here
>    --> /usr/lib/rustlib/src/rust/library/core/src/option.rs:580:5
>     |
> 580 |     Some(#[stable(feature = "rust1", since = "1.0.0")] T),
>     |     ^^^^
> 
> error: aborting due to 1 previous error
> 
> For more information about this error, try `rustc --explain E0308`.
> 
> Caused by commit
> 
>   c490d1f07bec ("rust: cpufreq: Extend abstractions for driver registration")
> 
> I have used the cpufreq-arm tree from next-20250424 for today.

Fixed and pushed. Thanks. There was a conflict against a recent update
in the PM tree.

-- 
viresh

linux-next: build failure after merge of the cpufreq-arm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1289 bytes --]

Hi all,

After merging the cpufreq-arm tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

In file included from include/linux/cpufreq.h:17,
                 from drivers/cpufreq/spear-cpufreq.c:17:
drivers/cpufreq/spear-cpufreq.c: In function 'spear_cpufreq_probe':
include/linux/of.h:1435:51: error: lvalue required as unary '&' operand
 1435 |                  of_prop_next_u32(_it.prop, NULL, &u)};                 \
      |                                                   ^
drivers/cpufreq/spear-cpufreq.c:201:9: note: in expansion of macro 'of_property_for_each_u32'
  201 |         of_property_for_each_u32(np, "cpufreq_tbl", &val)
      |         ^~~~~~~~~~~~~~~~~~~~~~~~
include/linux/of.h:1437:62: error: lvalue required as unary '&' operand
 1437 |              _it.item = of_prop_next_u32(_it.prop, _it.item, &u))
      |                                                              ^
drivers/cpufreq/spear-cpufreq.c:201:9: note: in expansion of macro 'of_property_for_each_u32'
  201 |         of_property_for_each_u32(np, "cpufreq_tbl", &val)
      |         ^~~~~~~~~~~~~~~~~~~~~~~~

Caused by commit

  e960bbac0af4 ("cpufreq: spear: Use of_property_for_each_u32() instead of open coding")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the cpufreq-arm tree

[Viresh Kumar]

On 02-08-24, 10:57, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the cpufreq-arm tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> In file included from include/linux/cpufreq.h:17,
>                  from drivers/cpufreq/spear-cpufreq.c:17:
> drivers/cpufreq/spear-cpufreq.c: In function 'spear_cpufreq_probe':
> include/linux/of.h:1435:51: error: lvalue required as unary '&' operand
>  1435 |                  of_prop_next_u32(_it.prop, NULL, &u)};                 \
>       |                                                   ^
> drivers/cpufreq/spear-cpufreq.c:201:9: note: in expansion of macro 'of_property_for_each_u32'
>   201 |         of_property_for_each_u32(np, "cpufreq_tbl", &val)
>       |         ^~~~~~~~~~~~~~~~~~~~~~~~
> include/linux/of.h:1437:62: error: lvalue required as unary '&' operand
>  1437 |              _it.item = of_prop_next_u32(_it.prop, _it.item, &u))
>       |                                                              ^
> drivers/cpufreq/spear-cpufreq.c:201:9: note: in expansion of macro 'of_property_for_each_u32'
>   201 |         of_property_for_each_u32(np, "cpufreq_tbl", &val)
>       |         ^~~~~~~~~~~~~~~~~~~~~~~~
> 
> Caused by commit
> 
>   e960bbac0af4 ("cpufreq: spear: Use of_property_for_each_u32() instead of open coding")

Fixed as:

diff --git a/drivers/cpufreq/spear-cpufreq.c b/drivers/cpufreq/spear-cpufreq.c
index 4d28147c23f1..777f7f5b3671 100644
--- a/drivers/cpufreq/spear-cpufreq.c
+++ b/drivers/cpufreq/spear-cpufreq.c
@@ -198,7 +198,7 @@ static int spear_cpufreq_probe(struct platform_device *pdev)
                goto out_put_node;
        }

-       of_property_for_each_u32(np, "cpufreq_tbl", &val)
+       of_property_for_each_u32(np, "cpufreq_tbl", val)
                freq_tbl[i].frequency = val;

        freq_tbl[cnt].frequency = CPUFREQ_TABLE_END;

-- 
viresh

linux-next: build failure after merge of the cpufreq-arm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 650 bytes --]

Hi all,

After merging the cpufreq-arm tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/cpufreq/qcom-cpufreq-nvmem.c: In function 'qcom_cpufreq_kryo_name_version':
drivers/cpufreq/qcom-cpufreq-nvmem.c:194:14: error: 'QCOM_ID_IPQ5321' undeclared (first use in this function); did you mean 'QCOM_ID_IPQ5312'?
  194 |         case QCOM_ID_IPQ5321:
      |              ^~~~~~~~~~~~~~~
      |              QCOM_ID_IPQ5312

Caused by commit

  006af7c6958e ("cpufreq: qcom-nvmem: add support for IPQ5321")

I have used the cpufreq-arm tree from next-20240304 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the cpufreq-arm tree

[Viresh Kumar]

On 05-03-24, 11:09, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the cpufreq-arm tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> drivers/cpufreq/qcom-cpufreq-nvmem.c: In function 'qcom_cpufreq_kryo_name_version':
> drivers/cpufreq/qcom-cpufreq-nvmem.c:194:14: error: 'QCOM_ID_IPQ5321' undeclared (first use in this function); did you mean 'QCOM_ID_IPQ5312'?
>   194 |         case QCOM_ID_IPQ5321:
>       |              ^~~~~~~~~~~~~~~
>       |              QCOM_ID_IPQ5312
> 
> Caused by commit
> 
>   006af7c6958e ("cpufreq: qcom-nvmem: add support for IPQ5321")
> 
> I have used the cpufreq-arm tree from next-20240304 for today.

Sorry about that, dropped now.

-- 
viresh