* [PATCH -next] driver core: syscore exports for modular APM
2011-04-19 5:06 linux-next: Tree for April 19 Stephen Rothwell
@ 2011-04-19 15:35 ` Randy Dunlap
2011-04-19 21:17 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Randy Dunlap @ 2011-04-19 15:35 UTC (permalink / raw)
To: Stephen Rothwell, gregkh, Rafael J. Wysocki; +Cc: linux-next, LKML
From: Randy Dunlap <randy.dunlap@oracle.com>
When CONFIG_APM=m, build fails with:
ERROR: "syscore_suspend" [arch/x86/kernel/apm.ko] undefined!
ERROR: "syscore_resume" [arch/x86/kernel/apm.ko] undefined!
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
drivers/base/syscore.c | 2 ++
1 file changed, 2 insertions(+)
--- linux-next-20110419.orig/drivers/base/syscore.c
+++ linux-next-20110419/drivers/base/syscore.c
@@ -73,6 +73,7 @@ int syscore_suspend(void)
return ret;
}
+EXPORT_SYMBOL_GPL(syscore_suspend);
/**
* syscore_resume - Execute all the registered system core resume callbacks.
@@ -95,6 +96,7 @@ void syscore_resume(void)
"Interrupts enabled after %pF\n", ops->resume);
}
}
+EXPORT_SYMBOL_GPL(syscore_resume);
#endif /* CONFIG_PM_SLEEP */
/**
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next] driver core: syscore exports for modular APM
2011-04-19 15:35 ` [PATCH -next] driver core: syscore exports for modular APM Randy Dunlap
@ 2011-04-19 21:17 ` Greg KH
2011-04-19 22:04 ` Rafael J. Wysocki
0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2011-04-19 21:17 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Stephen Rothwell, Rafael J. Wysocki, linux-next, LKML
On Tue, Apr 19, 2011 at 08:35:46AM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> When CONFIG_APM=m, build fails with:
>
> ERROR: "syscore_suspend" [arch/x86/kernel/apm.ko] undefined!
> ERROR: "syscore_resume" [arch/x86/kernel/apm.ko] undefined!
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
Rafael, care to send this to Linus? Or do you want me to?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next] driver core: syscore exports for modular APM
2011-04-19 21:17 ` Greg KH
@ 2011-04-19 22:04 ` Rafael J. Wysocki
2011-04-20 20:39 ` Rafael J. Wysocki
0 siblings, 1 reply; 5+ messages in thread
From: Rafael J. Wysocki @ 2011-04-19 22:04 UTC (permalink / raw)
To: Greg KH; +Cc: Randy Dunlap, Stephen Rothwell, linux-next, LKML
On Tuesday, April 19, 2011, Greg KH wrote:
> On Tue, Apr 19, 2011 at 08:35:46AM -0700, Randy Dunlap wrote:
> > From: Randy Dunlap <randy.dunlap@oracle.com>
> >
> > When CONFIG_APM=m, build fails with:
> >
> > ERROR: "syscore_suspend" [arch/x86/kernel/apm.ko] undefined!
> > ERROR: "syscore_resume" [arch/x86/kernel/apm.ko] undefined!
> >
> > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>
> Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
>
> Rafael, care to send this to Linus? Or do you want me to?
I will. Or better I'll fold it into the patch, it hasn't been
sent to Linus yet.
Thanks,
Rafael
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next] driver core: syscore exports for modular APM
2011-04-19 22:04 ` Rafael J. Wysocki
@ 2011-04-20 20:39 ` Rafael J. Wysocki
0 siblings, 0 replies; 5+ messages in thread
From: Rafael J. Wysocki @ 2011-04-20 20:39 UTC (permalink / raw)
To: Greg KH, Randy Dunlap; +Cc: Stephen Rothwell, linux-next, LKML
On Wednesday, April 20, 2011, Rafael J. Wysocki wrote:
> On Tuesday, April 19, 2011, Greg KH wrote:
> > On Tue, Apr 19, 2011 at 08:35:46AM -0700, Randy Dunlap wrote:
> > > From: Randy Dunlap <randy.dunlap@oracle.com>
> > >
> > > When CONFIG_APM=m, build fails with:
> > >
> > > ERROR: "syscore_suspend" [arch/x86/kernel/apm.ko] undefined!
> > > ERROR: "syscore_resume" [arch/x86/kernel/apm.ko] undefined!
> > >
> > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> >
> > Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
> >
> > Rafael, care to send this to Linus? Or do you want me to?
>
> I will. Or better I'll fold it into the patch, it hasn't been
> sent to Linus yet.
The problem should be fixed in today's linux-next. Randy, can you confirm,
please?
Rafael
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next] driver core: syscore exports for modular APM
@ 2011-04-20 21:06 Randy Dunlap
0 siblings, 0 replies; 5+ messages in thread
From: Randy Dunlap @ 2011-04-20 21:06 UTC (permalink / raw)
To: rjw; +Cc: sfr, linux-kernel, greg, linux-next
----- Original Message -----
From: rjw@sisk.pl
To: greg@kroah.com, randy.dunlap@oracle.com
Cc: sfr@canb.auug.org.au, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Sent: Wednesday, April 20, 2011 1:39:18 PM GMT -08:00 US/Canada Pacific
Subject: Re: [PATCH -next] driver core: syscore exports for modular APM
On Wednesday, April 20, 2011, Rafael J. Wysocki wrote:
> On Tuesday, April 19, 2011, Greg KH wrote:
> > On Tue, Apr 19, 2011 at 08:35:46AM -0700, Randy Dunlap wrote:
> > > From: Randy Dunlap <randy.dunlap@oracle.com>
> > >
> > > When CONFIG_APM=m, build fails with:
> > >
> > > ERROR: "syscore_suspend" [arch/x86/kernel/apm.ko] undefined!
> > > ERROR: "syscore_resume" [arch/x86/kernel/apm.ko] undefined!
> > >
> > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> >
> > Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
> >
> > Rafael, care to send this to Linus? Or do you want me to?
>
> I will. Or better I'll fold it into the patch, it hasn't been
> sent to Linus yet.
| The problem should be fixed in today's linux-next. Randy, can you confirm,
| please?
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Yes, it's fixed there. Thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-04-20 21:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-20 21:06 [PATCH -next] driver core: syscore exports for modular APM Randy Dunlap
-- strict thread matches above, loose matches on Subject: below --
2011-04-19 5:06 linux-next: Tree for April 19 Stephen Rothwell
2011-04-19 15:35 ` [PATCH -next] driver core: syscore exports for modular APM Randy Dunlap
2011-04-19 21:17 ` Greg KH
2011-04-19 22:04 ` Rafael J. Wysocki
2011-04-20 20:39 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox