From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: "linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
Rafael Wysocki <rafael.j.wysocki@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Luis R. Rodriguez" <mcgrof@suse.com>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] pnpbios: add header file to fix build errors
Date: Thu, 28 Jul 2016 01:49:55 +0200 [thread overview]
Message-ID: <2367158.Y693rAZPTH@vostro.rjw.lan> (raw)
In-Reply-To: <ae7a56b8-27a4-05c3-44f7-e1140bfd7acd@infradead.org>
On Tuesday, July 26, 2016 04:26:40 PM Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix build errors due to missing header file:
>
> ../drivers/pnp/pnpbios/core.c: In function 'pnp_dock_event':
> ../drivers/pnp/pnpbios/core.c:141:2: error: implicit declaration of function 'call_usermodehelper' [-Werror=implicit-function-declaration]
> value = call_usermodehelper(argv [0], argv, envp, UMH_WAIT_EXEC);
> ^
> ../drivers/pnp/pnpbios/core.c:141:52: error: 'UMH_WAIT_EXEC' undeclared (first use in this function)
> value = call_usermodehelper(argv [0], argv, envp, UMH_WAIT_EXEC);
> ^
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> I should have copied Rafael on this the first time.
> Also applies to mainline.
OK, I'm going to apply it, thanks!
> drivers/pnp/pnpbios/core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20160711.orig/drivers/pnp/pnpbios/core.c
> +++ linux-next-20160711/drivers/pnp/pnpbios/core.c
> @@ -60,6 +60,7 @@
> #include <linux/delay.h>
> #include <linux/acpi.h>
> #include <linux/freezer.h>
> +#include <linux/kmod.h>
> #include <linux/kthread.h>
>
> #include <asm/page.h>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
prev parent reply other threads:[~2016-07-27 23:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-26 23:26 [PATCH] pnpbios: add header file to fix build errors Randy Dunlap
2016-07-27 23:49 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2367158.Y693rAZPTH@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mcgrof@suse.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox