* [PATCH] pnpbios: add header file to fix build errors
@ 2016-07-26 23:26 Randy Dunlap
2016-07-27 23:49 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2016-07-26 23:26 UTC (permalink / raw)
To: linux-next@vger.kernel.org, Rafael Wysocki
Cc: Greg Kroah-Hartman, Luis R. Rodriguez, LKML, Andrew Morton
From: Randy Dunlap <rdunlap@infradead.org>
Fix build errors due to missing header file:
../drivers/pnp/pnpbios/core.c: In function 'pnp_dock_event':
../drivers/pnp/pnpbios/core.c:141:2: error: implicit declaration of function 'call_usermodehelper' [-Werror=implicit-function-declaration]
value = call_usermodehelper(argv [0], argv, envp, UMH_WAIT_EXEC);
^
../drivers/pnp/pnpbios/core.c:141:52: error: 'UMH_WAIT_EXEC' undeclared (first use in this function)
value = call_usermodehelper(argv [0], argv, envp, UMH_WAIT_EXEC);
^
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
I should have copied Rafael on this the first time.
Also applies to mainline.
drivers/pnp/pnpbios/core.c | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20160711.orig/drivers/pnp/pnpbios/core.c
+++ linux-next-20160711/drivers/pnp/pnpbios/core.c
@@ -60,6 +60,7 @@
#include <linux/delay.h>
#include <linux/acpi.h>
#include <linux/freezer.h>
+#include <linux/kmod.h>
#include <linux/kthread.h>
#include <asm/page.h>
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] pnpbios: add header file to fix build errors
2016-07-26 23:26 [PATCH] pnpbios: add header file to fix build errors Randy Dunlap
@ 2016-07-27 23:49 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2016-07-27 23:49 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-next@vger.kernel.org, Rafael Wysocki, Greg Kroah-Hartman,
Luis R. Rodriguez, LKML, Andrew Morton
On Tuesday, July 26, 2016 04:26:40 PM Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix build errors due to missing header file:
>
> ../drivers/pnp/pnpbios/core.c: In function 'pnp_dock_event':
> ../drivers/pnp/pnpbios/core.c:141:2: error: implicit declaration of function 'call_usermodehelper' [-Werror=implicit-function-declaration]
> value = call_usermodehelper(argv [0], argv, envp, UMH_WAIT_EXEC);
> ^
> ../drivers/pnp/pnpbios/core.c:141:52: error: 'UMH_WAIT_EXEC' undeclared (first use in this function)
> value = call_usermodehelper(argv [0], argv, envp, UMH_WAIT_EXEC);
> ^
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> I should have copied Rafael on this the first time.
> Also applies to mainline.
OK, I'm going to apply it, thanks!
> drivers/pnp/pnpbios/core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20160711.orig/drivers/pnp/pnpbios/core.c
> +++ linux-next-20160711/drivers/pnp/pnpbios/core.c
> @@ -60,6 +60,7 @@
> #include <linux/delay.h>
> #include <linux/acpi.h>
> #include <linux/freezer.h>
> +#include <linux/kmod.h>
> #include <linux/kthread.h>
>
> #include <asm/page.h>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-07-27 23:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-26 23:26 [PATCH] pnpbios: add header file to fix build errors Randy Dunlap
2016-07-27 23:49 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox