public inbox for linux-next@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH linux-next] irq: export handle_fasteoi_irq
@ 2014-08-21 23:31 Vincent Stehlé
  2014-08-24 20:17 ` Arnd Bergmann
  0 siblings, 1 reply; 2+ messages in thread
From: Vincent Stehlé @ 2014-08-21 23:31 UTC (permalink / raw)
  To: linux-next, linux-gpio
  Cc: linux-arm-kernel, linux-kernel, Vincent Stehlé,
	Thomas Gleixner, Lars-Peter Clausen, Linus Walleij

Export handle_fasteoi_irq to be able to use it in e.g. the Zynq gpio driver
since commit 6dd859508336 ("gpio: zynq: Fix IRQ handlers").

This fixes the following link issue:

  ERROR: "handle_fasteoi_irq" [drivers/gpio/gpio-zynq.ko] undefined!

Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Lars-Peter Clausen <lars@metafoo.de>
Cc: Linus Walleij <linus.walleij@linaro.org>
---

Hi,

This can be seen in Linux next-20140822 with e.g. arm allmodconfig.

Zync gpio seems to be the first code to use handle_fasteoi_irq, which can be
compiled as a module.

Best regards,

V.

 kernel/irq/chip.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
index a2b28a2..6223fab 100644
--- a/kernel/irq/chip.c
+++ b/kernel/irq/chip.c
@@ -517,6 +517,7 @@ out:
 		chip->irq_eoi(&desc->irq_data);
 	raw_spin_unlock(&desc->lock);
 }
+EXPORT_SYMBOL_GPL(handle_fasteoi_irq);
 
 /**
  *	handle_edge_irq - edge type IRQ handler
-- 
2.1.0.rc1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH linux-next] irq: export handle_fasteoi_irq
  2014-08-21 23:31 [PATCH linux-next] irq: export handle_fasteoi_irq Vincent Stehlé
@ 2014-08-24 20:17 ` Arnd Bergmann
  0 siblings, 0 replies; 2+ messages in thread
From: Arnd Bergmann @ 2014-08-24 20:17 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: Vincent Stehlé, linux-next, linux-gpio, Lars-Peter Clausen,
	Linus Walleij, linux-kernel, Thomas Gleixner

On Friday 22 August 2014 01:31:20 Vincent Stehlé wrote:
> Export handle_fasteoi_irq to be able to use it in e.g. the Zynq gpio driver
> since commit 6dd859508336 ("gpio: zynq: Fix IRQ handlers").
> 
> This fixes the following link issue:
> 
>   ERROR: "handle_fasteoi_irq" [drivers/gpio/gpio-zynq.ko] undefined!
> 
> Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Lars-Peter Clausen <lars@metafoo.de>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> 

Acked-by: Arnd Bergmann <arnd@arndb.de>

I saw the same thing here and came up with the same fix.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-08-24 20:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-21 23:31 [PATCH linux-next] irq: export handle_fasteoi_irq Vincent Stehlé
2014-08-24 20:17 ` Arnd Bergmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox