next-20090630: audit/fsnotify build failure

next-20090630: audit/fsnotify build failure

[Alexander Beregalov]

Hi

kernel/audit_watch.c: In function 'audit_get_parent':
kernel/audit_watch.c:85: error: implicit declaration of function
'fsnotify_get_mark'
kernel/audit_watch.c: In function 'audit_put_parent':
kernel/audit_watch.c:91: error: implicit declaration of function
'fsnotify_put_mark'
kernel/audit_watch.c: In function 'audit_find_parent':
kernel/audit_watch.c:104: error: implicit declaration of function
'fsnotify_find_mark_entry'
kernel/audit_watch.c:104: warning: assignment makes pointer from
integer without a cast
kernel/audit_watch.c: In function 'audit_init_parent':
kernel/audit_watch.c:161: error: implicit declaration of function
'fsnotify_init_mark'
kernel/audit_watch.c:163: error: implicit declaration of function
'fsnotify_add_mark'
kernel/audit_watch.c: In function 'audit_remove_parent_watches':
kernel/audit_watch.c:354: error: implicit declaration of function
'fsnotify_destroy_mark_by_entry'
kernel/audit_watch.c: In function 'audit_watch_should_send_event':
kernel/audit_watch.c:513: warning: assignment makes pointer from
integer without a cast
kernel/audit_watch.c: In function 'audit_watch_init':
kernel/audit_watch.c:578: error: implicit declaration of function
'fsnotify_obtain_group'
kernel/audit_watch.c:579: warning: assignment makes pointer from
integer without a cast


$ egrep "NOTIFY|AUDIT" .config
CONFIG_AUDIT_ARCH=y
CONFIG_AUDIT=y
# CONFIG_AUDITSYSCALL is not set
# CONFIG_FSNOTIFY is not set
CONFIG_INOTIFY=y

Re: next-20090630: audit/fsnotify build failure

[Eric Paris]

On Tue, 2009-06-30 at 16:27 +0400, Alexander Beregalov wrote:
> Hi
> 
> kernel/audit_watch.c: In function 'audit_get_parent':
> kernel/audit_watch.c:85: error: implicit declaration of function
> 'fsnotify_get_mark'
> kernel/audit_watch.c: In function 'audit_put_parent':
> kernel/audit_watch.c:91: error: implicit declaration of function
> 'fsnotify_put_mark'
> kernel/audit_watch.c: In function 'audit_find_parent':
> kernel/audit_watch.c:104: error: implicit declaration of function
> 'fsnotify_find_mark_entry'
> kernel/audit_watch.c:104: warning: assignment makes pointer from
> integer without a cast
> kernel/audit_watch.c: In function 'audit_init_parent':
> kernel/audit_watch.c:161: error: implicit declaration of function
> 'fsnotify_init_mark'
> kernel/audit_watch.c:163: error: implicit declaration of function
> 'fsnotify_add_mark'
> kernel/audit_watch.c: In function 'audit_remove_parent_watches':
> kernel/audit_watch.c:354: error: implicit declaration of function
> 'fsnotify_destroy_mark_by_entry'
> kernel/audit_watch.c: In function 'audit_watch_should_send_event':
> kernel/audit_watch.c:513: warning: assignment makes pointer from
> integer without a cast
> kernel/audit_watch.c: In function 'audit_watch_init':
> kernel/audit_watch.c:578: error: implicit declaration of function
> 'fsnotify_obtain_group'
> kernel/audit_watch.c:579: warning: assignment makes pointer from
> integer without a cast

audit now depends on FSNOTIFY.  Will fix for tomorrow.  (and I'll try to
break audit_watches out to their own config option so you don't have to
have notification.

Sorry for the breakage.

-Eric

Re: next-20090630: audit/fsnotify build failure

[Eric Paris]

On Tue, 2009-06-30 at 16:27 +0400, Alexander Beregalov wrote:
> Hi
> 
> kernel/audit_watch.c: In function 'audit_get_parent':
> kernel/audit_watch.c:85: error: implicit declaration of function
> 'fsnotify_get_mark'

Should be fixed for you by:

http://git.infradead.org/users/eparis/notify.git?a=commitdiff;h=aae48cb2b8719e8a374faea141373b7ce0b89bc6
http://git.infradead.org/users/eparis/notify.git?a=commitdiff;h=de85e5bc3690c3063aea790279e898adb5bac0ba

> $ egrep "NOTIFY|AUDIT" .config
> CONFIG_AUDIT_ARCH=y
> CONFIG_AUDIT=y
> # CONFIG_AUDITSYSCALL is not set
> # CONFIG_FSNOTIFY is not set
> CONFIG_INOTIFY=y

Unrelated note, CONFIG_INOTIFY in linux-next is completely and totally
useless.....

-Eric

Re: next-20090630: audit/fsnotify build failure

[Alexander Beregalov]

2009/6/30 Eric Paris <eparis@redhat.com>:
> On Tue, 2009-06-30 at 16:27 +0400, Alexander Beregalov wrote:
>> Hi
>>
>> kernel/audit_watch.c: In function 'audit_get_parent':
>> kernel/audit_watch.c:85: error: implicit declaration of function
>> 'fsnotify_get_mark'
>
> Should be fixed for you by:
>
> http://git.infradead.org/users/eparis/notify.git?a=commitdiff;h=aae48cb2b8719e8a374faea141373b7ce0b89bc6
> http://git.infradead.org/users/eparis/notify.git?a=commitdiff;h=de85e5bc3690c3063aea790279e898adb5bac0ba
>
>> $ egrep "NOTIFY|AUDIT" .config
>> CONFIG_AUDIT_ARCH=y
>> CONFIG_AUDIT=y
>> # CONFIG_AUDITSYSCALL is not set
>> # CONFIG_FSNOTIFY is not set
>> CONFIG_INOTIFY=y
>
> Unrelated note, CONFIG_INOTIFY in linux-next is completely and totally
> useless.....

Thanks Eric.
This config is not for a real kernel.
I just test randconfig build from time to time.

Re: next-20090630: audit/fsnotify build failure

[Randy Dunlap]

Eric Paris wrote:
> On Tue, 2009-06-30 at 16:27 +0400, Alexander Beregalov wrote:
>> Hi
>>
>> kernel/audit_watch.c: In function 'audit_get_parent':
>> kernel/audit_watch.c:85: error: implicit declaration of function
>> 'fsnotify_get_mark'
> 
> Should be fixed for you by:
> 
> http://git.infradead.org/users/eparis/notify.git?a=commitdiff;h=aae48cb2b8719e8a374faea141373b7ce0b89bc6
> http://git.infradead.org/users/eparis/notify.git?a=commitdiff;h=de85e5bc3690c3063aea790279e898adb5bac0ba
> 
>> $ egrep "NOTIFY|AUDIT" .config
>> CONFIG_AUDIT_ARCH=y
>> CONFIG_AUDIT=y
>> # CONFIG_AUDITSYSCALL is not set
>> # CONFIG_FSNOTIFY is not set
>> CONFIG_INOTIFY=y
> 
> Unrelated note, CONFIG_INOTIFY in linux-next is completely and totally
> useless.....

Please explain.
Looks like it still controls building fs/notify/inotify/inotify.o,
based on fs/notify/inotify/Makefile.

-- 
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/

Re: next-20090630: audit/fsnotify build failure

[Eric Paris]

On Tue, 2009-06-30 at 12:06 -0700, Randy Dunlap wrote:
> Eric Paris wrote:
> > On Tue, 2009-06-30 at 16:27 +0400, Alexander Beregalov wrote:
> >> Hi
> >>
> >> kernel/audit_watch.c: In function 'audit_get_parent':
> >> kernel/audit_watch.c:85: error: implicit declaration of function
> >> 'fsnotify_get_mark'
> > 
> > Should be fixed for you by:
> > 
> > http://git.infradead.org/users/eparis/notify.git?a=commitdiff;h=aae48cb2b8719e8a374faea141373b7ce0b89bc6
> > http://git.infradead.org/users/eparis/notify.git?a=commitdiff;h=de85e5bc3690c3063aea790279e898adb5bac0ba
> > 
> >> $ egrep "NOTIFY|AUDIT" .config
> >> CONFIG_AUDIT_ARCH=y
> >> CONFIG_AUDIT=y
> >> # CONFIG_AUDITSYSCALL is not set
> >> # CONFIG_FSNOTIFY is not set
> >> CONFIG_INOTIFY=y
> > 
> > Unrelated note, CONFIG_INOTIFY in linux-next is completely and totally
> > useless.....
> 
> Please explain.
> Looks like it still controls building fs/notify/inotify/inotify.o,
> based on fs/notify/inotify/Makefile.

Which in turn is used by nothing.  Although it is EXPORT_SYMBOL_GPL, so
you could have some out of tree module that uses it, but I haven't found
one....

Re: next-20090630: audit/fsnotify build failure

[Alexander Beregalov]

Hi Eric

Another problem today (0701)

kernel/auditfilter.c: In function 'audit_data_to_entry':
kernel/auditfilter.c:501: error: expected expression before '{' token
kernel/auditfilter.c: In function 'audit_add_rule':
kernel/auditfilter.c:891: error: expected expression before '{' token

CONFIG_AUDIT_WATCH is not set

Re: next-20090630: audit/fsnotify build failure

[Eric Paris]

On Wed, 2009-07-01 at 16:07 +0400, Alexander Beregalov wrote:
> Hi Eric
> 
> Another problem today (0701)
> 
> kernel/auditfilter.c: In function 'audit_data_to_entry':
> kernel/auditfilter.c:501: error: expected expression before '{' token
> kernel/auditfilter.c: In function 'audit_add_rule':
> kernel/auditfilter.c:891: error: expected expression before '{' token
> 
> CONFIG_AUDIT_WATCH is not set

This one is just me being stupid and committing the wrong version to the
tree :(   Thank you so much for testing this!

s/{ -EINVAL }/-EINVAL/

-Eric