From: "Sreenivasa Honnur" <Sreenivasa.Honnur@neterion.com>
To: Joe Perches <joe@perches.com>, David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, Anil Murthy <Anil.Murthy@neterion.com>,
Sivakumar Subramani <Sivakumar.Subramani@neterion.com>,
Rastapur Santosh <santosh.rastapur@neterion.com>,
Ramkrishna Vepa <Ramkrishna.Vepa@neterion.com>,
akpm@linux-foundation.org, linux-next@vger.kernel.org
Subject: RE: [PATCH 0/9] drivers/net/s2io.c: Cleanups
Date: Mon, 31 Aug 2009 01:21:36 -0400 [thread overview]
Message-ID: <78C9135A3D2ECE4B8162EBDCE82CAD7705A1DF76@nekter> (raw)
In-Reply-To: <1251326878.13026.52.camel@Joe-Laptop.home>
Joe,
Patches look fine, I reviewed and tested these patches on latest
davem-net-next-2.6 sources.
Acked-by: Sreenivasa Honnur <sreenivasa.honnur@neterion.com>
Regs
srini
-----Original Message-----
From: Joe Perches [mailto:joe@perches.com]
Sent: Thursday, August 27, 2009 4:18 AM
To: David Miller
Cc: netdev@vger.kernel.org; Anil Murthy; Sreenivasa Honnur; Sivakumar
Subramani; Rastapur Santosh; Ramkrishna Vepa; akpm@linux-foundation.org;
linux-next@vger.kernel.org
Subject: Re: [PATCH 0/9] drivers/net/s2io.c: Cleanups
On Wed, 2009-08-26 at 15:33 -0700, David Miller wrote:
> From: Joe Perches <joe@perches.com>
> Date: Mon, 24 Aug 2009 20:29:39 -0700
> > Just a few cleanups, compiled, untested. No hardware.
> > s2io.c: Use const for strings
> > s2io.c: Shorten code line length by using intermediate pointers
> > s2io.c: Use calculated size in kmallocs
> > s2io.c: use kzalloc
> > s2io.c: Make more conforming to normal kernel style
> > s2io.c: convert printks to pr_<level>
> > s2io.c: fix spelling explaination
> > s2io.c: Standardize statistics accessors
> > s2io.c: Convert skipped nic->config.tx_cfg[i]. to tx_cfg->
>
> Since this is a pretty serious set of cleanups, I'd like to let the
> S2IO driver folks have some time to look at this and at least have a
> chance to ACK/NACK them.
No worries. That's fine. It's only cleanups.
I haven't heard from them though and they haven't submitted or signed a
patch for s2io in over a year.
Hey! Neterion people! Is anybody home?
next prev parent reply other threads:[~2009-08-31 5:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-25 3:29 [PATCH 0/9] drivers/net/s2io.c: Cleanups Joe Perches
2009-08-25 3:29 ` [PATCH 1/9] s2io.c: Use const for strings Joe Perches
2009-08-25 3:29 ` [PATCH 2/9] s2io.c: Shorten code line length by using intermediate pointers Joe Perches
2009-08-25 3:29 ` [PATCH 3/9] s2io.c: Use calculated size in kmallocs Joe Perches
2009-08-25 3:29 ` [PATCH 4/9] s2io.c: use kzalloc Joe Perches
2009-08-25 3:29 ` [PATCH 5/9] s2io.c: Make more conforming to normal kernel style Joe Perches
2009-08-25 3:29 ` [PATCH 6/9] s2io.c: convert printks to pr_<level> Joe Perches
2009-08-25 3:29 ` [PATCH 7/9] s2io.c: fix spelling explaination Joe Perches
2009-08-25 3:29 ` [PATCH 8/9] s2io.c: Standardize statistics accessors Joe Perches
2009-08-25 3:29 ` [PATCH 9/9] s2io.c: Convert skipped nic->config.tx_cfg[i]. to tx_cfg-> Joe Perches
2009-08-25 18:52 ` [PATCH 10/9] s2io: Generate complete messages using single line DBG_PRINTs Joe Perches
2009-08-26 22:33 ` [PATCH 0/9] drivers/net/s2io.c: Cleanups David Miller
2009-08-26 22:47 ` Joe Perches
2009-08-27 2:45 ` Ramkrishna Vepa
2009-08-31 5:21 ` Sreenivasa Honnur [this message]
2009-08-31 5:35 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78C9135A3D2ECE4B8162EBDCE82CAD7705A1DF76@nekter \
--to=sreenivasa.honnur@neterion.com \
--cc=Anil.Murthy@neterion.com \
--cc=Ramkrishna.Vepa@neterion.com \
--cc=Sivakumar.Subramani@neterion.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=santosh.rastapur@neterion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox